From: Pedro Alves <pedro@palves.net>
To: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4 00/14] Fix BZ 25631 - core file memory access problem
Date: Fri, 10 Jul 2020 21:13:09 +0100 [thread overview]
Message-ID: <0bacb203-018d-6e93-d4b3-488a5b5cfad2@palves.net> (raw)
In-Reply-To: <20200705225807.2264705-1-kevinb@redhat.com>
On 7/5/20 11:57 PM, Kevin Buettner via Gdb-patches wrote:
> This series fixes several core file related bugs. The bug which
> started this work can be viewed here:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=25631
>
> Other problems were found either during review or during development.
> I discuss these in my commit log remarks.
>
> Only some of these patches still need review. A brief status
> of each can be found below:
>
> 1) Remove hack for GDB which sets the section size to 0
>
> Nick Clifton has approved this patch.
>
> 2) Adjust corefile.exp test to show regression after bfd hack removal
> 3) section_table_xfer_memory: Replace section name with callback
> predicate
> 4) Provide access to non SEC_HAS_CONTENTS core file sections
> 5) Test ability to access unwritten-to mmap data in core file
>
> I think that Pedro is okay with #2 thru #5.
>
> 6) Update binary_get_section_contents to seek using section's file
> position
>
> Nick Cliften has approved patch #6.
>
> 7) Add new gdbarch method, read_core_file_mappings
>
> This is a new patch which needs review.
>
> 8) Use NT_FILE note section for reading core target memory
>
> This patch is significantly different than the v3 patch.
> It needs review.
>
> 9) Add test for accessing read-only mmapped data in a core file
>
> I think that Pedro is oky with this one.
>
> 10) gcore command: Place all file-backed mappings in NT_FILE note
> 11) xfail gdb.base/coredump-filter.exp test which now works without a
> binary
> 12) Add new command "maint print core-file-backed-mappings"
>
> #10 thru #12 are new patches which need review.
>
> 13) Add documentation for "maint print core-file-backed-mappings"
>
> This one needs a review from Eli.
>
> 14) New core file tests with mappings over existing program memory
>
> I've made all the changes that Pedro recommended, plus added
> a test for the new maint print command. It needs review.
I think this looks overall very good.
I've sent some comments to patches #8, #11, #12, and #14.
Once those are revolved, I'll be happy to see this go in.
Pedro Alves
prev parent reply other threads:[~2020-07-10 20:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 22:57 Kevin Buettner
2020-07-05 22:57 ` [PATCH v4 01/14] Remove hack for GDB which sets the section size to 0 Kevin Buettner
2020-07-05 22:57 ` [PATCH v4 02/14] Adjust corefile.exp test to show regression after bfd hack removal Kevin Buettner
2020-07-05 22:57 ` [PATCH v4 03/14] section_table_xfer_memory: Replace section name with callback predicate Kevin Buettner
2020-07-05 22:57 ` [PATCH v4 04/14] Provide access to non SEC_HAS_CONTENTS core file sections Kevin Buettner
2020-07-05 22:57 ` [PATCH v4 05/14] Test ability to access unwritten-to mmap data in core file Kevin Buettner
2020-07-05 22:57 ` [PATCH v4 06/14] Update binary_get_section_contents to seek using section's file position Kevin Buettner
2020-07-05 22:58 ` [PATCH v4 07/14] Add new gdbarch method, read_core_file_mappings Kevin Buettner
2020-07-05 22:58 ` [PATCH v4 08/14] Use NT_FILE note section for reading core target memory Kevin Buettner
2020-07-10 20:08 ` Pedro Alves
2020-07-14 7:53 ` Kevin Buettner
2020-07-21 18:21 ` Tom Tromey
2020-07-21 2:09 ` Kevin Buettner
2020-07-05 22:58 ` [PATCH v4 09/14] Add test for accessing read-only mmapped data in a core file Kevin Buettner
2020-07-05 22:58 ` [PATCH v4 10/14] gcore command: Place all file-backed mappings in NT_FILE note Kevin Buettner
2020-07-05 22:58 ` [PATCH v4 11/14] xfail gdb.base/coredump-filter.exp test which now works without a binary Kevin Buettner
2020-07-10 20:07 ` Pedro Alves
2020-07-13 11:38 ` Strasuns, Mihails
2020-07-13 17:04 ` Kevin Buettner
2020-07-05 22:58 ` [PATCH v4 12/14] Add new command "maint print core-file-backed-mappings" Kevin Buettner
2020-07-10 20:08 ` Pedro Alves
2020-07-10 20:10 ` Pedro Alves
2020-07-13 17:33 ` Kevin Buettner
2020-07-05 22:58 ` [PATCH v4 13/14] Add documentation for " Kevin Buettner
2020-07-06 2:26 ` Eli Zaretskii
2020-07-05 22:58 ` [PATCH v4 14/14] New core file tests with mappings over existing program memory Kevin Buettner
2020-07-10 20:08 ` Pedro Alves
2020-07-10 20:13 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bacb203-018d-6e93-d4b3-488a5b5cfad2@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).