From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by sourceware.org (Postfix) with ESMTPS id 7914D3844044 for ; Fri, 10 Jul 2020 20:13:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7914D3844044 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f67.google.com with SMTP id o2so7073577wmh.2 for ; Fri, 10 Jul 2020 13:13:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JIrY0HQ87oZzrja5n9LK2sYrxaWozRDUa1lM261Sdu0=; b=o5OPuhqw8qruiXXfVXVGhpKceprJsAZ7c5zCQqRrrKeKMsYtPnUzzj+8jYltFETjzy 9AvoTe3IfRMzw6O55d4ynjQSmncrH+sTjUufZC45B3zck+avniRXMbUxpsmrBAW8wo4t +gp01dY9W9Mqh5c728lXSwvzudVcIFOjCdcKCxeOWh719IpFSk9Vn/RKcmkgvSOHpl77 o1AKr71z5JY3NqpOos+7HforNOfKqi2V94d4ZcOFiXX6qdwghCZOnGFW2o9vdGEf8XpP ISeuBv1prhtAvje+qxVbFE54bx3eQFWuv9ebrVFiEyxb4YgMRioq4uXXNYbOy0ijqk+T aqRQ== X-Gm-Message-State: AOAM530u6qCSgqZKo3RYCxA6dFDd4tYf3TESkSqkxcxsBQnOU4lBIVQJ Zkxot6DHYlwVSzxnLr5yrSnhEC6Nd8s= X-Google-Smtp-Source: ABdhPJxdG1oKoPUYfzyiuRfghG/oITynjA5M3VjKfKUWuHmqnD/NymbNdDL+BdQoXluTinwcWC5hAA== X-Received: by 2002:a1c:2349:: with SMTP id j70mr6612116wmj.22.1594411991225; Fri, 10 Jul 2020 13:13:11 -0700 (PDT) Received: from ?IPv6:2001:8a0:f91a:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f91a:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id d28sm11076735wrc.50.2020.07.10.13.13.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2020 13:13:10 -0700 (PDT) Subject: Re: [PATCH v4 00/14] Fix BZ 25631 - core file memory access problem To: Kevin Buettner , gdb-patches@sourceware.org References: <20200705225807.2264705-1-kevinb@redhat.com> From: Pedro Alves Message-ID: <0bacb203-018d-6e93-d4b3-488a5b5cfad2@palves.net> Date: Fri, 10 Jul 2020 21:13:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200705225807.2264705-1-kevinb@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2020 20:13:14 -0000 On 7/5/20 11:57 PM, Kevin Buettner via Gdb-patches wrote: > This series fixes several core file related bugs. The bug which > started this work can be viewed here: > > https://sourceware.org/bugzilla/show_bug.cgi?id=25631 > > Other problems were found either during review or during development. > I discuss these in my commit log remarks. > > Only some of these patches still need review. A brief status > of each can be found below: > > 1) Remove hack for GDB which sets the section size to 0 > > Nick Clifton has approved this patch. > > 2) Adjust corefile.exp test to show regression after bfd hack removal > 3) section_table_xfer_memory: Replace section name with callback > predicate > 4) Provide access to non SEC_HAS_CONTENTS core file sections > 5) Test ability to access unwritten-to mmap data in core file > > I think that Pedro is okay with #2 thru #5. > > 6) Update binary_get_section_contents to seek using section's file > position > > Nick Cliften has approved patch #6. > > 7) Add new gdbarch method, read_core_file_mappings > > This is a new patch which needs review. > > 8) Use NT_FILE note section for reading core target memory > > This patch is significantly different than the v3 patch. > It needs review. > > 9) Add test for accessing read-only mmapped data in a core file > > I think that Pedro is oky with this one. > > 10) gcore command: Place all file-backed mappings in NT_FILE note > 11) xfail gdb.base/coredump-filter.exp test which now works without a > binary > 12) Add new command "maint print core-file-backed-mappings" > > #10 thru #12 are new patches which need review. > > 13) Add documentation for "maint print core-file-backed-mappings" > > This one needs a review from Eli. > > 14) New core file tests with mappings over existing program memory > > I've made all the changes that Pedro recommended, plus added > a test for the new maint print command. It needs review. I think this looks overall very good. I've sent some comments to patches #8, #11, #12, and #14. Once those are revolved, I'll be happy to see this go in. Pedro Alves