From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2073.outbound.protection.outlook.com [40.107.243.73]) by sourceware.org (Postfix) with ESMTPS id 441AB394843A for ; Tue, 22 Mar 2022 14:37:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 441AB394843A ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XsAhevmGgVNjWhOb8s0WEx314De+0iTcLotPsRqRLRu8ePBiqd2btBAN28Tj+NbZGVHnso/mgIGmL2bWhGvJQ/WNS+R9JAM/ZKb+upkpCXAf4MYIPHYdNO8/q1hJfrNlmDG2T+Uw3yrdp+AQkBNQjXBJQ04a0I9IrFTNvxVevsWPsVJpHWYMawAiB5ZClIw4UIOzth2Cjq9RAhKr1zgnIWMd2LQmlxYgfYdHgmHRtgb/XDmnd0dv0Mt1+rCQQW4AfvaQLL17Zm8eCy4yfZwmswEFxrVsvUhR5NpXzm3JWRIGMvHva039v6uD21phH6A/7ZyBfvv9koySDqL6DNYDtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yPyu6DZ5hx9KoDs6UnblaYiNkYNijzcDv7TpbfNDVLw=; b=TcveBY8HWBQSd8Ti3pbgqwAue62cuXSjNJ/cTScMahtcqIbOoLZYG44CmTamNBITSS0C6+r6jaotdTqspiumg0MuZmiajlCi1tWHbV3iIuqJFH32rlqG2ozOFjWPQA5gDTIk8T5H5ntG7Pa7b3+RJ5qkmE7x9LONX7Fnuk187rYe29q4J5ld28pXSIes0Y0FK9AAx8VLnNA/xzJxnQ3adXgAII11GAGPj9A6CG56PfIVpPPJ+PVF/dBT40d2utALAsQMiZDH5JJjb8gPeT1a98ebP2Yoo2cis6W5gp55jc09OW34ZQsnXq0qydZVR7gz6ZpSkO+o2KEUIO4obiDh4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labware.com; dmarc=pass action=none header.from=labware.com; dkim=pass header.d=labware.com; arc=none Received: from DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) by DM8PR17MB4917.namprd17.prod.outlook.com (2603:10b6:8:34::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.16; Tue, 22 Mar 2022 14:37:22 +0000 Received: from DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::b4e5:7f52:3fb8:ef7b]) by DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::b4e5:7f52:3fb8:ef7b%7]) with mapi id 15.20.5102.016; Tue, 22 Mar 2022 14:37:21 +0000 Message-ID: <0bcb4286c01054c30c3539c76bd6426ff3b333eb.camel@labware.com> Subject: Re: [pushed] gdb/mi: consistently notify user when GDB/MI client uses -thread-select From: Jan Vrany To: Simon Marchi , gdb-patches@sourceware.org Cc: Andrew Burgess Date: Tue, 22 Mar 2022 14:37:15 +0000 In-Reply-To: <897bd508133687e4d30994deecdd87786d71334d.camel@labware.com> References: <20220316150914.1254897-1-jan.vrany@labware.com> <78570a7f-f6c0-5e1b-4178-c9ce401feab7@simark.ca> <897bd508133687e4d30994deecdd87786d71334d.camel@labware.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.43.3-1+b1 X-ClientProxiedBy: LO2P265CA0176.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::20) To DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0885495-6709-47f3-e393-08da0c1178f7 X-MS-TrafficTypeDiagnostic: DM8PR17MB4917:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SQzg3Wohret3sEHE4dShSWi7NcEknDqH395c2EvALmFhvHE7P0M06VTKu7V9JqIJWM5GK8Ze1hRnPIf9ojPX5k6xsm3YXx0eaEoDSxsTlLeEvKZzjTYpo1/z3EHiGTVt5QQ970xF5838MpUtb3ycyWNmy8iPF0MdBjbqF2biB1+HIR5RT0mwPfEtQSK4+cLMuNKvoaUkIvF74dtqtKo/ClrHGoCo8F2a2UDxTmt875novSLyr6SjGEDIKEqxdLWUJyl9hU2SAGiqvAO2CxZk9HkLQ1/c8X3Q4AzNnHgGZ2De/43FhgybdeU0B7JBfYar7nlE/18DLhi546fZcwTVfJOip5WDBskjoaelWrZHChFPoc1YPcubfbROedGb3RKS876mzOLopqY5Ut0pFBWBxTeROP60pwkWB+1+f0s8/eg9P4k48Z80G4F7w0Hq9UMLy1sYWNgiDTv675C+E+zKFLgRzlyUmEYGS0nPOBYGjg9t69WFSOj8A/9ksDNx80v3Wofs5NfFZRX928eD0RPLBZN+ay4l+ax7EWAo6qFkyNvOhEqyBXbWTAxl/YjFiAwxsMNxBcDxQ/8TZ00gE48Mqcy0e9pQkbSKPaA2Am9HojODy1NFUhDdkBduel6aiVMcRIPyDSV0wSS1eTbAU4GbuTvK8L9CYQLKhYYkngtxq1HBel4gPMOGKpjSAlab08f9vownNsgSG/pBMYBgQmQnsxIEQBqTedw1DNdqRiQ6UlauArwdW1YWC9j0Pcfe6ZoHKXvTKvFsgb1lNQF6u4XmUqipeM/ElBDsbZEF8vcOvlB/nqu2Rm59ob8Z1ZKXSReZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR17MB3113.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(36756003)(6506007)(316002)(2616005)(86362001)(6666004)(186003)(26005)(2906002)(6486002)(966005)(508600001)(6512007)(83380400001)(4326008)(44832011)(8676002)(66476007)(66556008)(66946007)(5660300002)(8936002)(38350700002)(38100700002)(52116002)(53546011)(403724002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDFRWE81TE42K05MR2hqT3VpaFdkeDBLQ3Bna09PUHFqUnBIeXBzMXNWbExQ?= =?utf-8?B?K0hxaGE1NXMzQ1BqclBjcXlybU1yUm84bFQ4TlErdHR1cjFRZno3RG1POW5Q?= =?utf-8?B?Z3RqMXNud3R2ZkZpREJDLzA3NnRLNVVRa05WWkp6WkhMZHdOUGFFZzJrazdO?= =?utf-8?B?QXNRa1BSdzlleXFkMFBsSG1KdEZzYnlybzFqc0ZnVUlwNTZQNm1WZCszclRo?= =?utf-8?B?T1lEYllDQ2xvZnlJOE03SWxUOG9Rdmg3Z1NrUHNCZVFpVFI2cEZnNVhDUHVU?= =?utf-8?B?T1FISW9ocnhhZnRFSHFoaUphQ0k5VHR1QmlNUHphdlYyNXo3Q3ZKdmwxNi9i?= =?utf-8?B?eTh6MjExQVZuUnhnM2lkZktOeFFwbVI3STlSQXNkdWZGRU1FVmJQUForYWZR?= =?utf-8?B?d3d6bmxYT1VFTFFOZUc2Z3pYWkpzRjFwSGdZa3pUWlgxVGdjRnRMUk9aOFI0?= =?utf-8?B?NXVVN2IxZ2xVUnU0WkFKWkI2Y1JJWTBPdGlzRnBLWVZMVWR1WUEvZllyUjhr?= =?utf-8?B?ajZTcE9mc0V2VVZFWlBLcXBnS2lFb0RMNEo1YlhCdEhGZWxRZHZwMGdjNzRn?= =?utf-8?B?aGRRbG5vNWZkTnk0VExUcFpDLzU5bEtXbk81MUJ5dktCK1JXcEtJOHZ1Y2tn?= =?utf-8?B?QThmUEM3bXBob3ZuRGwzODNOQXZEUnhLeTY0VXZmZldVZWRUQXV3MGR6K2Y0?= =?utf-8?B?bTRCdlhRK1Qra004WVh3NlJoOUNiTXBPYmJWZ3JuU3lSOUQvWEZhZnBkMC9K?= =?utf-8?B?Y1NxaWVmSmZKbmc0TmdLL0NHQmtVRnlKendDSEhyWnlPMEdFR3hGOHhvcSt5?= =?utf-8?B?TkYxV254OTFocHpYWWxNYUQxQ1JRKzV3dDVqeEFQaTB5WUcxZGpwMk44eFMx?= =?utf-8?B?cmNGMHFtTmpqbDBuN1ZIem4raUZTekNKV3dBd2xMQUgyNFpuYkh4b2dITXNV?= =?utf-8?B?aVB1cytFVk5zKzN4TTk1Y25UYTFNQTNOTjBSNkJhWnMvdFcveDlWclZxcGk5?= =?utf-8?B?QWJpZnIyUEQzZUgyNXlBbC90N0lEZXVYRUpLekkrRHo1MkxYWENCbDYyWHFO?= =?utf-8?B?UkU1ZXo1bDMrV24reHJLL2V1aWQ5QjVTcE1HREhSTjErRW5JQVBwN0RVL1V4?= =?utf-8?B?VlNrbktWQ2Y4TFJ5dFV6aCt6dVE4c2tsTDgvNW1MTjJOTVV2OXVUWGdSWHh6?= =?utf-8?B?aE1raDNxdDRDR2JtQTVwbWhhNkViTU1BU24vNUpOdGxDSnBncXQ5YUQ5amFM?= =?utf-8?B?OWFkOG83c2NlcUwvd3B2bE0rQVdmR2tHa09jY2pYSjJFczVBcklCa2xrWTdH?= =?utf-8?B?dE9JNzhYdVkzOTVIcEJJSGZhcUl5Q1lKYnRBNlV4eTlsRW1PK1NXc1lXSnk1?= =?utf-8?B?VFUvNG9sMDdNdWlkNHZlTGdpUXhFZXhCMlVPN2tndmVKcXRDZ0RkOStzR3hu?= =?utf-8?B?b3hva3dCVERxd1AvYXFOejhlU2xJR3k2RStKZXVidDMzT2xmMUdUeW5HRDdO?= =?utf-8?B?amZ4Sks5TWFtalpVMWJrVlhGM29ranhDSC9RVGJMRjJqM2syQUtKK0pPOWZF?= =?utf-8?B?YnpqdEVQR0JyZTJmMHdzQ3hEbEU5REtSYjVoM1hLUUYrRTZYaFZRclAzZm9r?= =?utf-8?B?SkpVVE0xanhyNys2K1luSnZpcDVCbytsNUNGb01rVnZ1UGtmbUdDaHZra3ps?= =?utf-8?B?QjJzaDFjckgyTVd0ZmpPcm16UDR5M0lsV3ZXUkRWMTd3ZnNuRWZ1SDVHWlRa?= =?utf-8?B?WlM2UmMySitqaGRLOUducHU0ci9rQktwV1RQZmlUOFJIZDduWXh3ajV0SWxn?= =?utf-8?B?WVd0a3pUeWR6VzFiWWM1Z3E0b2g5MFVpcW14MTJ3NEdGS00zKzdhbmwrK0JK?= =?utf-8?B?WEM1L0lkZDNqQUVjSXlyNS9PZ1NpbGpzLzRHN3Y3WGp3cG8rTTRtSjlERmFL?= =?utf-8?Q?Y2cWWYCR1S9/uIL0bNGqyifdWeVRGfBE?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0885495-6709-47f3-e393-08da0c1178f7 X-MS-Exchange-CrossTenant-AuthSource: DM6PR17MB3113.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 14:37:21.8584 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zjFQNo7ZXn9nohmkiQkQ/tjP8BalltbGkKYsGx5Q7sOpBsU+LrOo5lp02i79nIYyHTI1lzUnWAKtbspXG7D1xQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR17MB4917 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2022 14:37:26 -0000 On Mon, 2022-03-21 at 21:01 +0000, Jan Vrany wrote: > On Mon, 2022-03-21 at 16:35 -0400, Simon Marchi wrote: > > On 2022-03-16 11:09, Jan Vrany via Gdb-patches wrote: > > > GDB notifies users about user selected thread changes somewhat > > > inconsistently as mentioned on gdb-patches mailing list here: > > >=20 > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__sourceware.o= rg_pipermail_gdb-2Dpatches_2022-2DFebruary_185989.html&d=3DDwICaQ&c=3DsPZ6D= eHLiehUHQWKIrsNwWp3t7snrE-az24ztT0w7Jc&r=3DWpFFGgYa98Yp-c29WHTCwU1wAGFBvszA= 6a4RzgpMSqc&m=3Dqn1ryn0GnzccCli0TKe7kc6WpMiz1opcXfyT-fLWkIk&s=3DXoLasKCD9ag= RgS73PoGDnzPlKbo4_lL616HCUvldty0&e=3D=20 > > >=20 > > > Consider GDB debugging a multi-threaded inferior with both CLI and GD= B/MI > > > interfaces connected to separate terminals. > > >=20 > > > Assuming inferior is stopped and thread 1 is selected, when a thread > > > 2 is selected using '-thread-select 2' command on GDB/MI terminal: > > >=20 > > > -thread-select 2 > > > ^done,new-thread-id=3D"2",frame=3D{level=3D"0",addr=3D"0x00005555= 555551cd",func=3D"child_sub_function",args=3D[],file=3D"/home/jv/Projects/g= db/users_jv_patches/gdb/testsuite/gdb.mi/user-selected-context-sync.c",full= name=3D"/home/uuu/gdb/gdb/testsuite/gdb.mi/user-selected-context-sync.c",li= ne=3D"30",arch=3D"i386:x86-64"} > > > (gdb) > > >=20 > > > and on CLI terminal we get the notification (as expected): > > >=20 > > > [Switching to thread 2 (Thread 0x7ffff7daa640 (LWP 389659))] > > > #0 child_sub_function () at /home/uuu/gdb/gdb/testsuite/gdb.mi/u= ser-selected-context-sync.c:30 > > > 30 volatile int dummy =3D 0; > > >=20 > > > However, now that thread 2 is selected, if thread 1 is selected > > > using 'thread-select --thread 1 1' command on GDB/MI terminal > > > terminal: > > >=20 > > > -thread-select --thread 1 1 > > > ^done,new-thread-id=3D"1",frame=3D{level=3D"0",addr=3D"0x000055555= 5555294",func=3D"main",args=3D[],file=3D"/home/jv/Projects/gdb/users_jv_pat= ches/gdb/testsuite/gdb.mi/user-selected-context-sync.c",fullname=3D"/home/j= v/Projects/gdb/users_jv_patches/gdb/testsuite/gdb.mi/user-selected-context-= sync.c",line=3D"66",arch=3D"i386:x86-64"} > > > (gdb) > > >=20 > > > but no notification is printed on CLI terminal, despite the fact > > > that user selected thread has changed. > > >=20 > > > The problem is that when `-thread-select --thread 1 1` is executed > > > then thread is switched to thread 1 before mi_cmd_thread_select () is > > > called, therefore the condition "inferior_ptid !=3D previous_ptid" > > > there does not hold. > > >=20 > > > To address this problem, we have to move notification logic up to > > > mi_cmd_execute () where --thread option is processed and notify > > > user selected contents observers there if context changes. > > >=20 > > > However, this in itself breaks GDB/MI because it would cause context > > > notification to be sent on MI channel. This is because by the time > > > we notify, MI notification suppression is already restored (done in > > > mi_command::invoke(). Therefore we had to lift notification suppressi= on > > > logic also up to mi_cmd_execute (). This change in made distinction > > > between mi_command::invoke() and mi_command::do_invoke() unnecessary > > > as all mi_command::invoke() did (after the change) was to call > > > do_invoke(). So this patches removes do_invoke() and moves the comman= d > > > execution logic directly to invoke(). > > >=20 > > > With this change, all gdb.mi tests pass, tested on x86_64-linux. > > >=20 > > > Co-authored-by: Andrew Burgess > > > Bug: https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__sourcewar= e.org_bugzilla_show-5Fbug.cgi-3Fid-3D20631&d=3DDwICaQ&c=3DsPZ6DeHLiehUHQWKI= rsNwWp3t7snrE-az24ztT0w7Jc&r=3DWpFFGgYa98Yp-c29WHTCwU1wAGFBvszA6a4RzgpMSqc&= m=3Dqn1ryn0GnzccCli0TKe7kc6WpMiz1opcXfyT-fLWkIk&s=3D_9JOeNLk-p5CQtAtasdJbRy= V5KK5tq1qLb_IxeKdmMw&e=3D=20 > >=20 > > Hi, > >=20 > > I see this on Ubuntu 20.04, am I the only one? >=20 > Weird. I just compiled GDB commit f55649cc and see no such failures: >=20 > > make check RUNTESTFLAGS=3D'TRANSCRIPT=3Dy gdb.mi/user-select*.exp' > ... > Running /home/jv/Projects/gdb/origin_master/gdb/testsuite/gdb.mi/user-sel= ected-context-sync.exp ... >=20 > =3D=3D=3D gdb Summary =3D=3D=3D >=20 > # of expected passes 419 >=20 > I'll try on Ubuntu 20.04 tomorrow.=20 >=20 Just tried on Ubuntu 20.04 and I do not any problem.=20 Jan