From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by sourceware.org (Postfix) with ESMTPS id 9CC183858D28 for ; Wed, 3 Nov 2021 18:52:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9CC183858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f54.google.com with SMTP id f7-20020a1c1f07000000b0032ee11917ceso2620829wmf.0 for ; Wed, 03 Nov 2021 11:52:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=761M40P8vrAZgRQBwILcCStUm8y7Y5riiSEpzMyumt4=; b=Enu74iI264B7PbChwwqMpZ/42yFrH5sAXsnClgzOLo0odojQ8k8Ew8OEbmKuh6C5ZC spXUKNH54vgvX3hPKvruO24DxXYUQvGTdjhTiCJPEdN9ejK4pZ9cn/F5aGGu8+qA8w8G Q2g8E4ObfaaoIB4tjz5ZfZR9Vf7Pp4n4CK7fufcwM/EQGpDJw2RHdc18Styh+J2SsvRf Oz3sHkXH5J9bcCFvE+wHu+lzN6JdGjjiKpjAU2sjsCbx3iL/yZi1lzFThNaaBsGQfNtd 58QPlIpKAfq6Nom0gFwXExCj1+tJvu16Bqu4MpmZqJwnS7OWwYIsK+l+ByjTIsDoymRO qhYg== X-Gm-Message-State: AOAM533ngt5Rn1rWe5p2mqkf3lHGG1dxTq9KNr9qyBKrqBpZvduOmm0w +4c4nwC2aqirzv/f3twgI+oOXFJflBcp8g== X-Google-Smtp-Source: ABdhPJwcHxjBSO2qBhWjXiUvcI8JMN8Vs50xYwZjh7E9Ij61AWHaYx6cBdFFbwZziU7HpN8ni/li/A== X-Received: by 2002:a05:600c:3b8f:: with SMTP id n15mr17908950wms.180.1635965537622; Wed, 03 Nov 2021 11:52:17 -0700 (PDT) Received: from ?IPV6:2001:8a0:f912:1a00:fb57:3faf:e98:b979? ([2001:8a0:f912:1a00:fb57:3faf:e98:b979]) by smtp.gmail.com with ESMTPSA id p18sm2664774wmq.4.2021.11.03.11.52.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Nov 2021 11:52:16 -0700 (PDT) Message-ID: <0be6bfa9-83a9-fd7d-e218-58b331ab6569@palves.net> Date: Wed, 3 Nov 2021 18:52:15 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 0/4] gdb, btrace: infrun fixes Content-Language: en-US To: Markus Metzger , gdb-patches@sourceware.org References: <20210316093501.936148-1-markus.t.metzger@intel.com> From: Pedro Alves In-Reply-To: <20210316093501.936148-1-markus.t.metzger@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2021 18:52:19 -0000 Hi Markus, I ran the tests included in the series against pristine / unfixed GDB, and got: Using /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/config/unix.exp as tool-and-target-specific interface file. Running /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.btrace/stepn.exp ... Running /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.btrace/implicit-stop-replaying.exp ... FAIL: gdb.btrace/implicit-stop-replaying.exp: thread apply 1 info record Running /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.btrace/step-hang.exp ... FAIL: gdb.btrace/step-hang.exp: continue until exit (timeout) Running /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.btrace/cont-hang.exp ... FAIL: gdb.btrace/cont-hang.exp: continue until exit (timeout) Running /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.btrace/multi-thread-break-hang.exp ... FAIL: gdb.btrace/multi-thread-break-hang.exp: stepi.2 (timeout) FAIL: gdb.btrace/multi-thread-break-hang.exp: stepi.3 (timeout) The curious thing is that stepn.exp doesn't fail, it passes anyhow. Is that expected? Also, I diffed gdb.log before/after patch, and noticed a difference. GDB no longer prints the current location: No more reverse-execution history. -main () at /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.btrace/record_goto.c:50 50 return 0; /* main.3 */ Is this expected? Thanks, Pedro Alves