From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2052.outbound.protection.outlook.com [40.107.116.52]) by sourceware.org (Postfix) with ESMTPS id 3A5783858D20 for ; Sat, 14 Oct 2023 20:01:30 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A5783858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.116.52 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697313691; cv=pass; b=qY0H6DJSK1oCIhAB5Jm/jsvDi3X2TSfU8X76v4dBeGrcv0uZxnUvefH33kU8aVFwblPeySPKN5QQ5Tc2/89Gh4boPdHfiZKWZLwxgRHa1VTa1JsiQ35llE/rPEuU0vzQMOKAaFXe4ZLXWCDO5DUNmZ7467QDoc5TXWQZSfJc1jw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697313691; c=relaxed/simple; bh=pjJxt3gxZhFasUkYiWxRNX6J+xe89x7AbVyoE+dR8A8=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=KNLcjKR090doLdNFqboX59UZZSisNz8k0jwzPvMDcSAEbrObQSk1wMgm2ONFZLLmp97b+VIQvQf1kVDuFoVASSqLN3GDKw9NWHXxRph8Msg1JZGT7SPxzFxBnsTRzOlIZC2oGyYWkcVXj4nSRYp4OUYnPFGxsAdwQTtPkaQpEUw= ARC-Authentication-Results: i=2; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A5783858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m7C60X90gyCX44mLUWGyfpTGanDT6o8is4HOGVblpbxc1MSEuCrcZVaUfnNKXGWR457vAgK/9dUO/7AJObmR5evgRYtXR1rSQvySanyzw8BfKf18snAB5P3oEqdbCCY9C2DdKnyztkNk9bMnxcbX4HOjdjhSeHDEsHqIjBRnbizImx+N1c5pF8DxjOdDuZbpA5cbMZon+8xDrrvMt9J1tYk2+CEtfIZM+6gsHnwNj7KYM9I1Wo6BIa/e5FgAJCrdxF5wYmYGvVQI+sZwatm1oQSiOT5sHpFLXgoEbS2g6O+fNXHY0K0hkYwZ5SlatPgWCrHMwJv38XGk2EZR1pD1UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jPZ87x/5uieEcO1vlokIlxXg/q/mt5U7Qu6ojk+t4bs=; b=i/7+mj/5RlZPBb6rqSlh8P37X81riz/CL63Biizy5/E+d9PhoPyOT4Js3iG2ZX+p5ApY5tvYDDN7GWcgThkLurvwV2fOF4IARNnEHthsfVGAaPgq00eJm1WMR3MW9W7CDkYqxVs6cggqQBGSN9WpvEBl2SC3uNPzX1S2663apSyf7fIelOyakDvD/RDdX8ik3NTwQvVK/7rouBnrgiDoS7tDSSrMQE4ik8jEjwDK/Vub28g9Mc5dULU3BRFUNbwQkLYljYdUlkS4VAi32Ea7193dxAz/c4TcLUfW/J7BRQsb5AkVF8yVtFnp7aU1EPUsUPDge1cCmQlfRQEFuJOjQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jPZ87x/5uieEcO1vlokIlxXg/q/mt5U7Qu6ojk+t4bs=; b=k0S7KrfhH3sb3H/JGwQ5RZataNvkN2/U1CBNeW+CcftCz4IRtv7+pzaVDE4hNZJdRH+tBJiV4Rcuw8XLrQq+t1nxVHJ1yNOXuSHgvvzt7IMSSEEj2eSO79c8D3nbO9a5wxDxllckUfFbbOdA5U3gOczBPgFHmTRpADI9kkh6DBazlqFngD1u3lO3whGO1299q+PNyr6P4p8yWkesTsJlO1QCezcvCmDwICyhI/kKbzLVkRIWdNmQV5hu3hGsX62LW9GMdmoqBYwslG7HXjsWNh3amzFdoEJsKnYXB3QzZUDk2K82YUwIk4fBrppeTgXsizNMjBG4nqQMsryKNowAvQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT2PR01MB8615.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:b6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.34; Sat, 14 Oct 2023 20:01:28 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a%7]) with mapi id 15.20.6886.034; Sat, 14 Oct 2023 20:01:28 +0000 Message-ID: <0be75e99-6597-41be-a620-1b4b0e07b44f@efficios.com> Date: Sat, 14 Oct 2023 16:01:28 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 20/24] gdb: make so_list::{so_original_name, so_name} std::strings Content-Language: fr To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <20231010204213.111285-1-simon.marchi@efficios.com> <20231010204213.111285-21-simon.marchi@efficios.com> <20231013222830.d3pi7di7ak4hiw57@octopus> From: Simon Marchi In-Reply-To: <20231013222830.d3pi7di7ak4hiw57@octopus> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0123.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:1::23) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT2PR01MB8615:EE_ X-MS-Office365-Filtering-Correlation-Id: f28c3c4e-8fcf-483e-1942-08dbccf05a73 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9QtWQyZLPfoeP7mE2QIG4TuPbhqKJmwZqAD55yfhuAFwl7nIvlvLCF5TUMqb50tksoSziiFrlx1Iik1Q7Uy2I78uGqNMinM46Eyv4+0oL9EOnE726IIvbSF3C1/IVVXRP2EQuHWo+76GHwTc/HFzTgU1JkDST8F+uX4gtDg0DK8v2K+R+YR53tKKLbTDSmJYqfcw8Ft9+jLqOoKfgh1N0//8m6oaogZ02aBmXcoNLj98zBm6NDuAN+c3Zqk6v38FuDQJWZ6/AT+5msblMC3u5oudRqfLEKsF7D91pVRRRy0rG+UMksmS/raxNuq+cgnjGC/TPQb75OalFTsOoCtkGt4ToNnxqe0sHdtOFeUEd9sdGnRMTiAbJ0pt/f9yH3fVfwEfJXSX9JbuNHct41H8SjdEdqpvhDB+Vthn7j7NZH2LNXbPY00SgHieGSr1cjKUsnrFotyiXjcNFHHLiIGQSjb7YezMo8CfXeM0dOvTRXNbjIsk8r40E0Vo1YkScyriDisKM3BjrfmZXlMBT9uaYmKkSN5ZTOoNNMSxgs7lXsgseEQaOFK3QKhVp/bxLgQzDAKKxTBzQ8mHDhLKBBM5mvU2bCl9YkjBHVydUB8kOId4z3JFU05TaVr4znvW6tcKSGkfTPoI1967I+7OPMBuyg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(136003)(376002)(346002)(366004)(396003)(39830400003)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(2616005)(26005)(6512007)(53546011)(6506007)(83380400001)(41300700001)(44832011)(4326008)(5660300002)(8676002)(2906002)(478600001)(6486002)(8936002)(66946007)(66556008)(6916009)(66476007)(316002)(31696002)(38100700002)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0huOTA2MzV4c2FCNTh2YkRETHQwaFBycmRHMUdOTkNxcmVLUy9xL1RGUUFh?= =?utf-8?B?ZG5SbDBPNlFJMENNVWF6N0ExUjZ5NmpSN01WMGNERU5yVG90VHV0Yy9ZRVp2?= =?utf-8?B?SVptQjlPaWt1bGczb3dUcHZ4WWdzcVBIOXoxUEc2NnVuTU02ZXhiQyt6OTdW?= =?utf-8?B?dlpDWEsweXc2dmJUQ25vWU4wZHBhcktzRDRQalJkcGlYN1B6MkI5cExQNlVv?= =?utf-8?B?VHpOM2JaNlNvWFlidzlCZ0xtK3cwVnBvaVJvSm1WbUhwcXBQS0JaSDFTVFdv?= =?utf-8?B?RDE5MjdXL2VwMHk3ZWVLUjc2Y0tuK2orekNCdnMxaFQrZlVoNng5aVRtbG1R?= =?utf-8?B?RlM1SEtjbVZMSE0wTFBYbHQweUtrZnFtalBwSy8xZlVoZGR5R0dEVHhnRDJD?= =?utf-8?B?RGFrNUlYRWdWRjNFaXE1OS9DZzVOeGFidFN3N2RLa3BKMEMwWDBaZzYvZWkz?= =?utf-8?B?aGpQN3A3dU9CS3hWMUFRTGxpbXZBWWk0a0hDMmx5OEF2MmdqYjFGai9mZlJS?= =?utf-8?B?eUxvOWxGeWhvWWJHNEpRUWFoQVJzQStUMjlsN2xjaU4wdFRPdWNBeDg3T25K?= =?utf-8?B?N29pSlEwSGJ2RXp4MW85Zy9GaXBOcnhMTkRGK280QmVyZ1lIVEJCTE9VZzVl?= =?utf-8?B?WTEvUE9CQWhnNTE1bjNqWkVoRHBlenZsQUZoMHlzajdNVmVqNkZkNCtSTldS?= =?utf-8?B?QjFGYm9wTjdOd2pOeU9RZmQzS3NwZ01JZkVTTWZ6VW41U1JlTGlUTnJCUjJ5?= =?utf-8?B?TFMyKzJ6TG5JUnFleFl2U1hhUHhkY3YxTGt2SU01MitlSkhDSnpKSVl1bVlq?= =?utf-8?B?cUMzdnhxN3IrZ3hIbDZENC9tNU1IamNsNWlsMml0TUszRFMwOG1oUDN6TW5Y?= =?utf-8?B?bFRwZjVYVTFVbkRrN2xCR3ZIbXhIbXJIc250V21lQ3hMaStsYVBxcm1MZHIz?= =?utf-8?B?U3VpbzluS2VBZlBBSENRZkxrTWsremV0TFFDdCtUc3dzb09WTzI2ZmpaSWh5?= =?utf-8?B?TDA0QlN2ZFJ0Z3VpWjlodjcrZ3gzZUlzaVRINlVvUjB1dzA0SVFoaXZrNEZa?= =?utf-8?B?SDRhNjhLVlI3YjdJV0w0aTBENjZVSW5KNGdlNDlwTU5KcExhbVd1RGRLaEpn?= =?utf-8?B?Vy9ycTNtZzFoL0M1akpLUEpzdnZLT3d3aVBlMW50RkZzaThZN09uRU9mMFJW?= =?utf-8?B?cThSR2JTeWtGM3Ywd1d2ZHNBcDQ4U0hwOVYzV3JlUG9pa1kzVjV0OEhIcVpr?= =?utf-8?B?MzNFS0ZPSXAxS3pkeWtqZ0E2YWFYbmxhZ3NieEdVcTJ2YmJiMmgvYnI2c0V4?= =?utf-8?B?SjBicSt1T1UvQkJmK1pySUhVejZadTdHaStIYy9YL3lsNTNnZFhiNWY2WHAx?= =?utf-8?B?VWxRZ2NpTXRHUm5HWlpack9uZDNUMm1oSE9BR3JKTzRzOW81cFZ0SW84QnRh?= =?utf-8?B?WUUvblpNcEQzeDZtak8vN21tamVYMFlHNk8ycTNrd1UyaEZuOGViSG13dnM3?= =?utf-8?B?SWFDMXZPWGFzTm91MEtjTVNYd3JjZ1M2QXlOR01LNGRiSE1CNTB4cUFDWUMy?= =?utf-8?B?NlBKeHFlSmtIZitXKzJVa3ZreUpSSDh0R2FJR3dCamxhY21RRjViTE1vRE1r?= =?utf-8?B?VjBWV05HVjlkSGJUaXpvYnVyUFVsQmhNUEZ1T2c4L1RYd1ZFT1VMWjQ5V0c5?= =?utf-8?B?TklZVUJhL09NK1haUUxBMTlXc0ttSitFUDR6eDh0bmpXOTZnZ09wU3ZoWnlJ?= =?utf-8?B?Vlc3TUlscncwQzFqNnRpOU5iNk12M211bjJOUWIxdElGdlJwNzNWQ1o4OUFk?= =?utf-8?B?YXZUdUFtc2M0YjJYWTR3L0hra3lNdHg5bzBKYk1MQWhNRkJhTFZGR29ZVm5t?= =?utf-8?B?aVgwL3g5Zmk4UktPK1RMNWRFdkVvMjJWVmZvZFRWR3MwTjBqYmI2ZmMvVUdj?= =?utf-8?B?N1RWNTdvRU1BWW0vc1EvYUVBd3VKbXltenJRQ1U0dHgrQWFjd3dTajdXUEJl?= =?utf-8?B?UElOZkpyNnBkLzFmbW1iMmlnUFloZVRUaDh1V2JOSHVmUEthOFZEcmlDczZh?= =?utf-8?B?VjJvWWREU0Nkam5XUGE5UkxsTGJnVWFHTWEyWTR6Y2RXQUlYUEFjZ3dicmZr?= =?utf-8?Q?RQNthYheJWx7edbKjA/inBwYD?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: f28c3c4e-8fcf-483e-1942-08dbccf05a73 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2023 20:01:28.5654 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SrsWWKyORuFcM/ZjD8hUqzMabMQ6qFbY/A5H3X4fzAHDbW1h0DjrOM0pW/J/IDfsiRpe4yYY/oVPu3Mk29Knig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB8615 X-Spam-Status: No, score=-3038.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/13/23 18:28, Lancelot SIX wrote: > Hi Simon, > > On Tue, Oct 10, 2023 at 04:40:15PM -0400, Simon Marchi wrote: >> Change these two fields, simplifying memory management and copying. >> >> Change-Id: If2559284c515721e71e1ef56ada8b64667eebe55 >> --- >> gdb/break-catch-load.c | 2 +- >> gdb/breakpoint.c | 2 +- >> gdb/bsd-uthread.c | 8 +++---- >> gdb/mi/mi-cmd-file.c | 2 +- >> gdb/solib-aix.c | 8 +++---- >> gdb/solib-darwin.c | 5 ++--- >> gdb/solib-dsbt.c | 5 ++--- >> gdb/solib-frv.c | 6 ++---- >> gdb/solib-rocm.c | 8 ++----- >> gdb/solib-svr4.c | 25 ++++++++++------------ >> gdb/solib-target.c | 18 ++++++---------- >> gdb/solib.c | 47 +++++++++++++++++++++++------------------- >> gdb/solist.h | 4 ++-- >> 13 files changed, 63 insertions(+), 77 deletions(-) >> >> diff --git a/gdb/mi/mi-cmd-file.c b/gdb/mi/mi-cmd-file.c >> index 822d3df40005..5f63ce4494cb 100644 >> --- a/gdb/mi/mi-cmd-file.c >> +++ b/gdb/mi/mi-cmd-file.c >> @@ -167,7 +167,7 @@ mi_cmd_file_list_shared_libraries (const char *command, >> { >> if (so->so_name[0] == '\0') > > I think this should become "so->so_name.empty ()". I believe that it's functionally equivalent, but I agree, I will fix these up. Simon