* [PATCH] Add configure.nat as a dependency of config.status
@ 2018-06-04 14:35 Simon Marchi
2018-06-04 14:36 ` Pedro Alves
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2018-06-04 14:35 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
After pulling Alan's change that added aarch64-sve-linux-ptrace.o to
configure.nat, I got an undefined reference to aarch64_sve_get_vq when
doing a "make clean && make". It turns out that re-running configure
(./config.status --recheck) was needed to re-generate the Makefile with
aarch64-sve-linux-ptrace.o included in the object list. Putting
configure.nat in the dependencies of config.status would make sure that
when we modify configure.nat, the configure script is re-ran. I think
it also makes sense because configure.tgt and configure.host are also
there.
gdb/ChangeLog:
* Makefile.in (config.status): Add configure.nat as a
dependency.
---
gdb/Makefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index a0e5b7e..354a636 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -2068,7 +2068,7 @@ stamp-h: $(srcdir)/config.in config.status
CONFIG_LINKS= \
$(SHELL) config.status
-config.status: $(srcdir)/configure configure.tgt configure.host ../bfd/development.sh
+config.status: $(srcdir)/configure configure.nat configure.tgt configure.host ../bfd/development.sh
$(SHELL) config.status --recheck
ACLOCAL = aclocal
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add configure.nat as a dependency of config.status
2018-06-04 14:35 [PATCH] Add configure.nat as a dependency of config.status Simon Marchi
@ 2018-06-04 14:36 ` Pedro Alves
2018-06-04 14:41 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Pedro Alves @ 2018-06-04 14:36 UTC (permalink / raw)
To: Simon Marchi, gdb-patches
On 06/04/2018 03:35 PM, Simon Marchi wrote:
> After pulling Alan's change that added aarch64-sve-linux-ptrace.o to
> configure.nat, I got an undefined reference to aarch64_sve_get_vq when
> doing a "make clean && make". It turns out that re-running configure
> (./config.status --recheck) was needed to re-generate the Makefile with
> aarch64-sve-linux-ptrace.o included in the object list. Putting
> configure.nat in the dependencies of config.status would make sure that
> when we modify configure.nat, the configure script is re-ran. I think
> it also makes sense because configure.tgt and configure.host are also
> there.
>
> gdb/ChangeLog:
>
> * Makefile.in (config.status): Add configure.nat as a
> dependency.
Makes sense.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add configure.nat as a dependency of config.status
2018-06-04 14:36 ` Pedro Alves
@ 2018-06-04 14:41 ` Simon Marchi
0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2018-06-04 14:41 UTC (permalink / raw)
To: Pedro Alves; +Cc: Simon Marchi, gdb-patches
On 2018-06-04 10:36, Pedro Alves wrote:
> On 06/04/2018 03:35 PM, Simon Marchi wrote:
>> After pulling Alan's change that added aarch64-sve-linux-ptrace.o to
>> configure.nat, I got an undefined reference to aarch64_sve_get_vq when
>> doing a "make clean && make". It turns out that re-running configure
>> (./config.status --recheck) was needed to re-generate the Makefile
>> with
>> aarch64-sve-linux-ptrace.o included in the object list. Putting
>> configure.nat in the dependencies of config.status would make sure
>> that
>> when we modify configure.nat, the configure script is re-ran. I think
>> it also makes sense because configure.tgt and configure.host are also
>> there.
>>
>> gdb/ChangeLog:
>>
>> * Makefile.in (config.status): Add configure.nat as a
>> dependency.
>
> Makes sense.
>
> Thanks,
> Pedro Alves
Thanks, I pushed it.
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-04 14:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-04 14:35 [PATCH] Add configure.nat as a dependency of config.status Simon Marchi
2018-06-04 14:36 ` Pedro Alves
2018-06-04 14:41 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).