From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150079.outbound.protection.outlook.com [40.107.15.79]) by sourceware.org (Postfix) with ESMTPS id 6EF9E3858403 for ; Mon, 25 Jul 2022 09:48:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6EF9E3858403 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iQlP362WzhGoqaqx+R/RK0Rg6uvIHzdIE/fnm2XPm9ef8yRkA+PQTdHGjf8OsuBwUrhpFaNugEhdj2yxDGLqRn56fC3n6JRjfhDXxcHULJFkRCVA+uZ5VIW0OYQ4sz7H1OEJrGUjFwKzLFhGMuIguV7g/MDWb9WE2mPQ6cbVZe3rZWgZUhijqw8M7x5FMKiCwOmHEGvJMUMu926vkqQrMxUe8dAARzWkkiX/mGmTfmKN3P2BXD+itYixXHNUFPiTOE4+8qpktj1T2BMhQCre4fnRhFNKOZJxDeBg3Fu34wiYLrXg4VeZmFdk4vcqTLxgxg4SCYU5sxBywW7BLOULCA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IOuQ+Suo1M69JLlkFBCS8XiWod3lGMmfELrtEXlVufY=; b=fGzowYQXZoaLoXyM1hq/wq5UQgYmyZmo+5NB02Y540OH0k0iMrGy5kEt/1Da1xqDFc7Pu0cdyDppTovi2GdSFuotFxpDICKtPynXi1ntCjtoJScgVzti1oOoYtLpSCK73ZhQsBi5RvKHqFJQbLg37sx85lgZcgVhhFTyyEOlfyA8Vlx39yWx4G1NxppkiF3ZbDeKbOC/zGvDoJHsCrVdrbQx3inY3NjrQbB8xBvVLturlHakg81xjlpcwCbwTP7cFbAh3lh6BL993fEsY5kPqmsroFm4bzu+ki5hROAjO0BaQ9Eq2uoPCqOvMfvW9MHnLEpQy5jQsRoTOptbJA6GFQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS9PR06CA0261.eurprd06.prod.outlook.com (2603:10a6:20b:45f::23) by AM6PR08MB3559.eurprd08.prod.outlook.com (2603:10a6:20b:48::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Mon, 25 Jul 2022 09:48:31 +0000 Received: from AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45f:cafe::7d) by AS9PR06CA0261.outlook.office365.com (2603:10a6:20b:45f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18 via Frontend Transport; Mon, 25 Jul 2022 09:48:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT048.mail.protection.outlook.com (10.152.17.177) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Mon, 25 Jul 2022 09:48:31 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Mon, 25 Jul 2022 09:48:31 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5d2de6fd03f9ba0f X-CR-MTA-TID: 64aa7808 Received: from b255e696be1a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6AF15058-DCF7-45B0-B4D0-AB89CC46EA54.1; Mon, 25 Jul 2022 09:48:23 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b255e696be1a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 25 Jul 2022 09:48:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OVL7+VkSnJAHYr9MqmCwPZcSb5nqfCAKA7aXd0Wp0TZKgNiWBUJrgI6T2/HjNIgJU7ekHnr9FFcoKuq0HvaslJmmqDL7Hdz8G/uufD0BKStBoLYgHUgKQD+DWOPRhrHATrgehO5B82Somwkw7hPpaMJL4iASsEYLhacIEAYjYcT3uquVVLxFgVM1iPQDHClto2KH5cI0GIQIDiqrBTO6EextlUcRVZafJw7zFkL93DFos0pjQllkevXFtgXwc5Zh8NciBB9fbd3K862ry2Ok/NP/qCgaaNN71CsA0ShrAeSgVpGqRC2tM4fCE5dZTbtMSMwbU/BrTbYnPzW/ioKaOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IOuQ+Suo1M69JLlkFBCS8XiWod3lGMmfELrtEXlVufY=; b=g6qPNTyaT2iILu7hYE39uZngnYlPxo+xi0sgkqg7QGqb2ICDhWFJKIy91K+CGGdPSz3pVlY1YrXQ+QtnqIdFS4/kIspvovfujoVQvnBhINtP33Y+A3Kr6CcM5Dfet1lkHgn2a00rpgdijmTZRQA+GGxHiIayXkb7C1M+Faunl9LfWbI6pojmDuoNqrymPNaYxCGsyysaY9Z2hA1LIqMcZeBnqaUdjGM40PjARHPFSXoprFko+A4kxpGjFJFuuTeaDy4661/jFIcykQJkqXfl/zYN2ogeUCpReeLf3GAlilOr991K8hTE1kNPrOpQ6dhh6/C92n0yvPsoQN1F07itfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM6PR08MB3990.eurprd08.prod.outlook.com (2603:10a6:20b:a3::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.20; Mon, 25 Jul 2022 09:48:21 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e866:af0e:2168:5ca7]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e866:af0e:2168:5ca7%5]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 09:48:21 +0000 Message-ID: <0bf338f1-17a6-848b-3761-dc34a8c487f6@arm.com> Date: Mon, 25 Jul 2022 10:48:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 1/2] gdb/arm: Use if-else if instead of switch Content-Language: en-US To: =?UTF-8?Q?Torbj=c3=b6rn_SVENSSON?= , gdb-patches@sourceware.org References: <1dde8763-9da8-1590-ac3f-06f0555bc14a@arm.com> <20220722205930.2461429-2-torbjorn.svensson@foss.st.com> From: Luis Machado In-Reply-To: <20220722205930.2461429-2-torbjorn.svensson@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0435.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::8) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: dfe0fcef-0316-447f-168a-08da6e22d565 X-MS-TrafficTypeDiagnostic: AM6PR08MB3990:EE_|AM5EUR03FT048:EE_|AM6PR08MB3559:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3l+BX+af9IM5neMAbo8znqxBMMm3SSe7pGdv8hwMqqYnVsPZVWG46gW/4Ud8oYjtUK0r1Ho7Vm+SqQXGoZp8exVCuwkSfOQvO9ajZupUMeCkKc1OxG9Mq0y+F4zpUTikXLhtpF8ngVV73bp8jj3wtmJiuU2whcKp2QdOHDkmHz9XekduXJAi+LFodoyeRMmkxSaMoaN8q4AGs6Wdk/xrhM7vNZDyVEz4IqFnSXNdYyKfOe6Trw6U2HsQB2PjyKV5VgDMDooKH/qRK3sUj6cxZ5JOomu8WXhm9qiTN0mPxeGsHc7ou26gg/ytnogQz4uDDR4gJndd/sxJ7gG7USZY5SNVGFwiKEQ/wEDFgnsBvGZYwfiZpnZMABNsCgGERdAFqX7Neko6ndTzw2MxCyxDz1O3QIXALIVDNL6ufLasvdtiN6zQcVqv22ozd/0fozgBDi9UJFzhE6amjEJOtAZeXuTX2m5yXrC0dE1XA4CKZ7WNjaqZNkshy0IY/LeP23odXJiKpsIBMZeWAbpttEkRom9pTpKcH6UBs++JtcKlqIORWEnXQk9shymgJGa364iKRUTv0G9Dr6eedo7Vq7HMbwTyZ8HDI/4b5R4BttIzn3H3BDtcY9cwZAzJp1SQmC0dAiDjjWqnZ2e1grbosOYmQxM5Sx8RRgXklcUzV3eDdD5N1WvNSAJvTbui1YnzO2K6v2dSJPeFqzxYqBRZKxGUxCsOE+pJUdCsEK4F537q1JUoWMxOVRkj4/OiyPEVaGlLd6THMByApUH6EnBEdwcQcXJcug4vWJDyvidhnYWyEJmrK3QiGJQucaYLQk8MSEbeV5S8i/dAxtz6wP55i4z/DA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(5660300002)(8936002)(31686004)(36756003)(44832011)(38100700002)(66574015)(186003)(2906002)(8676002)(66476007)(316002)(41300700001)(66946007)(6486002)(66556008)(83380400001)(53546011)(2616005)(6506007)(6512007)(478600001)(26005)(86362001)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3990 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3b0aee3f-840b-40b8-c40a-08da6e22cf35 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AhWSbbdOpArDtSezgLhgJ5FQVJ7O5tyZq2Tuh9+7U6Qyk9iLIq5qOJwZnyV7zTc3nz/0DgUJPoMCgpGAtOlHfqrj8JkB20uCh4J4ODov2P9QUCvBxNhauMGScmjuUQi5P/W7sUH/xq/YPuTiKxzxFR0rit7C/s1g/Oe5urMqr/VONvw39weEtdY7C3YpweLEBCuz52RAN7Z6q+k66uZ8Y+KEcCLOg2V7inekuX7QZJ6XG7cOjLc5TVvcQaWRh+UX6sOkqknr2k1qqnMCjhc8Z4i3FrKsiTHZ9EscjNQ4o5zFL0ylGrwFxkcyjoTedh9eLn8a3Vkxz9uprGQ8AXyEC9kUx2lvaodvPCiOUe6OyIcV6vXZPK0tEUUb1MmTVtnJgsMr5HWCTynNi/q/fzZ3YCCx6RH/B8reeDehFNQNwSVmRqtcHgDrDkUJ1Boks6rgPvqZSvH9uzNYojRk62SVVZqFhukVQA6Mb6O9ldyQiRQFN9njLZCpac+3XzwaZHe0aeRmm92PPLjNTaNxeQF2xkrzuzpJmh8bF/rH1Mg7r0i3gdIszdZckCykxMP+mgrM1t2J8JSQrOMB8STbaOEBR9rhgrEhNyfgx3CkypqN8fqvtB1niBtPkhLsJWijNoS9/3DV2FaT0wzc6Cnh1TyViqhDz/KS8U2jN14V/qtlhUcCHObXXgpUk5RC3g7+K+RtjmI8rsOZ2xbxponfk8IgfY5z6nr46bZ2PuLxwg+IwZqfDouRLIcFjPNBRH8YQaxvmvF34yclDyIVvxI4rl1Mupw1SXQ21cC+VuuPtwHI3Cl7YWRf3fOtRzbmFH2tOZex0Vc8d8hCt/ldCaUoDATamA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(376002)(39860400002)(346002)(396003)(136003)(46966006)(36840700001)(40470700004)(47076005)(8936002)(70206006)(53546011)(31686004)(66574015)(70586007)(356005)(8676002)(26005)(6512007)(82310400005)(83380400001)(36756003)(336012)(186003)(6486002)(40480700001)(40460700003)(2616005)(41300700001)(6506007)(44832011)(5660300002)(31696002)(2906002)(478600001)(82740400003)(316002)(86362001)(36860700001)(81166007)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 09:48:31.3836 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dfe0fcef-0316-447f-168a-08da6e22d565 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3559 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 09:48:38 -0000 Hi, On 7/22/22 21:59, Torbjörn SVENSSON via Gdb-patches wrote: > As the register number for the alternative Arm SP register are not "As the register numbers for the alternative Arm SP registers..." > contstant, it's not possible to use switch statement to define the contstant -> constant > rules. In order to not have a mix, replace the few existing > switch-statement with regular if-else if statments. switch-statement -> switch statements statments -> statements > This patch is a preparation for the next one in the series. > > Signed-off-by: Torbjörn SVENSSON > --- > gdb/arm-tdep.c | 25 ++++++++++--------------- > 1 file changed, 10 insertions(+), 15 deletions(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index d3b4fce98a3..7d0944f9e3f 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -3785,9 +3785,8 @@ arm_dwarf2_prev_register (struct frame_info *this_frame, void **this_cache, > CORE_ADDR lr; > ULONGEST cpsr; > > - switch (regnum) > + if (regnum == ARM_PC_REGNUM) > { > - case ARM_PC_REGNUM: > /* The PC is normally copied from the return column, which > describes saves of LR. However, that version may have an > extra bit set to indicate Thumb state. The bit is not > @@ -3807,18 +3806,18 @@ arm_dwarf2_prev_register (struct frame_info *this_frame, void **this_cache, > lr = frame_unwind_register_unsigned (this_frame, ARM_LR_REGNUM); > return frame_unwind_got_constant (this_frame, regnum, > arm_addr_bits_remove (gdbarch, lr)); > - > - case ARM_PS_REGNUM: > + } > + else if (regnum == ARM_PS_REGNUM) > + { > /* Reconstruct the T bit; see arm_prologue_prev_register for details. */ > cpsr = get_frame_register_unsigned (this_frame, regnum); > lr = frame_unwind_register_unsigned (this_frame, ARM_LR_REGNUM); > cpsr = reconstruct_t_bit (gdbarch, lr, cpsr); > return frame_unwind_got_constant (this_frame, regnum, cpsr); > - > - default: > - internal_error (__FILE__, __LINE__, > - _("Unexpected register %d"), regnum); > } > + > + internal_error (__FILE__, __LINE__, > + _("Unexpected register %d"), regnum); > } > > /* Implement the stack_frame_destroyed_p gdbarch method. */ > @@ -4944,17 +4943,13 @@ arm_dwarf2_frame_init_reg (struct gdbarch *gdbarch, int regnum, > return; > } > > - switch (regnum) > + if (regnum == ARM_PC_REGNUM || regnum == ARM_PS_REGNUM) > { > - case ARM_PC_REGNUM: > - case ARM_PS_REGNUM: > reg->how = DWARF2_FRAME_REG_FN; > reg->loc.fn = arm_dwarf2_prev_register; > - break; > - case ARM_SP_REGNUM: > - reg->how = DWARF2_FRAME_REG_CFA; > - break; > } > + else if (regnum == ARM_SP_REGNUM) > + reg->how = DWARF2_FRAME_REG_CFA; > } > > /* Given BUF, which is OLD_LEN bytes ending at ENDADDR, expand LGTM with the above fixes.