From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140058.outbound.protection.outlook.com [40.107.14.58]) by sourceware.org (Postfix) with ESMTPS id A0A2C388883E for ; Tue, 29 Mar 2022 08:13:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A0A2C388883E Received: from AM6PR10CA0025.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::38) by AM9PR08MB6689.eurprd08.prod.outlook.com (2603:10a6:20b:30f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.21; Tue, 29 Mar 2022 08:13:25 +0000 Received: from AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::ea) by AM6PR10CA0025.outlook.office365.com (2603:10a6:209:89::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.18 via Frontend Transport; Tue, 29 Mar 2022 08:13:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT011.mail.protection.outlook.com (10.152.16.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.18 via Frontend Transport; Tue, 29 Mar 2022 08:13:23 +0000 Received: ("Tessian outbound 826a6d8e58c3:v113"); Tue, 29 Mar 2022 08:13:23 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4c6ad580509130c8 X-CR-MTA-TID: 64aa7808 Received: from 9b76ff6fc691.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EFF77B08-828C-4C09-B578-4D409468468C.1; Tue, 29 Mar 2022 08:13:07 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9b76ff6fc691.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 29 Mar 2022 08:13:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cwHQQDkUuH0drmQLJA0wRsWBYIiiWiQSIXpYnIZa7sUNgIKisLoKtXDV9I5k0nh/XwJFFyIDV+bB7+98icv6UW5rW+jqVRog79dn+kp0KsDEfZLa+9WLjYMLS2dbzjBj3f1j5cA486cvNgOowPChQyRd0FIPtXAAwCWijcGHSvYFLhBlBYKSHlQ0wNoJ9UXkuyixF8J9YSXYK08GTPAuHpP/okwlE1Yw+lRUmIb6WQ+OZDgEyjjaujmqPMEvIszsxdiHKz4bQgrubRQshqFdUT2acbgsPdA/PEheioOf9ZhvknnuP0ntpGcnlxfFKh8OVZ5u1yZIdeIm9OVM2RX8ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NKDjaGz9zBYOi0hP5ucOjGXo5i3PTnjQAJfa43rZSs0=; b=dBlkeQ6LMe7lBGLZf7d6ualJzMt45KhR3K6FjhoT67K79Sg81WNnMYgUQx9jAw82T2LLX6Lv+g7TJwOiScIcuNjeafVkgC35oWYu6EjKE1+Cqi7WZPBiduG3gHzjDaYVEmz24Yo63aEismjZT6RdGgVoDNOKSRmYpc9VBW+gmwxxvDChNwBCUX463wb2vvinZfRJBWQFhNIoaIFUh7ahwCIjS8pSKc2lc3wteXOu8geGtkHmASpiD7PDxEleR9w4ZR6shnvF3DUctOrZX9Ov6qZkAoHBPdiJ70F+Icgp5LXxZPuqS3pU5fK/YQNUZYOSxLdkj3LXrTAumQXYRQHBmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by VE1PR08MB5743.eurprd08.prod.outlook.com (2603:10a6:800:1b2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.17; Tue, 29 Mar 2022 08:13:05 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::905f:29ee:d858:516e]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::905f:29ee:d858:516e%7]) with mapi id 15.20.5102.023; Tue, 29 Mar 2022 08:13:04 +0000 Message-ID: <0c2acc0f-a6aa-d063-5d9c-0c129954d811@arm.com> Date: Tue, 29 Mar 2022 09:13:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 2/3] Implement real literal extension for Ada Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20220301170055.1520935-1-tromey@adacore.com> <20220301170055.1520935-3-tromey@adacore.com> <77f98638-ec8f-5d79-8a00-d91db1253644@arm.com> <877d8ri1af.fsf@tromey.com> <429bc573-999a-86d7-cf70-bb685c7f457d@arm.com> From: Luis Machado In-Reply-To: <429bc573-999a-86d7-cf70-bb685c7f457d@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0052.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::21) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: ca692477-29d9-4d73-9e43-08da115bfe82 X-MS-TrafficTypeDiagnostic: VE1PR08MB5743:EE_|AM5EUR03FT011:EE_|AM9PR08MB6689:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3lxfvw7dR8uBFtvwDxrwi0IWOh363WajZ7GapRIoFruo6a8TUrmTs1SR6NHiUzeCVvQ+M2JGx3kYNMSmOPHeGZWeqx6pcPSCNUaz35EAbUwE720VhwW+Mm+NssoIG22J47n/rNbsoFX9lYQi11MCj/DSVcYIoMJ6M19KVumg2Mu3CTSBiAS1lI2SA7+JxbNrwRWsO5Cp+p3EW7H9HNb68cPaj7jX+Fzpg2xfV8YuXiMNwOaxSlq7PfYKqomNCd3RmGOwbHQIrKVlTvpK4chVpjxNttwTD4gwu0enmPPKPvit2NWopTIAVH+fB22zXvOpo/h3uvNRKqHt7lTw/nvU+zq3TT8WUDKgNGtqU3lRRLt/RSOnN7S/UxT3uMnETCapCwMA4UiyiFkb/7RQEZW97iVaYtUQclUzfaxqfAq8tYvrYV1xw4WWWoYtXiY9fFWJsnnSR4pMJunPosHnMRwpeoG6BT0dirWlV4BCx9+ypsaFufdF7wXY7i5PyT3rPVS8YU0MfHFfAluWCj1WwlafC/LImWSwY63lDeVOPlQM6oNuk/ri5eCp3kttNMz2shpmAafpVAZfaRopFCxp/ZAu9PeLhIAffg+n+iMd37zI6tcKzHFSmA2xWDOAE1U1HYBP60ZurW8KHaSNKum05CNWZPJUjPMon6dWckLlxcQkBAF1oDaZ0n3ZOMUcQCaPWhpLNRM0rd335rsbWep9ZAB15cId1/BtdBhvKbZQRBI3L/LB5E3wJ47MQdDEAJnmjbvoSSo3G1EdLvLLjI5pS8CpcM9cJMgVZBcA7Bnd/koWpQ20ttyQB34DJiQUofsjkevn X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(31686004)(36756003)(8936002)(6916009)(5660300002)(2906002)(6486002)(38100700002)(66556008)(8676002)(66946007)(4326008)(66476007)(316002)(44832011)(6512007)(2616005)(53546011)(508600001)(86362001)(6666004)(6506007)(84970400001)(83380400001)(186003)(26005)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5743 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 855b5a08-ddaf-4036-2f93-08da115bf2bb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XmUpecLfnVVuQ8qM82pn+dRW4v0FLLY81dhc8mLbh2JpEE93xlZIgcVcafvHuOCLBxynCjuQCo8Mbov42/gCbyxats1mPx+TO3zblpqhaLbRLONX3KJFTMmgCUQ0yBk81y855E9m0j94EZphIhESQ+BOOsdKCeLdoOX33u7Poqdbb7gUglR53FajDdF13/rCyb5oYrLgiiMZ03QqmvpV/3ucdxmyeu4NL7zbN9AiI2C0v2UY84mLdCNZPyaLJPZgOpSpDWzOf89Q8p2QWoEw7mGy4K1Kexswh3GWwE414ueEUH+iVQn0C03qLvhpAlP9F9FL2kZMTJsY26cCLwz9HzrQqMMBKwuy4hfwbOl0l6mma4oxI+L2/Icj1Z8RWP23Dj782v7CsAyPsGCimh8IW1UpJmoNPkFo75HPvUSgR4JOqTjINjsZgp5TMa/BMPxRxATGrf2fPkikDgZKRMfHyoUEewakWwMHJxsqi3qGD4Ak3hOauK31AAO+N7Hi3SuX9UVOfNSpgXNHB1e5UmXHeCwIr2xJS84BYJs+tOFKxAhXLuT1MEQ1mx0bSKEmVuYxZgpF1eCwSJzsgq0zJNe7aNBOuSHDamsJFh5EppGY7ksCniC3sD0EAgmZxajqWRr3D0W++N/Pzto4xip6upJ3t95Y9O6wUc9Ltp5EBy1B2kloDJQde0NoPC6ueAg1pMDF8v6YOzbImmPTo0l5IzEVrERMPwvGR6pxN31whizdUKXwX3QAvWev8WQ4ognuNSGSrhlx/YuP31aIOKQUU2E8/a2u3ozNPxordXho/ksgf5Q= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(26005)(336012)(31686004)(5660300002)(6666004)(356005)(36756003)(6512007)(6486002)(40460700003)(316002)(2616005)(83380400001)(186003)(53546011)(2906002)(86362001)(36860700001)(8936002)(31696002)(81166007)(6506007)(6862004)(47076005)(82310400004)(508600001)(70206006)(70586007)(84970400001)(44832011)(4326008)(8676002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2022 08:13:23.5234 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca692477-29d9-4d73-9e43-08da115bfe82 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6689 X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2022 08:13:30 -0000 Hi, On 3/21/22 09:28, Luis Machado via Gdb-patches wrote: > Hi Tom, > > On 3/18/22 18:05, Tom Tromey wrote: >>>>>>> "Luis" == Luis Machado writes: >> >> Luis> I think the floating point representations may differ between >> Luis> architectures/bit-sizes. >> >> Luis> I noticed 5 failures in this test for aarch64-linux and arm-linux. >> >> This is interesting, because internally we have a rewrite of this same >> test, and it seems fine on aarch64-linux. >> >> Luis> FAIL: gdb.ada/float-bits.exp: print >> 16llf#7FFFF7FF4054A56FA5B99019A5C8# >> Luis> FAIL: gdb.ada/float-bits.exp: print val_long_double >> Luis> FAIL: gdb.ada/float-bits.exp: print val_long_double := >> Luis> 16llf#7FFFF7FF4054A56FA5B99019A5C8# >> Luis> FAIL: gdb.ada/float-bits.exp: print val_long_double after >> assignment >> Luis> FAIL: gdb.ada/float-bits.exp: print >> >> Luis> Some of the expected values don't really match. If the output is >> Luis> supposed to differ, maybe we should compare hex values instead? >> >> I'm curious what is show by 'print/x' of the various values in there. > > Here's what I see on my end: > > (gdb) p/x 16llf#7FFFF7FF4054A56FA5B99019A5C8# > $9 = 0x7ffff7ff4054a56fa5b99019a5c8 > > (gdb) p/x val_long_double > $10 = 0x4544adf4b7320335 > > (gdb) p/x val_long_double := 16llf#7FFFF7FF4054A56FA5B99019A5C8# > $11 = 0x0 > > (gdb) p/x val_long_double > $12 = 0x0 > > (gdb) p/x 16llf#a56fa5b99019a5c800007ffff7ff4054# > $13 = 0xa56fa5b99019a5c800007ffff7ff4054 > > (gdb) ptype val_long_double > type = <8-byte float> > > (gdb) ptype 16llf#a56fa5b99019a5c800007ffff7ff4054# > type = <16-byte float> > >> >> Luis> Also, for 32-bit targets, I'm seeing size-related issues. >> >> We're also doing testing on ARM and that seems fine. >> > > Interesting. I wonder what's different in my environment then. This is > standard Ubuntu 20.04 on aarch64 hardware. > > I usually build --enable-targets=all, but in this case I tried a single > target and it did not change things. > >> I did disable some of these internally for some targets, ones with >> "weird" floating point. >> >> Anyway, it seems like we could change the test to verify that the size >> of each floating point type is what's expected before proceeding.  But >> I'd like to understand the above a bit better, first. > > Please let me know if you'd like the full log and/or some more information. Did you have a chance to check things on your end?