From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by sourceware.org (Postfix) with ESMTPS id 15DF73849ACF for ; Fri, 19 Apr 2024 19:52:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 15DF73849ACF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=mail.api.win Authentication-Results: sourceware.org; spf=none smtp.mailfrom=api.win ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 15DF73849ACF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.208.180 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713556370; cv=none; b=qO3dmxJEAh8TOEEnj6hjudsBbrE4rucpTmDTztcJlcF47odrbqmXrmlxrNi4L2NIFHMWlHkVjdPZ9YXjRj88ZWBkI39eztBlt0CNfq4BF9/F0WUcWSH4fPTpgyCnLth1xE/exj/9m/iOwvAeViZrc076Vd8CIKnFR/L3m0xCu34= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713556370; c=relaxed/simple; bh=rDxlV7iiXh+EO8DVLimDIA5fbMNYCZARnudvm9+LQJ0=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=aGEZYWRpVjpP9/JEwRiALBHZqIG9eYxVEk6kPU2DMASl1JX7zgW/adY8WLfk5lthkXzsOIQrYq67VBnhoXSULpgxYADfABENCOFU/P97EkWmRHhzxv6QF2ub4663glwx6GW6XtePIt9nIHKeRUl9jaxdGx5qVFe3Rq34byYO+dA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2db101c11feso16771721fa.0 for ; Fri, 19 Apr 2024 12:52:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713556368; x=1714161168; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZOCmzXRzh25k/XEinbqVlw7QHrXp72qN+EKDh8cnYGw=; b=IlgUOB7RwRIY9f0a/r4I8OCm1R2oLvC7mOz4K4I10qN+xW43W0z4BTKUL6APd0swxw URJsImCgQupFjdadJOMIz6a/LsFmJFWxMlJpHhE4apn6M1CQLaTBH6HNAZSQRD9grXgL cUaAqxHc+tajGcJROQHR3a4Kjn0Ug/JR91+yxE2tIS3ibzUvxdw5sO9IMvjsva4gqfa5 rotxtrLeswCRVBgl5OgW6GMOSW239EL7dulNOhx/dehAFgj01vWavOjci1ux/9ROBCLG Om8qPNpopyGqF31wx1AwV/v1gRp7xvfThzIUv/2CptZ8b4h23XQETQnBvnxaHM+9eTuY iyMg== X-Gm-Message-State: AOJu0Yzk35D7hJc6AL0HM4m5eUTfJLGBR8piJ5SxNJ1dew0gkMQmZxfB mlFvI5bMMPi8odFqljglAV85NIHEvlMMQMhZDbDQYL17fOtZ3Dus5akPGQ+AQ+jRtnuVL5fknOS 3X20= X-Google-Smtp-Source: AGHT+IG1l4t78/aRmO1nayx1ZuHh4dJOy9GRo1SxtQg9zJj5fPd29qq55/CQzWpt3BKy/Zhv3A5gDw== X-Received: by 2002:a2e:880e:0:b0:2d8:611c:228a with SMTP id x14-20020a2e880e000000b002d8611c228amr1858082ljh.8.1713556367735; Fri, 19 Apr 2024 12:52:47 -0700 (PDT) Received: from ?IPV6:2a03:1ac0:b0d6:4d64:dd47:7cfb:6fbe:6998? ([2a03:1ac0:b0d6:4d64:dd47:7cfb:6fbe:6998]) by smtp.gmail.com with ESMTPSA id s17-20020a2eb8d1000000b002db20f1d549sm726578ljp.0.2024.04.19.12.52.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Apr 2024 12:52:47 -0700 (PDT) Message-ID: <0c39e31d-bcfe-4c07-887b-19262c3f6afb@mail.api.win> Date: Fri, 19 Apr 2024 22:52:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] Add an option with a color type. To: Tom Tromey Cc: gdb-patches@sourceware.org References: <83edv74u1v.fsf@gnu.org> <20221016162809.32801-1-gdb@mail.api.win> <877cgtup03.fsf@tromey.com> Content-Language: en-US From: Andrei Pikas In-Reply-To: <877cgtup03.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi. In PATCH v6 I have fixed all problems mentioned in all previous versions. But after that it became stale and no one reviewed it. What is a copyright assignment and how can I give it to you? I allow anyone to use my code from this patch without any restrictions and I will be glad if it gets be merged. On 19/04/2024 22:33, Tom Tromey wrote: >>>>>> "Andrei" == Andrei Pikas writes: > Hi. > > Andrei> Colors can be specified as "none" for terminal's default color, as a name of > Andrei> one of the eight standard colors of ISO/IEC 6429 "black", "red", "green", etc., > Andrei> as an RGB hexadecimal tripplet #RRGGBB for 24-bit TrueColor, or as an > Andrei> integer from 0 to 255. Integers 0 to 7 are the synonyms for the standard > Andrei> colors. Integers 8-15 are used for the so-called bright colors from the > Andrei> aixterm extended 16-color palette. Integers 16-255 are the indexes into xterm > Andrei> extended 256-color palette (usually 6x6x6 cube plus gray ramp). In > Andrei> general, 256-color palette is terminal dependent and sometimes can be > Andrei> changed with OSC 4 sequences, e.g. "\033]4;1;rgb:00/FF/00\033\\". > > Andrei> It is the responsibility of the user to verify that the terminal supports > Andrei> the specified colors. > > Whatever happened with this patch? > > IIRC I didn't review it, since I thought someone else was handling it, > and then it never went in... anyway I was recently thinking about RGB > support for styles, and I remembered it. > > Do you have a copyright assignment? > If so I can review it and we can try again to get it in. > > thanks, > Tom