From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42458 invoked by alias); 4 Sep 2018 11:39:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42422 invoked by uid 89); 4 Sep 2018 11:39:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=H*M:1e1e, Something X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Sep 2018 11:39:30 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 321FE402315A; Tue, 4 Sep 2018 11:39:29 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 89364A9EF5; Tue, 4 Sep 2018 11:39:26 +0000 (UTC) Subject: Re: [PATCH] Fix batch exit status test failure on Fedora 28 To: Gary Benson , gdb-patches@sourceware.org References: <1535991124-28668-1-git-send-email-gbenson@redhat.com> Cc: Sergio Durigan Junior , Tom Tromey From: Pedro Alves Message-ID: <0c814c97-fb8c-f2ff-1e1e-02d8fcebd509@redhat.com> Date: Tue, 04 Sep 2018 11:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535991124-28668-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00051.txt.bz2 On 09/03/2018 05:12 PM, Gary Benson wrote: > Pedro Alves wrote: >> Yeah, if we compare with gdb.base/quit.exp, that is missing >> as well as the "remote_close host" call. For the latter, when I last >> touched quit.exp, I remember fretting a bit about whether the remote_close >> was really necessary, but in the end decided to keep it, I don't recall >> exactly if I kept it because I found it's necessary (probably for >> remote hosts), or because it doesn't hurt. >> >> Now that I look at gdb.base/quit.exp again, I see that >> gdb.base/batch-exit-status.exp can hang forever in the same way that >> 15763a09d4ae fixed, isn't it? Gary, any reason you didn't do the >> "eof" thing here too? > > I didn't realize what it did; I thought it was something specific to > that test. And I thought the gdb_exit at the start of the test would > clear $gdb_spawn_id but apparently not! :) So I made a fix, basically > copied and pasted from the commit you referenced: > > This commit changes the batch exit status test to detect GDB's exit > using gdb_test_multiple expecting 'eof', instead of using 'wait'. > This fixes failures reported by buildbot on Fedora 28, and also means Please expand here what the failure was, for the logs. Something concise mentioning gdb_spawn_id, doesn't have to be long. It just should be more self contained so that someone reading back the logs later on understands what it was. > the testcase won't hang forever on failure as fixed in > gdb.base/quit.exp by commit 15763a09d4aea85fc3153d6746c040dd48565637. Please write the commit in Linux-commit-style: commit 15763a09d4ae ("Fix 'gdb.base/quit.exp hangs forever' if the test fails"). to help the human reading the logs. > Is this ok to commit? OK. Thanks, Pedro Alves