From: Simon Marchi <simark@simark.ca>
To: Saagar Jha <saagar@saagarjha.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add a missing munmap_list move constructor
Date: Thu, 24 Sep 2020 11:27:01 -0400 [thread overview]
Message-ID: <0c94705e-d735-7b9d-d730-72df4988de33@simark.ca> (raw)
In-Reply-To: <58351270-2804-4A48-ABA5-2589312C06B6@saagarjha.com>
On 2020-09-24 1:22 a.m., Saagar Jha wrote:
> Clang warns if the default implementation of a function is requested but it is implicitly deleted. This was happening to compile_module because it didn’t have a move constructor for its munmap_list member, so I went ahead and added one since it already had a move assignment operator defined for it and this seemed like an oversight.
>
When fixing a compilation failure, please always include a paste of the
error in the commit message. But the change itself looks good to me.
If you are compiling with clang I presume you also see this error in
macroexp.c?
/home/simark/src/binutils-gdb/gdb/macroexp.c:125:3: error: definition of implicit copy constructor for 'macro_buffer' is deprecated because it has a user-declared destructor [-Werror,-Wdeprecated-copy-dtor]
~macro_buffer ()
^
I've tried to look into it in the past but I didn't manage to fix it.
The ownership model in there is a big bowl of spaghetti.
Simon
next prev parent reply other threads:[~2020-09-24 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 5:22 Saagar Jha
2020-09-24 15:27 ` Simon Marchi [this message]
2020-09-25 6:59 ` Saagar Jha
2020-09-25 7:05 ` Saagar Jha
2020-09-25 7:05 ` Saagar Jha
2020-09-25 14:58 ` Simon Marchi
2020-09-26 0:25 ` Saagar Jha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c94705e-d735-7b9d-d730-72df4988de33@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=saagar@saagarjha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).