Re: [python][patch] Python rbreak

[Simon Marchi <simon.marchi@ericsson.com>]

On 2017-11-03 05:46 AM, Phil Muldoon wrote:
>>>> I can't find a reference, but I think we want test names to start
>>>> with a lower case letter and not end with a dot.  I'll see if we
>>>> can add this to the testcase cookbook wiki page.
>>>
>>> As I mentioned on IRC, I've not heard of it but will happily change
>>> the names to comply.
> 
> Sorry this took a bit longer to get back out than I would have liked.
> Modified patch follows. I believe I have incorporated yours, Eli's and
> Kevin's comments.  ChangeLogs remain the same (other than the new NEWS
> entry which I have added locally.)

Hi Phil,

Sorry for the wait, I had missed the update.  The patch looks good to me,
with just a nit below.

> +	  if (obj_name == NULL)
> +	    return NULL;
> +
> +	  /* Is the object file still valid?  */
> +	  if (obj_name == Py_None)
> +	    continue;
> +
> +	  gdb::unique_xmalloc_ptr<char> filename =
> +	    python_string_to_target_string (obj_name.get ());
> +
> +	  if (filename == NULL)
> +	    return NULL;
> +
> +	  /* Make sure there is a definite place to store the value of
> +	     s before it is released.  */

"of s" -> "of filename" ?

Simon