From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130967 invoked by alias); 14 Nov 2017 20:23:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130949 invoked by uid 89); 14 Nov 2017 20:23:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD autolearn=no version=3.3.2 spammy=Hx-languages-length:1155, HTo:U*pmuldoon, H*M:e621 X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Nov 2017 20:23:40 +0000 Received: from ESESSHC016.ericsson.se (Unknown_Domain [153.88.183.66]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id BF.21.19528.9C05B0A5; Tue, 14 Nov 2017 21:23:37 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.66) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 14 Nov 2017 21:22:37 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.60.14] (192.75.88.130) by AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.239.4; Tue, 14 Nov 2017 20:22:35 +0000 Subject: Re: [python][patch] Python rbreak To: Phil Muldoon , Simon Marchi CC: References: <5e1ba7e3-5f6e-2478-30a5-7670ec7a9879@redhat.com> <3193f5c7a0c98c548722bb6c143f347e@polymtl.ca> <8ee8a4c0-4580-474f-a5aa-6f76a8d22960@redhat.com> From: Simon Marchi Message-ID: <0cac20bb-f383-f83a-e621-99f425f225d6@ericsson.com> Date: Tue, 14 Nov 2017 20:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <8ee8a4c0-4580-474f-a5aa-6f76a8d22960@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM5PR21CA0049.namprd21.prod.outlook.com (2603:10b6:3:129::11) To AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6efcec1a-ab0d-47c2-225d-08d52b9d7209 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258);SRVR:AMSPR07MB312; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;3:1MQ0fYmYMB2yrQvxHPtKnIgwdL+jIy6rqpHuwnkmEZpGJglLTLCE666iC+mRM3CR66aiuOdUEYPWfz1ZXERVlpko36gGsOTJH83yOvUvv953CspUUSB6t1alT0eAr875nrU+XsMYyd9IglZ/Wu4wuW1McdyUEw4kwf/s7X+16dTtOy5OcHCR+qFjTrNMGlzmt3qE9iIL6Mf9pe3avDLVy71cAKIzk/x2jkjY+oA5R8WkUgPu6UQgb5c99qpEcgJH;25:P9ZoCp9ioWGin31hoWAGTwT8W/swCRkUhpeIvZCQiBHuYn/xqMAG4ck+JT2OpCT7m5omO+veZ/v9Hcecn7W+dnyFVCldNkON/pOTULFwi0hyMXKoS5/ZCxMg7p9ZwRe9HSwfO6Gc7XSS9zYZkHMYfx//RZ43Iby0TqvXTuzfDnp7N262d/26NnBb0LsqdTRAPYKd6LInVrGQxYH0ehbHAqybJJrxK4+9Uvwu0aBFj2nlV6QLAcHSskjXOC+8kWfSrGkgBXen0/yCLz0KwZI+UR64Vasrm+7rgppDUa/JtHbKQGADYKFVkskR0t8sdmUPx7G/1wQeSvclywVpb5Sw26b7KpzB0K3bNRhiL+RhY6k=;31:evsGGPQ3Vgaz1l9vkE/ExqHAc0fxLBeOwZdpLVhw14uhO8A+HS2kB6V9XRbk72o6ftIszKgwUOnFznAXr9ecCQRy2dE3tDcQWzo6vXx4LOFqVfjenId5LQnj0/quQyG+j6munBtxwJx2zbkGSwZMrpFH+PlrG7KcUBJzrm+AwkuAOXShyUCoLmWUBh9eIsjx/piPTDewhGi9HpotF3hyjRimfhutpW3fhs5C4pZ85mA= X-MS-TrafficTypeDiagnostic: AMSPR07MB312: X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;20:kNHldf3ChlWX9yvaWZ3JDle3QQuuXbkKKl+RLaeHY1kBLgTdz0Bhp2JQ+8HGnZZA4Nb3wU/1Zh8GpURShn8AfvvHVz025JKYNIycEn3qmNXEknVAOwCarWdLAqeo/PbFAMLEsE62rw/jswEAY9yqVLEhsFQ1qJonjmxKxLjiZhCrBMT+lPj/Dd5QPPcCxwzsHkvqLg1vctXs3PfUbi2Jc4uO1wQZmlRFUkVTmIcLwtZ0TpBibGU8AlnWMXBwrTlzZS74LU5lEMHW7cZnMyN/nInYE7xFXJiG35PRVAf7hMOEpwkPFU+o9re6IQ4UYrFm2K4UoBiiRZD1oVwDoItD7gicXlB5n3MrbOA5zE83HFJvVwHd8HSkt1FocCBY8KT6DGn173dDjB/iKe+iLMwxBhpmqO06Q/tC4ASJyx9D4YslKt2pD72YtGaNIQtX9rmQ8InXlaKfXBy0tfzPUSEzAtSuXuKoFFVnXm+k1a91qDH7+yUDzDn+D7xydWynTY2N;4:dcJ5fG6kyAsopp0KRAFBxNfitiRXfOIse4wueuXZ60e7qizD0Yn/DfxnHjw3cxaY/AQpcsc+tQY14cCdGLv5n+Jvbgh6pxcZTTcctUFRN0OqLc+9fxTZpLknaGeOwQXIw2Jal2DmFri9JFHhamG9CtzYG4PcErVdL1yrvz+3kfDj9QVqnAjnT6BHKYvIw3B5nUXDdC7HPsl6jbQvf1VptxNWGnN8MGfd9KvNTE6BS5PsVtlhGzNtVEmWgEez3SbtiQUqm/En2mMTk62vYbvUzg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231022)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AMSPR07MB312;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AMSPR07MB312; X-Forefront-PRVS: 04916EA04C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(39860400002)(346002)(24454002)(189002)(377424004)(54534003)(199003)(110136005)(478600001)(31686004)(25786009)(2906002)(101416001)(23676003)(66066001)(16576012)(49976008)(316002)(93886005)(4326008)(65956001)(6246003)(53546010)(65806001)(36756003)(58126008)(83506002)(64126003)(47776003)(7736002)(86362001)(305945005)(2950100002)(53936002)(230700001)(65826007)(5660300001)(6116002)(3846002)(189998001)(6666003)(97736004)(50986999)(6486002)(54356999)(50466002)(76176999)(33646002)(229853002)(31696002)(106356001)(105586002)(8676002)(8936002)(68736007)(81156014)(81166006)(16526018)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB312;H:[142.133.60.14];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTI7MjM6bzdNUWRLQmt1dG1wVGtrUWx0UU42OEpSWWNq?= =?utf-8?B?bXlJL3dmSG1SM3F4MXkyLzlwSnh3NzdjTkFmRnVublFrVkJtN29RNHZNM1Rh?= =?utf-8?B?T3UraGpLcVB2WlRmOUZIc094Z2laZ1MzcVk4RGFZYmF5Q3dXUnJOemVhWGtX?= =?utf-8?B?UWsxY1FxYVhSM3lldTFvTjBRWWNyTUkvSDkyaFJ3cWlmQXg0ZVk0NGtSYXp6?= =?utf-8?B?YitHVWRyeDFiSTNCM2RqZ1hBVzZlSkxJOXhZOUM3OWVjckdlOFk4UkYzdW5y?= =?utf-8?B?SXJuSGNUWTczcXBQUXZWZzJNdGx5d0Nybm9QWHlyTzVIdVBJa3Q5SjN1Tndu?= =?utf-8?B?UllTUDdBcDUwaFIrUXdUTW9mbjNUYk5jZndWTHRTaUNtZ282dUhxazlDcUFM?= =?utf-8?B?WkoydjlZNG5rRFhtV1BwRjlwYm5QLzZ6Vlc0aUNabUc1SUk3SmwwUk93dktH?= =?utf-8?B?MzEydkJHUTFqUEEzUklIUU1aZXZVc3N3WWUzYjVQRHY4cEJvVENQOXl4QVZQ?= =?utf-8?B?R1FIbktmUzZwR0ZybWFnMk8rdk90Mnl1eWZnU3lWWXN6TVFBbElqWUI3UmI0?= =?utf-8?B?Q3A1K2J4a0hhVjBXWTVneXFtNzN4WFJya05KTWFFSU9hVUM1eDFKaFR0M2ZG?= =?utf-8?B?ZkZvVjZmQWVkWU16cHkwK3VNZjh3SllSSlNhalRpbkx6YzRqdDFnM1dSMEpV?= =?utf-8?B?WG13SWdNZWJzOWI5bHBlZVRRVFdqWXprbEI4cU84aDZXS2V2OG9nRHgyNFBG?= =?utf-8?B?OTJ2UnV6MjhVbUhjY2NLb0NEOW5BdHBOZGRWVnZCMzhmZEQ2TElWQ290dGJE?= =?utf-8?B?bUtBZFUwOVc1b2NqSHN5ZzI1bWpJVW8vYlhVYlg5UkFnU2FEUmw5c21Jbkl5?= =?utf-8?B?cmYrNnBwTmxjUjJGZ3BHc3M1SDMyODByb2QzMlpHN0FkQXFyL1gyYXFQRStz?= =?utf-8?B?K2RDaXFmWTdmdzhPOEt5Q2hSdnh0bUlRNFZaUXhscGhJbkJDWkxHekJCOW14?= =?utf-8?B?Y0U3M0h0SXdxaFlTdmFuZFQwalFNZUdITE5jM21hR2RwL2REazJEM21IR3hO?= =?utf-8?B?dThjVERheWdPRUc4VDE3K1B3RjlRdXFhVzdOOGRneDVEa1VLUWwzOWE1S2Ni?= =?utf-8?B?c3lZdHBxRTVqZU5idVp5RjNqeEtHUFcrSC95ZUNQNE10cFlwSU02RVQ0RVBy?= =?utf-8?B?c1c4ZU40M0hBdVVTOERmeGp5bnhwUnVNa1ArODF0b2Z0OFpGRGpEeTRRRDNF?= =?utf-8?B?d1kzWVNQellnTm9Ja1R1clN0Y1Nja1g4aFUxd2VPODU3Q3N3YVhkVThuS2RH?= =?utf-8?B?a25yT3pIeVpKa2NZMjhYM3VVeGtrR2hTZFRsNklnaThQNG94RitzSS9kWndO?= =?utf-8?B?eUFzN1puaFlGaWQwUUcvVlhLaWR6Ny9ramhKVmFXSkNkQ002VkdmbWdUVllk?= =?utf-8?B?bmhnaVRNQUhFMWwyTTQra2NUa0hDUkorNzRvTkt5MWgxK2VqdDNkRkN0TnlP?= =?utf-8?B?cEZSTjZSY1AxNmdqUjBRTXg2SjVkcG9sN0xOei9yek0vRTJGMzdNMm9Ec0dF?= =?utf-8?B?SzZKckxQWkxnbkZoNld5UEJ6WDdFU3hESTZXOFA3U3k3OUFSSm4yMndQcnA0?= =?utf-8?B?NmRnbGprT3FtTWpOSThjYW1oVGR2VXNseE1GN3JaazFRd3d4MlZOVkRPYjFr?= =?utf-8?B?TjB6SzZxb3JQQWVhWE56akZZU2lHaUVIOG9sY0NuOHFPZ3M2ZWVadlUxSlgw?= =?utf-8?B?eUxFMklKeiswRXEvNW9oc3czWTBXSFhXYlF2czdGNEhYeXgvN1prQTZTRU5E?= =?utf-8?B?c2JjalQwNmNzL044ZTVpME1iZzFWeTRmVnQvNmgzY0JKL2duQ1R5ZmJ3RlJU?= =?utf-8?B?eUNENjBSRkx6V1lmTDFLUmEzSTV4VmIxazZtRkNPbHZtRlRnSXNYM3FleDNy?= =?utf-8?B?RUgxS1RyUlE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;6:YqaxjgDONQP1Aq5q4zXCtDZ+GYBDFFg3atjISaAYHKPKSZfZVKWCVgkmYBxGVwgcCrZYZTp9HraZYKnV7IJJtOrJrXTmTTkd3YxPoKjtt4f1tFd1vf6gnay+2e4x+AXesFBXBh9dJxQalLnifO2Zuwx0hGqD2czC84cK1UrPd3mHfsdC19oZt0ELNNyCgRj6eMg4mDYkTY8/vkmyMGoDk5OaecC/bc84J/p5czOzB8HQ1aoJbNO4NQczK8fYHM5wl+squqcqzkYE1cSdXmIASFG9xc/Zc3Me+JWnVlzeZxGXsXiomYymi/ZoEz9dV16BQIzL82wM0je/ZqazKapHBLnWq8ItyRZkfIunb1WqQIA=;5:ACa8DFvcIvzAItEsijm9x3TIDuawfckPrGN2cCmJ5EG1s5tQpmPRIev0GHvx3YgJMbQNYmW28RI7dS5dXHMu251PYsIoarz9mWCBshm94TLjhndSKcPRXiTHcSp9NhZOdMegg4VtZ4dQMjAagwx+O273zYC7+90LbqFO18AvOx4=;24:1Rjz9y/4OYvSudl9FvhMCbEtf0ZN9+9otlPl9EK3r2xXgZTdNCJDIboS6bV4pBC3nFf7Nxye4s8TDPUCyDznQqFNmzx5UwIbuCQGiaU9ICY=;7:AEd+bGrCWKfiiJtTPsSmRkKa1PINGWzRHbHjzh/R35O0r1QroNg7ctwCQx8Myul2TmoOqpqOhGhlTU9tumgryt1GuVmBiYiPa5Rq29B5dUjj+gGDmBTYYVlmq36FHyLTYHtwgYWRo4FU/nniz6gxJ6eF+9HKVzShyifDoEDr8d1iZQbBq8y/d4nsOn9CZg9nfTGrXW6ZXGV59SnWrK3X3pyQiWGPn9Okv40VR/4GAICVBOUM/EzXi2HV+ipGZusC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2017 20:22:35.8354 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6efcec1a-ab0d-47c2-225d-08d52b9d7209 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB312 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00256.txt.bz2 On 2017-11-03 05:46 AM, Phil Muldoon wrote: >>>> I can't find a reference, but I think we want test names to start >>>> with a lower case letter and not end with a dot. I'll see if we >>>> can add this to the testcase cookbook wiki page. >>> >>> As I mentioned on IRC, I've not heard of it but will happily change >>> the names to comply. > > Sorry this took a bit longer to get back out than I would have liked. > Modified patch follows. I believe I have incorporated yours, Eli's and > Kevin's comments. ChangeLogs remain the same (other than the new NEWS > entry which I have added locally.) Hi Phil, Sorry for the wait, I had missed the update. The patch looks good to me, with just a nit below. > + if (obj_name == NULL) > + return NULL; > + > + /* Is the object file still valid? */ > + if (obj_name == Py_None) > + continue; > + > + gdb::unique_xmalloc_ptr filename = > + python_string_to_target_string (obj_name.get ()); > + > + if (filename == NULL) > + return NULL; > + > + /* Make sure there is a definite place to store the value of > + s before it is released. */ "of s" -> "of filename" ? Simon