From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by sourceware.org (Postfix) with ESMTPS id 87A0E3858D39 for ; Thu, 3 Mar 2022 14:59:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 87A0E3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f44.google.com with SMTP id t11so8275497wrm.5 for ; Thu, 03 Mar 2022 06:59:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=9TMdpw8urZykFI8HF4ZJYh4y8Kp161BRVOf3aUorK5g=; b=tI7G93B4FWtHgr3QNLjUBnfcoQAYD+wNSKzaN4HbK5X+cIfljGTpVLixHalxenAJ5Y O0NJ/FkNs52zIbGYNG33UBdHMg/N2NAgs6ohFiSBsZk3h8phx8g6l/NFOB0vJ2x+WY40 outuJnCgmrBcjtPLA3L/0fdjYNiZHYip8auUXD0+X2ZFXjLvaqBX7xZpZfM5CdscvdBC wFbnzWhX1EsrVcPA6K57pPWP4eNelGRXGd65Rz/fKjV/feg8CQOGw6wOTQKKYM739htg 2k9y763/IF1RcQo3uxU8rotQo8nn6kDpIfNZ8xvyJvllWsYY/T/RbhhJ+25B2oO8NfiM l9oQ== X-Gm-Message-State: AOAM532yYfB5EFZv8r4GY+aLfvbbs11qWyUyLKm0gb9AK62MrFhK9ti6 Sx4ygvYJ5Z2Dei0lXiND09FEDdGTiyw= X-Google-Smtp-Source: ABdhPJz8V7NAorHkAYSBv97SfvZmjzaOJNC8lnhBdaxp4PlgfKcswssjJe/QDeMaiC/vnrzkwUUOCA== X-Received: by 2002:a5d:4533:0:b0:1ef:b46d:1367 with SMTP id j19-20020a5d4533000000b001efb46d1367mr16210236wra.508.1646319561579; Thu, 03 Mar 2022 06:59:21 -0800 (PST) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id u14-20020adfed4e000000b001e3323611e5sm2146580wro.26.2022.03.03.06.59.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 06:59:20 -0800 (PST) Message-ID: <0cb0fc14-c266-824f-dee6-57df1a004bd8@palves.net> Date: Thu, 3 Mar 2022 14:59:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCHv2 0/2] Fixing regression in mi -add-inferior command Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: From: Pedro Alves In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2022 14:59:23 -0000 On 2022-03-02 11:57, Andrew Burgess via Gdb-patches wrote: > Hi Muhammad, > > Thanks for working on this. I've taken your patch and incorporated it > into the two patch series below, the first patch is still credited to > you, but has some changes: > > - During testing I noticed that with your patch, after -add-inferior, > the new inferior has become the selected inferior. I believe this > was not the case before the original mutli-target patch, and isn't > the case for the CLI command, so I fixed this, and extended the > testing to cover this case. > > - I've moved the comment for switch_to_inferior_and_push_target into > the .h file, and updated the .c file to match inline with the GDB > style. > > - I tightened some of the pattern matching in the test case, for > example, parsing the 'info inferiors' output to create an expected > pattern for the connection name of the new inferior. > > - I tweaked the commit message to directly reference the commit that > introduced the regression, I think this helps for anyone in the > future trying to track down the history of a particular change. > > Then I added a second commit that adds the --no-connection option for > the -add-inferior command. I felt that it was important that these > two changes go in as a single series as, after the first commit, we > effectively loose the ability to create a new inferior with no > connection. > > I'd welcome your feedback on both patches. I think we just need to > wait for a doc review on patch #2, then we can probably get this > merged. > Other than a small remark on the NEWS entry, this LGTM. Thanks for addressing this.