From: Simon Marchi <simon.marchi@ericsson.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/3] S390: Enable re-attaching with native-extended-gdbserver
Date: Wed, 21 Mar 2018 19:39:00 -0000 [thread overview]
Message-ID: <0cb5f3b9-8b13-6e98-2bb4-5b1024e923a6@ericsson.com> (raw)
In-Reply-To: <1521473488-27210-2-git-send-email-arnez@linux.vnet.ibm.com>
I am just looking through this to have an idea of what's happening
and found one nit:
> +/* Determine the word size for the given PID, in bytes. */
> +
> +#ifdef __s390x__
> +static int
> +s390_get_wordsize (int pid)
> +{
> + errno = 0;
> + PTRACE_XFER_TYPE pswm = ptrace (PTRACE_PEEKUSER, pid,
> + (PTRACE_TYPE_ARG3) 0,
> + (PTRACE_TYPE_ARG4) 0);
> + if (errno != 0) {
> + warning (_("Couldn't determine word size, assuming 64-bit.\n"));
> + return 8;
> + }
GNU-style curly braces.
Simon
next prev parent reply other threads:[~2018-03-21 19:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 15:31 [PATCH 0/3] S390: Some gdbserver fixes Andreas Arnez
2018-03-19 15:32 ` [PATCH 1/3] S390: Enable re-attaching with native-extended-gdbserver Andreas Arnez
2018-03-21 19:39 ` Simon Marchi [this message]
2018-03-22 9:07 ` Andreas Arnez
2018-03-19 15:33 ` [PATCH 2/3] S390: gdbserver: Don't write guarded storage registers Andreas Arnez
2018-03-19 15:33 ` [PATCH 3/3] S390: Make IPA recognize tdescs with guarded storage Andreas Arnez
2018-03-21 16:43 ` [PATCH 0/3] S390: Some gdbserver fixes Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cb5f3b9-8b13-6e98-2bb4-5b1024e923a6@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).