From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 00/14] TUI refactoring round N
Date: Tue, 20 Aug 2019 15:19:00 -0000 [thread overview]
Message-ID: <0cbc2e1c-4a8f-44d5-9639-eedf8c0fcd3a@redhat.com> (raw)
In-Reply-To: <20190818172735.17477-1-tom@tromey.com>
On 8/18/19 6:27 PM, Tom Tromey wrote:
> Here's yet another series of TUI refactorings. This series should
> have no user-visible changes. There are several more series like this
> to come, but as before, they are interspersed with user-visible
> patches which I plan to submit separately.
>
> Each patch was built and tested using gdb.tui on x86-64 Fedora 28.
Other than the comment to patch #5, this all looks good to me.
Thanks,
Pedro Alves
prev parent reply other threads:[~2019-08-20 15:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 17:27 Tom Tromey
2019-08-18 17:27 ` [PATCH 05/14] Change tui_data_item_window::content to be a unique_xmalloc_ptr Tom Tromey
2019-08-20 15:19 ` Pedro Alves
2019-08-20 22:34 ` Tom Tromey
2019-08-18 17:27 ` [PATCH 07/14] Change tui_check_register_values to be a method Tom Tromey
2019-08-18 17:27 ` [PATCH 02/14] Remove NULL check from tui_reg_command Tom Tromey
2019-08-18 17:27 ` [PATCH 06/14] Rearrange tui-regs.c some more Tom Tromey
2019-08-18 17:27 ` [PATCH 10/14] Remove tui_data_window::display_regs Tom Tromey
2019-08-18 17:27 ` [PATCH 12/14] Move some defines to tui-stack.c Tom Tromey
2019-08-18 17:27 ` [PATCH 09/14] Remove indirection from tui_data_window::regs_content Tom Tromey
2019-08-18 17:27 ` [PATCH 04/14] Remove tui_data_item_window::value Tom Tromey
2019-08-18 17:27 ` [PATCH 03/14] Minor rearrangement in tui-regs.c Tom Tromey
2019-08-18 17:27 ` [PATCH 08/14] Add two methods to tui_data_window Tom Tromey
2019-08-18 17:27 ` [PATCH 14/14] Change some tui_data_window methods to be private Tom Tromey
2019-08-18 17:27 ` [PATCH 11/14] Change tui_make_window to be a method Tom Tromey
2019-08-18 17:27 ` [PATCH 13/14] Remove some defines from tui-data.h Tom Tromey
2019-08-18 17:27 ` [PATCH 01/14] Some i18n fixes for the TUI Tom Tromey
2019-08-20 15:19 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cbc2e1c-4a8f-44d5-9639-eedf8c0fcd3a@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).