From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58853 invoked by alias); 18 Oct 2017 13:39:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58823 invoked by uid 89); 18 Oct 2017 13:39:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*M:9558 X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Oct 2017 13:39:31 +0000 Received: from ESESSHC015.ericsson.se (Unknown_Domain [153.88.183.63]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 63.76.26775.09957E95; Wed, 18 Oct 2017 15:39:28 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.63) with Microsoft SMTP Server (TLS) id 14.3.352.0; Wed, 18 Oct 2017 15:39:19 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [10.0.0.110] (192.222.251.162) by DBXPR07MB317.eurprd07.prod.outlook.com (2a01:111:e400:941d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.2; Wed, 18 Oct 2017 13:39:18 +0000 Subject: Re: [PATCH 1/2] In cp_print_value_fields() obey dont_print_statmem=1 explicitly passed from cp_print_static_field() To: Patrick Frants , References: <20171018131729.23137-1-osscontribute@gmail.com> From: Simon Marchi Message-ID: <0d0edd05-2367-b966-9558-8e08175f8e4e@ericsson.com> Date: Wed, 18 Oct 2017 13:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171018131729.23137-1-osscontribute@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR10CA0012.namprd10.prod.outlook.com (2603:10b6:405:1::22) To DBXPR07MB317.eurprd07.prod.outlook.com (2a01:111:e400:941d::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb5f0f14-2852-4c05-8066-08d5162da1cf X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DBXPR07MB317; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB317;3:hjVzISc/NjXMN+K7N9BVrgaVvRe+GDyChn+UwysqELvWZ9Zmdqr7LhmmFf6DZa1fPCB+h9fy1dT6nzatL458KSIC755yrBjabDymz7FOc9uswLtQGdIbb5VWpPy27Bbsc/RjeV/f9qzB5DiLmlneACuUi5SIbeh/RTF5SMGizi6joKQtERVONkJm3AXN2tjGdo8C9NE7LldUPKgv9iOXZ7poG/ketf18zIg4M6m/yL8R9JpEaPQE9LP/FTpysgwl;25:N0XSUrVreoIylffCdLsqIDioGDCpIHQA6jpXXzRqWyHY533HiOE+xnasM948TLoULPaNc/6XgmxNKNscgE/4/B0CmzDzXDBKuSWSLcNeg4S4FwUVzBmYfQrH53QypRktKcwE9ezrX6dw6tTMFIX+tbo2KV5+iHYVQ8B1jR4n4hlEn1TO8khYkkJjivp3GCBsqBW58TSVvG+WMwTcr7R+rqGOATgv0A3BNoatXTa5nTPQyQzicm/kISRwnMfLG6lP32OL4QHgsoxz2bgJ350dFgMBza8R4ckLWijkLSxS6C4A5i63VUI7NxLWhCufmGun1Qtykf2TplGH9FLZQjhDPA==;31:y8LJmmWbx+RKwxKybyYGvAnszutJCmLluln1p7xXuxCzf9xd/vyhqk69rNDcMxPgY2u8kDM5ZenHymDXPTTez/eMleGpLnb7d7N+jMlRFQViFQw/UyDoIdniYWB1XXVBzmcp3BT5I7uKyLaN1t9vtIwwOqlOH6KBpN2VIBW1Jg/vegGufqFJuxt9mk2zK78np4NC8E8SfFLVEUWhvVVsbiZjK4BP7wXbay8lhmGuHOo= X-MS-TrafficTypeDiagnostic: DBXPR07MB317: X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB317;20:Tfus7hfU7B1zQJkUfxok2bBY1fAPh0WHt25WZwZOy1QnVSBEpPkR1z4tUyjstWYmhqxlndtqBe7JT6J4tXIfPTj4+alqToeiFJOxNMgerDVfXHZi3IY+yUtQPQ1EpflIMSH2kWONAoL8huCNcbWln5OI7y+Noxy8222zo3xr/nhRh9uMjFk4D/8nwICdLZ9wi5M9uYVVguSv5HDrH89dkVnG2G4DvNszEa8tLg49gFpiZgwBGeiv2hZ/7F+zV958MpLSx3IIJoBI75Prc0RnAYNmZbW3xLWyWjx4UBUyGCLu3wiPOetT5OqQ7+PF/TtFE+MarWEPtbSRRtD/vJJjNoyR4833BqhCSgji5I081l7LekaoiZxBbZaHLPoojMadja7QGA13dAQCu7SaTHcb51eQe57SGJReInaP9xHj/CrwyndRVvPyT0PxWEIYAc/k3S/u8YvuwToppagxgSBvVs/Q+Tbj2Ak150Qv/6zgQsI+t3G6cardng6v8CPUrxxW;4:XDaTRRq2jzRRksBqPCaGTLXtya2zHTWyMAAFICiyBB7uYNG7BrAXPHKtQGJnEWeE05cX67kQKnpi9AnF3SdLz4o5NxDTzi9Dyfx0fbQls5j2LTZ01kyBlSbPQJruV8p/iV6Et7Ax1k/wNiWxhlBzgXLfuVtfve47X+6t+sp8p4jY1LfNvscc3QHO7Mh48pCnK7LLbtMTXGMBnYsvDoRiSxATGNcCozIVSCghz+qkRCFAVERlqMNGOmjeLW2NVKzR X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DBXPR07MB317;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DBXPR07MB317; X-Forefront-PRVS: 0464DBBBC4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(39860400002)(346002)(199003)(377454003)(377424004)(189002)(24454002)(189998001)(5660300001)(16526018)(25786009)(478600001)(230700001)(65956001)(966005)(65806001)(97736004)(66066001)(47776003)(36756003)(6306002)(6246003)(39060400002)(2950100002)(23676002)(3846002)(31686004)(6116002)(53936002)(53546010)(68736007)(65826007)(2906002)(7736002)(58126008)(50466002)(305945005)(86362001)(4001150100001)(31696002)(229853002)(106356001)(64126003)(105586002)(316002)(33646002)(83506001)(77096006)(16576012)(6486002)(81156014)(81166006)(50986999)(76176999)(8676002)(8936002)(6666003)(54356999)(101416001);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB317;H:[10.0.0.110];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQlhQUjA3TUIzMTc7MjM6ODBwRWg5ampYa3QzeFlVOXU0UGxQZ1o2b0lQ?= =?utf-8?B?YWFzR2JJQ0V3WFFHTXZZamkwQzdrRUVkTitwR3ZLNm1WcHFTb0hwakdDQkRH?= =?utf-8?B?ckp0U016Rlk2Q1p0OXFNTFM4SVkyRGVCUEdXNlVVOGxLNENoTXgza2tmTFY2?= =?utf-8?B?Z2NsMGpFYVlaNVZFM1k3UlQ3UStzKytycXQ3OVhaZzd6VVVBR2ZNVmJaMXNT?= =?utf-8?B?NVpESEMrbjEyVm9oYmI5YWxGditPT0FWbm4wRDVFOHRkSDFQU2x1cjN3YXdB?= =?utf-8?B?cWRkRnkzWW1KbUVRL24xaWJOdE1VbUd5QXJWdlI2bUR5M2thWEtUQXhhWFNR?= =?utf-8?B?QXZDZnNTZC9aQkk0U09zejRpTXZXa2R0UWt3WncyZG1TeE9GWnNQK2VHc3A0?= =?utf-8?B?NGV3MjIzaHVkTVMrdXpiVTdxSTdQVlJZeFpmZUNCZmpqdXorTXFLbkVmS1Mr?= =?utf-8?B?YUdnKzhyRGZaZDBoUkRsek44V09FRXRQRXZDT2RqLzZYc3lCc204V3c3d1ZV?= =?utf-8?B?LzRaQVM3TEFCRmc3N1FaMWpaZU1iVmZwUjBUSXpYWldacEJ4bllabkp0V2Jv?= =?utf-8?B?Rk5HTm5oMjh4MHBtWVZndWs1dkw5bTNVNzVRa2dDS09raUhJVmVmaEVPUWhz?= =?utf-8?B?Nm5iSU9MQmxOZ2QyNWZ6ZFZzMEV2Tk9neHZrN1VYMnRHbU8xM1ZEaFBUOHF2?= =?utf-8?B?bkFqcnd6Ny9wNkJIUVlYcHBVZTEyclA4UndUQk12dTREUUJhcWtubWJVdk1q?= =?utf-8?B?cHk2TWFyWjcwSHhnYzd6ekw5M25UWGZkdUVyZlYrdEdtZExlSTk4STVid0Rn?= =?utf-8?B?OUtzNDFGb3RKa1h2MWkxYmlWcEZDYjliMi9JZDNBelJtdnY3dkJSNVBhNGRF?= =?utf-8?B?NGN2UWlrQjQwRDdGckY2cDF4K0dVeDNSTUxkTEV3VUwzMFNOUW1jWG1sM0RP?= =?utf-8?B?cSs0SGkvWmcvUTQrRjUwK2hqc09NN1hQQ3dTamJxcGMydjdNNDFSNFVpdU1l?= =?utf-8?B?K3krOGtobUdnYUE0eTFEREFjVFlkVmRMYlRuQzZUeTVWdWpEQUpLYWVCaXhu?= =?utf-8?B?WDdkWjNXY2hFaFIyQThnMGdpZmx4QXE3MzJDbEozcXhicnRHbmhDZlNMTFJ1?= =?utf-8?B?L0VtZnAyL0pFVlNTQnBuVFczejVnU24reEQwWml1emtmdnVkako5Y0ZJZkJx?= =?utf-8?B?VFlJQTdmU0VTU0VKdkx1aGJOMmdYZlFheUJyZ3p5RTB3MEl4ejFLT0RZSnRF?= =?utf-8?B?WmNYV3dBTEQrZU1mWUh4NWVUcHVWbGdYYVJqc2w2R1Nzd0FWVS8vR1ZVSm9N?= =?utf-8?B?eHZXVTZyZjQvbExFVUtHOHdCVnZBVS96SWhhKzJQNnY2WVlFdHhLamhGcVZE?= =?utf-8?B?SGtra0RVOWJxWEhlT1ZqaW9uTXdOWWN1b3ZRNktGckRzNENWVmY0RnVTYjd1?= =?utf-8?B?c000RUhTcGx5clAwOUFJeU91U0hvOFB2b0tJQ3ByTTJVa1ltUGU2VXpDUzFK?= =?utf-8?B?VGdPSWFFa1NTSG8wQ3ZKUHN0SHlTd2dMQ2VDVmMvd0dpSS9lTUljZDBJaC9G?= =?utf-8?B?bThXcE9RSkM1cFNnZWFhNW9kTjVwYW5DVEZaYlRUemppQ3ZFK3hqKzlHY1R1?= =?utf-8?B?T0ovUHNVUlJEbi8yWlFiUjNFVmxUK3dGVjJRSzM5ZXVVRm9IQWUxemFDTWMv?= =?utf-8?B?TFFXaWxxenl6VWVVTXVrUFJQditmUVlzYmtlRW5VQmdEZ1NLVk02a2RMTXZR?= =?utf-8?B?REtCWS9IQWxpMW1tdFgrZ1RJcVk4RWoxUCttSEhzaTdjRlYrMXF5SW1ZWWEw?= =?utf-8?B?VHA5ekRwbkVKcllUT3E4T01Bc1JxelBVa3ExckNFNnZ3VUtjYm9wakZKTUJJ?= =?utf-8?B?MTVLS05ieUlPSWVodlFEQzNET2c1WGNXTEREQVF4ZWFBT0pyZE16My8ya2Er?= =?utf-8?Q?Xk2swW84vRbdVpqMzPVviuFqnK7hg=3D?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB317;6:4zCJwOhr2O6rWltCKVcNp2iGdUlsgM9xtXD8bV8tdBhPG9vxxbZedQ19yJfnOjzsHDjO88lvNyEN2TZTsW5DOrZ/ykBMXK/hosmK1EkuKzJ4WzB9yQKcUHYzAs/Z2qMul1kwVzt7sdZA3AOhBnl83tXWOtmK5OB11RKaj6lbwZlDgDbc4CLmWlbstKR9opRpG1rtpSVkCU8XSc+h5eikEibbddkMTOyonVanBmpeIIrvndhYUiO9tLDEUn9gc7EaSIt7qOHvwd9D9twCal4Y++3IK+J2LXHW3MdSdpl6y60xs80ET2XlrOoztwbqme+mKfPRi3Q6UOoYGVVGqbkC2Q==;5:Pd0x3lOHWBQWJ3yHxZruYMT5yOIPUtNMOCMzmRESBmvnW88361wlyVzL2ZR36Q8grbrgj+BgI0wgVfzSOzeDzy13q+6KfoEJ2GfjilziS1boFrPkc9miwZTjk647J41IpbZz+BKDI4goXmV7PSxtGg7vAQcbe870TBcy62TbAzQ=;24:14Xa9y+AdglfRVKH6OQYV7F2NIsrG9zMB7tVSqvr9ecuSXFUGkJGsHolDPxvsgU3ATpPJb0BFh3Y1lpIm0/Wd+jmE0owRbtfxZhyaKxM6x0=;7:qAhsE+KBIO8BAc/OYb54l29OciHIxUww973pxHv077PqcnS3TMI7wM1+4QgcRgI6iU8ObSK2mmLO6Fyu1BhHx8mCh110OFleWOEtIRT/j2WmLzp9dvxbJ6dQDnYGT8K/i9kkgtUPUaE4DcS/q8ABJmBu3keI8GvVpHykzN2qEVqhn1VhHUgoUVi2Y59zDjRFVWKryEfZCYYUePK8mkyO3pot3CRRWtjZA3ihndrDOV0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2017 13:39:18.0925 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bb5f0f14-2852-4c05-8066-08d5162da1cf X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB317 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00567.txt.bz2 On 2017-10-18 09:17 AM, Patrick Frants wrote: > This fixes Bug gdb/13669 (https://sourceware.org/bugzilla/show_bug.cgi?id=13669) > > cp_print_value_fields() in cp-valprint.c optionally skips static members based on options->static_field_print. Additionally cp_print_value_fields() has a parameter dont_print_statmem, which instructs the current invocation to skip static members. The "if () continue" statement (line 236) fails to take into account this parameter and therefore gdb gets into an infinite recursion involving cp_print_value_fields() and cp_print_static_field(). Hi Patrick, Thanks for taking the time to provide a patch and test case, it's really appreciated. I haven't looked at the patch in details, as I would need more time to get familiar with that code, but I ran the gdb.cp tests and noticed two failures in gdb.cp/classes.exp: -PASS: gdb.cp/classes.exp: print csi with static members -PASS: gdb.cp/classes.exp: print cnsi with static members +FAIL: gdb.cp/classes.exp: print csi with static members +FAIL: gdb.cp/classes.exp: print cnsi with static members The problem seems to be with the message "same as static member..." not appearing. Before: 2377 print csi^M 2378 $39 = {x = 10, y = 20, static null = {x = 0, y = 0, static null = }}^M 2379 (gdb) PASS: gdb.cp/classes.exp: print csi with static members After: 2377 print csi^M 2378 $39 = {x = 10, y = 20, static null = {x = 0, y = 0}}^M 2379 (gdb) FAIL: gdb.cp/classes.exp: print csi with static members You can try running the C++-specific tests by running this in the gdb/ dir: make check TESTS="gdb.cp/*.exp" The test result summary is in testsuite/gdb.sum. However, some tests are already broken. So what you should do is compare the gdb.sum of two test runs, without and with your patch applied (don't forget to rebuild gdb in between). To analyze failures, look in testsuite/gdb.log. More tips on running the testsuite here: https://sourceware.org/gdb/wiki/TestingGDB Simon