From: Lancelot SIX <Lancelot.Six@amd.com>
To: Simon Marchi <simark@simark.ca>,
gdb-patches@sourceware.org, simon.marchi@efficios.com
Cc: lsix@lancelotsix.com
Subject: Re: [PATCH 1/1] gdb: Update doc of the "maintenance info line-table"
Date: Wed, 22 Mar 2023 16:48:30 +0000 [thread overview]
Message-ID: <0d437971-3a9b-d5fb-2cd0-3ad27ca03177@amd.com> (raw)
In-Reply-To: <3a38867b-e481-c4be-95db-0058afbaf2b3@simark.ca>
Hi,
>>
>> This patch updates the documentation to reflect the new command output.
>
> Thanks, I didn't think that a maintenance command would have so much
> details in the doc.
The textual description might be unnecessary for a maint command but
does not hurt either. At least, the example output should match what
GDB produces.
>> +The @samp{UNREL-ADDRESS} column gives the unrelocated address of the
>> +instruction as read from the debug information. The @samp{REL-ADDRESS} column
>> +gives the corresponding address in the process memory (relocated address). If
>
> process -> inferior, to be generic?
Done locally.
>
> You could also say "in the current inferior's memory" to be more
> precise, as the relocated address is given based on the current
> inferior.
>
>> +no process is started when executing this command, the relocated address is the
>
> And therefore here, "If the current inferior is not running when
> executing the command...".
>
>> +same as the unrelocated address.
>
> The two addresses can also be the same if the executable doesn't require
> relocation. But your formulation doesn't imply that you are describing
> all cases where addresses are equal, so perhaps we can leave that detail
> out.
I'll add a "or if the executable does not require relocation". But I
could also remove the phrase discussing when relocated == unrelocated.
This part of the manual documents the maint function, not relocations.
>
> Simon
I'll send a V2 soon.
Lancelot.
next prev parent reply other threads:[~2023-03-22 16:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 16:30 [PATCH] gdb: make "maintenance info line-table" show relocated addresses again Simon Marchi
2023-03-20 21:35 ` Andrew Burgess
2023-03-21 1:18 ` Simon Marchi
2023-03-21 9:23 ` Andrew Burgess
2023-03-22 1:35 ` Simon Marchi
2023-03-22 10:26 ` [PATCH 0/1] gdb: Update doc of the "maintenance info line-table" Lancelot SIX
2023-03-22 10:26 ` [PATCH 1/1] " Lancelot SIX
2023-03-22 13:59 ` Simon Marchi
2023-03-22 16:48 ` Lancelot SIX [this message]
2023-03-22 17:20 ` [PATCH v2] " Lancelot SIX
2023-03-22 14:58 ` [PATCH 1/1] " Eli Zaretskii
2023-03-22 13:46 ` [PATCH] gdb: make "maintenance info line-table" show relocated addresses again Tom de Vries
2023-03-22 13:47 ` Simon Marchi
2023-03-22 15:17 ` [PATCH] gdb/testsuite: adjust test cases to previous "maintenance info line-table" change Simon Marchi
2023-03-22 18:01 ` Tom de Vries
2023-03-22 19:14 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d437971-3a9b-d5fb-2cd0-3ad27ca03177@amd.com \
--to=lancelot.six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=simark@simark.ca \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).