From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id C52703858403 for ; Fri, 14 Jan 2022 20:09:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C52703858403 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 995951EA69; Fri, 14 Jan 2022 15:09:22 -0500 (EST) Subject: Re: [PATCH] gdb.dlang/demangle.exp: update expected output for _D8demangle4testFnZv To: gdb-patches@sourceware.org, Iain Buclaw References: <20220113161016.2248240-1-simon.marchi@efficios.com> <1642189246.zkqt3t5c83.astroid@pulse.none> From: Simon Marchi Message-ID: <0d45af80-cf28-eba1-a17b-20eba63092bc@simark.ca> Date: Fri, 14 Jan 2022 15:09:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <1642189246.zkqt3t5c83.astroid@pulse.none> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 20:09:25 -0000 On 2022-01-14 2:45 p.m., Iain Buclaw via Gdb-patches wrote: > Excerpts from Simon Marchi's message of Januar 13, 2022 5:10 pm: >> Since commit ce2d3708bc8b ("Synchronize binutils libiberty sources with >> gcc version."), I see this failure: >> >> demangle _D8demangle4testFnZv^M >> demangle.test(typeof(null))^M >> (gdb) FAIL: gdb.dlang/demangle.exp: _D8demangle4testFnZv >> >> The commit imported the commit 0e32a5aa8bc9 ("libiberty: Add support for >> D `typeof(*null)' types") from the gcc repository. That commit includes >> an update to libiberty/testsuite/d-demangle-expected, which updates a >> test for the exact same mangled name: >> >> _D8demangle4testFnZv >> -demangle.test(none) >> +demangle.test(typeof(null)) >> >> I don't know anything about D, but give that the change was made by Iain >> Buclaw, the D language maintainer, I trust him on that. >> >> Fix our test by updating the expected output in the same way. >> >> Note: it's not really useful to have all these D demangling tests in the >> GDB testsuite, since there are demangling tests in libiberty. We should >> consider removing them, but we first need to make sure that everything >> that is covered in gdb/testsuite/gdb.dlang/demangle.exp is also covered >> in libiberty/testsuite/d-demangle-expected. >> > > Hi Simon, > > To memory, both gdb and libiberty D demangle tests started out as being > identical, but libiberty has been adding more to it as it's been > improved/updated to support the latest language features. I see no > issues with removing it if it's becoming problematic to maintain both. > > Iain. > Ok, thanks for the info. It doesn't seem to break too often, so I am not in a hurry to remove them, but we'll keep that in mind for the future. I pushed the patch in the mean time. Thanks! Simon