From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 8B91E3858D1E for ; Tue, 2 May 2023 13:39:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B91E3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C12B821B4B for ; Tue, 2 May 2023 13:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683034797; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bneSG3C6IhTxqmwxZ4nzn8c86/gPbOPgj0CY6DWf86I=; b=PK3EZc30SJcU7PTQ2jTyMjp0BNZdy/lXuYgUtqDv8UKNO++NV0ZQ/DkE/0JHL8HN4KOuKV l/2AtVl51KjUx9DQVyNKFJDxdbGURHXu7jld/YAvEqjYNaJrlY5cjpg/bV4GTBOWWcHFF5 wvDSF5U3nDlmdyavCTas4NWoKwL/vMc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683034797; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bneSG3C6IhTxqmwxZ4nzn8c86/gPbOPgj0CY6DWf86I=; b=FD6IHLUyD2QkfpvH7qS+ZompVAxVkFBztOtNFQ6LmkQE9WqSziAQoydDrroFI+X8tdG/64 tzbgz7ioiAVyUiAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B20FA134FB for ; Tue, 2 May 2023 13:39:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iMBcKq0SUWSWYgAAMHmgww (envelope-from ) for ; Tue, 02 May 2023 13:39:57 +0000 Message-ID: <0d477c40-c6c2-5f7e-9a8a-9136d339e086@suse.de> Date: Tue, 2 May 2023 15:40:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 2/2] [gdb/cli] Fix wrapping for TERM=ansi To: gdb-patches@sourceware.org References: <20230415060905.18498-1-tdevries@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/15/23 10:10, Tom de Vries via Gdb-patches wrote: > On 4/15/23 08:09, Tom de Vries via Gdb-patches wrote: >> [ This patch requires readline_hidden_col, introduced by this patch ( >> https://sourceware.org/pipermail/gdb-patches/2023-April/198877.html ). ] > > Hi, > > I see I accidentally formatted this as a 2/2 patch.  The 1/2 is > obviously the readline_hidden_cols part of the patch mentioned above. > > I can submit that part separately, if anybody thinks that's a good idea, > but for now I'm hoping aforementioned patch will get accepted, and > there'll be no need. > I've submitted a v2 here ( https://sourceware.org/pipermail/gdb-patches/2023-May/199260.html ). Changes v2 vs v1: - no longer fixing this in set_screen_size, but instead in init_page_info. - more extensive analysis in commit log, also covers PR cli/30411 which is caused by the same root cause. - came to the conclusion that "set width" is only supposed to be used to set the screen width, updated help text and doc to make that more clear. Thanks, - Tom