From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id BD97B3851C06 for ; Mon, 1 Jun 2020 14:28:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BD97B3851C06 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-73-qypbhEvXMzOtpiJUVZoe4g-1; Mon, 01 Jun 2020 10:28:38 -0400 X-MC-Unique: qypbhEvXMzOtpiJUVZoe4g-1 Received: by mail-wr1-f69.google.com with SMTP id w4so15318wrl.13 for ; Mon, 01 Jun 2020 07:28:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qTlhzqDuesNgkrauAKXARtv9bjQB2IhQ0OEXtmLLRts=; b=lQDVwbXR6u57GuTyOGP5JmhGRFXjiCuAoy6OqzAWBp2AySVCYFLxy62abt+5hjRO1i AixnhAeKZrWfXnL+l6KYtSqv2a+B/ZQE1vhocvodOXt/QxWoB4GtvHMqRVG2JrjK+22q F6RiS0CxU3CLdsoMT+XSuNlffWZLIuI4rMuQ5ZvNU8W3y8SefPuU7QrEYohXU4w2+DCe rhWq+AcnH7Io6FWziI/hL3xdAr8Zr38l2sqbDG+ixxpCLwmS3DnkueukmMJLUzquPRtC HAWOXcULWG7t9TL14a+GLICxpMe6YPp4GWwYPqtfsaCDi3dYLfGs4rgPE/zfPu19uhTS 8bjA== X-Gm-Message-State: AOAM532PviSZrfHVtNemrynz5t1nNajrJFaC2UfOhoGV6wwgG80FsiLY /G1wceSeUlE7uVngsjyLiyvDLnh113zQhnkjXJJjO1lO9JEMT28/LdjYZWGdNk5izwHexoO0YgZ jLkPV2mtrbGbxj7iOUFu/bA== X-Received: by 2002:adf:ca0e:: with SMTP id o14mr23642900wrh.254.1591021717063; Mon, 01 Jun 2020 07:28:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx120ueluOvNzVIwfwBcgOg+gKYNPfSPybDW3hHBvBYgECCrnXFBee9xmYyLEeJcFWDwuk0HQ== X-Received: by 2002:adf:ca0e:: with SMTP id o14mr23642885wrh.254.1591021716836; Mon, 01 Jun 2020 07:28:36 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id v27sm22405114wrv.81.2020.06.01.07.28.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2020 07:28:36 -0700 (PDT) Subject: Re: [PATCHv3] Fix range end handling of inlined subroutines To: Bernd Edlinger , Andrew Burgess References: <20200311220231.GJ3317@embecosm.com> <20200317222757.GN3317@embecosm.com> <20200323175320.GR3317@embecosm.com> Cc: "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: <0d780e2a-c7ee-75c2-ba66-1072056487c4@redhat.com> Date: Mon, 1 Jun 2020 15:28:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2020 14:28:41 -0000 On 3/23/20 8:58 PM, Bernd Edlinger wrote: > What I did is compare a O(nlogn) vs. O(n^2) implementation > which mimics the visual studio std::vector: I don't think I ever heard of anyone building GDB with Visual Studio. I'm not sure it's even possible, except perhaps with the newer versions which are much more confirming. The standard says that push_back must be amortized O(1). I wonder whether the slow implementation you observed was with an old (and thus grossly non-conforming in many aspects) Visual Studio, which we can safely ignore for GDB. Thanks, Pedro Alves