From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] mi: Restore original thread/frame when specifying --thread or --thread-group
Date: Wed, 17 Aug 2016 20:24:00 -0000 [thread overview]
Message-ID: <0d7f095b-caf7-27c8-e3bc-efb3229845fb@ericsson.com> (raw)
In-Reply-To: <87789b60-69ed-c685-8058-15be519258eb@ericsson.com>
On 16-08-05 04:58 PM, Simon Marchi wrote:
> On 16-08-05 01:26 PM, Pedro Alves wrote:
>> Yeah. The approach of extending the previous_inferior_ptid's scope a bit would
>> avoid this, since it wouldn't need to revert back anything with a cleanup.
>> Might end up being that once all the spots are identified, switching to
>> the other approach ends up being a simpler patch.
>
> Hmm maybe. I'll try to continue on that path and see what it gives. I really feel
> like I don't know what I am doing, but I'll try anyway, that's how we learn I suppose :).
Given the timeframe, I don't think it's realistic nor a good idea to push
to get this into 7.12. Unless there's an obvious way to do it that I missed,
the changes are quite big and risky so close to the release.
Here's my work-in-progress branch in case you'd like to take a high level look.
https://github.com/simark/binutils-gdb/commits/user-selected-ptid
It's not all pretty, but I got the testsuite to pass (at least with native x86
Linux, I haven't tried with remote yet...). The "user_selection" object keeps
the currently selected inferior and thread, but not the frame yet. That means
that if you are inspecting an arbitrary frame and there's an MI command with
--thread, the inferior/thread will be kept, but not your frame.
next prev parent reply other threads:[~2016-08-17 20:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 21:14 [PATCH 0/2] Two MI changes related to separate UIs Simon Marchi
2016-08-01 21:15 ` [PATCH 1/2] mi: Restore original thread/frame when specifying --thread or --thread-group Simon Marchi
2016-08-02 14:49 ` Pedro Alves
2016-08-02 17:45 ` Simon Marchi
2016-08-02 22:32 ` Simon Marchi
2016-08-03 13:41 ` Pedro Alves
2016-08-03 22:24 ` Simon Marchi
2016-08-05 17:26 ` Pedro Alves
2016-08-05 21:01 ` Simon Marchi
2016-08-17 20:24 ` Simon Marchi [this message]
2016-08-01 21:15 ` [PATCH 2/2] mi: Add launch-type={run,attach} in =thread-group-started Simon Marchi
2016-08-02 14:49 ` Eli Zaretskii
2016-08-02 15:55 ` Simon Marchi
2016-08-17 20:17 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d7f095b-caf7-27c8-e3bc-efb3229845fb@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).