From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id B25FA3858417 for ; Mon, 14 Aug 2023 20:38:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B25FA3858417 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RPmSH3xVxz4LQh; Mon, 14 Aug 2023 20:38:07 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RPmSH356bz4Rc7; Mon, 14 Aug 2023 20:38:07 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692045487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=33q8KzI2xyvCJtFX2FovhgVAwTswF/t3xsNMOFzQExM=; b=rWXcmmSvM3Xhz6JZTfxNWBoAUCMFbXg40XdWlA/ZCjJ0zapf/7XZA/YvJ/blccA8oiGU9e 9HUvg9ij5Ol6lrpq7hBT8M+w3dD8BH4QvLihG2tKbRLjix9R/8M0ayTq0Rw84ZR79eJnjD L+K45b/W5hNzq4W74Dlwbosc4ub3u6sS/M+mOZyg7cqPuII3GPBaqbBh7p6LE44bKDnVdd sdVz3fU0ssrI/OnOOuaDS6/ciVeiXrNQh/FA1cXyik69yDO9o66ztIXYxpAwsSEjl8Ldwc JUIxrKDQHjRl+tfAh0MuBk2VpHub6gEnr8J+R85/S94YzBatO9AeTuxHKWeyvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692045487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=33q8KzI2xyvCJtFX2FovhgVAwTswF/t3xsNMOFzQExM=; b=lvZa0Jw1j2H3sE91ux4ANxwAZ6zZgPnOj796L9ZAt9vn257sNd2fwU6wbNzupt8eYqF4oZ G7kQIBGXfA8rSnQw7b7zR9wdYTAXVvzFV00hUaEB41QpAzh/mR0u8gEzZoesc5D2uTO7aS jVV5yuJYtGPzfXkeGMAhdMc1WGXkDTJzSI0DjAGaW05p2nSQ49w29XCondseQaPLSkQC7r iHsfLQcr5/ScA1BunB2/u35XbFL2R0VJAWb4DS8ji12vvkT/Dsb2Mw6a3wOWVnHy0g2EYt zHO04XGMJZ0gwPm+ZPguLev1+ODfnPeuSitiKX25dbtyFTvpKoItJC8AHuWN3Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692045487; a=rsa-sha256; cv=none; b=WHF/FGQZmJcQGPyo4OdBLa57N0YhLXdK+uCSjmHPVmRV7HEdz4oviDIayzfeRj9/GJzwVN NLVZHypivGNd9rLk8ZKVqoKu59CSfg6pEoUgFrHN0pB88r82xOg5nsbbCouV+MICc6/bWu 53P1WDdyeYxNzHprqpgNHPKsPbfwUs2dDsdhmoPxUxjp2jjgg+cHykMfWjyyf6FJ9GY3ta tfuw140ws7hfTYHJ2kcMpjPuKguw8+4y24jVSLaviPZbUMnhY3Txp6UEm8ucyABOL/Q6zT fBhIZVuXj7irWRzml/rWxWfDt+cRbsnBejDp7G+9y73qr1l1eimkvtEwACfufg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:648:8683:a9e0:60dc:f3ce:24c1:ce4d] (unknown [IPv6:2601:648:8683:a9e0:60dc:f3ce:24c1:ce4d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RPmSH0GYhzYZ; Mon, 14 Aug 2023 20:38:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <0dd247cb-a963-d061-fbf3-338d64f0b493@FreeBSD.org> Date: Mon, 14 Aug 2023 13:38:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] C++-ify minidebug.c Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230814194807.63066-1-tom@tromey.com> From: John Baldwin In-Reply-To: <20230814194807.63066-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/14/23 12:48 PM, Tom Tromey wrote: > I noticed minidebug.c was still using explicit malloc and free, where > a vector would be more automatic. > --- > gdb/minidebug.c | 71 +++++++++++++++++++------------------------------ > 1 file changed, 28 insertions(+), 43 deletions(-) Reviewed-by: John Baldwin -- John Baldwin