From: Jeff Law <law@redhat.com>
To: Eric Gallager <egall@gwmail.gwu.edu>
Cc: Hafiz Abid Qadeer <abid_qadeer@mentor.com>,
gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org,
binutils@sourceware.org
Subject: Re: Small typo in iconv.m4
Date: Fri, 09 Nov 2018 18:28:00 -0000 [thread overview]
Message-ID: <0de7b756-49c0-8cd4-bb4d-2e854adc69ca@redhat.com> (raw)
In-Reply-To: <CAMfHzOvXhYkECbdXdTXYk0ev_3PbLFJtrXEmBegqLF7ZFpvKFw@mail.gmail.com>
On 11/9/18 10:57 AM, Eric Gallager wrote:
> On 11/7/18, Jeff Law <law@redhat.com> wrote:
>> On 11/6/18 9:37 AM, Hafiz Abid Qadeer wrote:
>>> Hi All,
>>> I was investigating a character set related problem with windows hosted
>>> GDB and I tracked it down to a typo in iconv.m4. This typo caused
>>> libiconv detection to fail and related support was not built into gdb.
>>>
>>> The problem is with the following line.
>>> CPPFLAGS="$LIBS $INCICONV"
>>> which should have been
>>> CPPFLAGS="$CPPFLAGS $INCICONV"
>>>
>>> OK to commit the attached patch?
>>>
>>> 2018-11-06 Hafiz Abid Qadeer <abidh@codesourcery.com>
>>>
>>> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
>>> Append $INCICONV to it.
>>> * gcc/configure: Regenerate.
>>> * libcpp/configure: Likewise.
>>> * libstdc++-v3/configure: Likewise.
>>> * intl/configure: Likewise.
>>>
>>> Thanks,
>>>
>> THanks. I wasn't sure if you had commit privs, so I went ahead and
>> installed the patch.
>>
>> Jeff
>>
>
> Does this have any effect on GCC bug 78251?
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78251
> Or any of the related bugs under "See Also" for that matter?
Certainly looks related. Though I think we're still going to see
pollution, just in a slightly different way.
jeff
next prev parent reply other threads:[~2018-11-09 18:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 16:37 Hafiz Abid Qadeer
2018-11-07 15:27 ` Simon Marchi
2018-11-07 22:41 ` Jeff Law
2018-11-09 17:57 ` Eric Gallager
2018-11-09 18:28 ` Jeff Law [this message]
2018-11-09 10:18 Hafiz Abid Qadeer
2018-11-09 12:59 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0de7b756-49c0-8cd4-bb4d-2e854adc69ca@redhat.com \
--to=law@redhat.com \
--cc=abid_qadeer@mentor.com \
--cc=binutils@sourceware.org \
--cc=egall@gwmail.gwu.edu \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).