Re: [PATCH][gdb/symtab] Relocate call_site_htab

[Tom de Vries <tdevries@suse.de>]

On 10/1/21 10:25 AM, Tom de Vries wrote:
> n 10/1/21 3:15 AM, Simon Marchi wrote:
>>> Ack, thanks.  I've put this through testing and ran into only two
>>> regressions (so, this used to pass for me with unix/-fPIE/-pie):
>>> ...
>>> FAIL: gdb.trace/entry-values.exp: bt (1) (pattern 1)
>>> FAIL: gdb.trace/entry-values.exp: bt (2) (pattern 1)
>>> ...
>>> while still fixing all the unix/-fno-PIE/-no-pie vs unix/-fPIE/-pie
>>> regressions.
>>>
>>> Fixed by:
>>> ...
>>> diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
>>> index bb5767aae67..fa775722afb 100644
>>> --- a/gdb/dwarf2/read.c
>>> +++ b/gdb/dwarf2/read.c
>>> @@ -13517,7 +13517,8 @@ read_call_site_scope
>>>                        sect_offset_str (die->sect_off), objfile_name
>>> (objfile));
>>>           else
>>>             {
>>> -             lowpc = gdbarch_adjust_dwarf2_addr (gdbarch, lowpc +
>>> baseaddr);
>>> +             lowpc = (gdbarch_adjust_dwarf2_addr (gdbarch, lowpc +
>>> baseaddr)
>>> +                      - baseaddr);
>>>               SET_FIELD_PHYSADDR (call_site->target, lowpc);
>>>             }
>>>         }
>>

I've split this up into a patch series:
- [gdb/symtab] Fix htab_find_slot call in read_call_site_scope
- [gdb/symtab] Remove COMPUNIT_CALL_SITE_HTAB
- [gdb/symtab] Add call_site::pc ()
- [gdb/symtab] Use unrelocated addresses in call_site

Patch series was submitted, first one at
https://sourceware.org/pipermail/gdb-patches/2021-October/182325.html .

Thanks,
- Tom