From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18083 invoked by alias); 23 Aug 2018 18:37:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18064 invoked by uid 89); 23 Aug 2018 18:37:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=kevinb, onto X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Aug 2018 18:37:03 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w7NIauoC007862 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 23 Aug 2018 14:37:01 -0400 Received: by simark.ca (Postfix, from userid 112) id 3D2E31EB3B; Thu, 23 Aug 2018 14:36:56 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 970981E52D; Thu, 23 Aug 2018 14:36:54 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Aug 2018 18:37:00 -0000 From: Simon Marchi To: Joel Brobecker Cc: kevinb@redhat.com, gdb-patches@sourceware.org Subject: Re: GDB 8.2 release 2018-08-21 status update In-Reply-To: <20180821175136.GA3365@adacore.com> References: <20180821175136.GA3365@adacore.com> Message-ID: <0e24ffbeb9706f75c53d3fdcfea3decb@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00578.txt.bz2 On 2018-08-21 13:51, Joel Brobecker wrote: > * [KevinB] PR gdb/23021 > Setting breakpoints with -freorder-blocks-and-partition > https://sourceware.org/bugzilla/show_bug.cgi?id=23021 > > Identified as needed in the previous release, but couldn't do it > in time. We should be very close, now: > [v3] > https://sourceware.org/ml/gdb-patches/2018-08/msg00467.html > > I'm wondering how reasonable it's going to be to backport > those changes onto the branch, though... Any thoughts on that? > Kevin? Simon? The changeset does indeed look scary :). But I think Kevin was careful to keep the existing behaviour for contiguous blocks. Patches 1 and 2 look harmless. Patches 3 and 4 mostly added some branches for the contiguous and the non-contiguous case, where the contiguous case keeps the former behaviour. If you have an executable with only contiguous blocks, it *should* therefore work the same way as before. If you have an executable with non-contiguous blocks, well it would be broken with GDB 8.1, so anything is an improvement. Patch 5 changes BLOCK_START for BLOCK_ENTRY_PC, which is supposed to be the same for contiguous blocks, so again no changes expected there. I'm not sure about the impact of patch 6. Patch 7 modifies the block range data, which is only used in the non-contiguous branches. So again, no impact on existing contiguous-only executables. So from my point of view, it would be fine to include it in 8.2. I'm just wondering though why this was considered as a blocker for 8.2 in the first place. It's not really a regression, it's more like a new feature. Was it to make sure we get the feature to users faster, before the new gcc that emits code like this by default starts to spread too much? Simon