From: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH, GDB] Expect prompt after no FPU warning
Date: Wed, 17 May 2017 12:53:00 -0000 [thread overview]
Message-ID: <0e2b3698-2ee8-0b08-173d-ce60f0602677@foss.arm.com> (raw)
In-Reply-To: <e32303d9-cdc3-ab93-a4d1-d9d5877abef8@foss.arm.com>
[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]
Hi,
The expected output for info float when the target has no FPU does
not include the GDB prompt. This occasionally cause a test failure in
the following "finish" test when the prompt happens after the test has been
marked as PASSed, since it does not match the expected output.
This patch adds the GDB prompt to the expected output of the no FPU
regular expression.
ChangeLog entry is as follows:
*** gdb/testsuite/ChangeLog ***
2017-04-27 Thomas Preud'homme <thomas.preudhomme@arm.com>
* gdb.base/float.exp: Expect GDB prompt for targets without FPU.
Testing: test PASSes with that patch on arm-none-eabi target.
Is this ok for master branch and GDB 8 (after a 1 week period)?
Best regards,
Thomas
On 17/05/17 13:20, Thomas Preudhomme wrote:
>
>
> On 17/05/17 13:10, Yao Qi wrote:
>> Thomas Preudhomme <thomas.preudhomme@foss.arm.com> writes:
>>
>>> 2017-04-27 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>>
>>> * gdb.base/float.exp (info float): Expect GDB prompt for ARM
>>
>> Remove " (info float)".
>>
>>> targets without FPU.
>>>
>>
>>
>>> @@ -50,7 +50,7 @@ if { [is_aarch64_target] } then {
>>> # if we have NEON.
>>> pass "info float (VFP)"
>>> }
>>> - -re "No floating.point info available for this processor.*" {
>>> + -re "No floating.point info available for this
>>> processor.*$gdb_prompt $" {
>>
>> The fix is right but it can be applied to all archs which may not have
>> FPU. If you search "N floating.point info", you can find multiple hits.
>> $gdb_prompt is needed for all of them.
>
> Err yes sorry, I didn't add it because I only tested on ARM. I'll update the
> patch. Thanks!
>
> Best regards,
>
> Thomas
[-- Attachment #2: nofloat_gdb_tests_expect_prompt.patch --]
[-- Type: text/x-patch, Size: 2414 bytes --]
diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp
index a4762c9742682391074f0707e56a6eae4cd70c6e..956bbf752b72e105f36cbfbda369c77a71979708 100644
--- a/gdb/testsuite/gdb.base/float.exp
+++ b/gdb/testsuite/gdb.base/float.exp
@@ -50,7 +50,7 @@ if { [is_aarch64_target] } then {
# if we have NEON.
pass "info float (VFP)"
}
- -re "No floating.point info available for this processor.*" {
+ -re "No floating.point info available for this processor.*$gdb_prompt $" {
pass "info float (without FPU)"
}
}
@@ -63,7 +63,7 @@ if { [is_aarch64_target] } then {
-re "fp0.*fp1.*fp7.*$gdb_prompt $" {
pass "info float (with FPU)"
}
- -re "No floating.point info available for this processor.*" {
+ -re "No floating.point info available for this processor.*$gdb_prompt $" {
pass "info float (without FPU)"
}
}
@@ -81,7 +81,7 @@ if { [is_aarch64_target] } then {
-re "fd0.*fd3.*$gdb_prompt $" {
pass "info float (with FPU)"
}
- -re "No floating.point info available for this processor.*" {
+ -re "No floating.point info available for this processor.*$gdb_prompt $" {
pass "info float (without FPU)"
}
}
@@ -90,7 +90,7 @@ if { [is_aarch64_target] } then {
-re "f0.*f1.*f31.*fpscr.*$gdb_prompt $" {
pass "info float (with FPU)"
}
- -re "No floating.point info available for this processor.*" {
+ -re "No floating.point info available for this processor.*$gdb_prompt $" {
pass "info float (without FPU)"
}
}
@@ -102,7 +102,7 @@ if { [is_aarch64_target] } then {
-re "fpul.*fr0.*fr1.*fr15.*$gdb_prompt $" {
pass "info float (with FPU)"
}
- -re "No floating.point info available for this processor.*" {
+ -re "No floating.point info available for this processor.*$gdb_prompt $" {
pass "info float (without FPU)"
}
}
@@ -111,7 +111,7 @@ if { [is_aarch64_target] } then {
} elseif [istarget "sparc*-*-*"] then {
gdb_test "info float" "f0.*f1.*f31.*d0.*d30.*" "info float"
} else {
- gdb_test "info float" "No floating.point info available for this processor." "info float (unknown target)"
+ gdb_test "info float" "No floating.point info available for this processor.*$gdb_prompt $" "info float (unknown target)"
}
gdb_test "step"
next prev parent reply other threads:[~2017-05-17 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 9:13 [PATCH, GDB/ARM] " Thomas Preudhomme
2017-05-17 12:10 ` Yao Qi
2017-05-17 12:20 ` Thomas Preudhomme
2017-05-17 12:53 ` Thomas Preudhomme [this message]
2017-05-17 13:34 ` [PATCH, GDB] " Yao Qi
2017-05-17 14:49 ` Thomas Preudhomme
2017-05-18 15:46 ` Thomas Preudhomme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e2b3698-2ee8-0b08-173d-ce60f0602677@foss.arm.com \
--to=thomas.preudhomme@foss.arm.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).