From: Sandra Loosemore <sandra@codesourcery.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [patch] gdb/testsuite: Skip directory tests in gdb.base/info_sources.exp on remote host
Date: Thu, 25 Jun 2020 14:41:21 -0600 [thread overview]
Message-ID: <0e4e07f8-c673-ffa0-cac5-407ef4f129a3@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 94 bytes --]
Here's another patch for a remote-host testing issue I've run across.
OK to commit?
-Sandra
[-- Attachment #2: info_sources.patch --]
[-- Type: text/x-patch, Size: 2031 bytes --]
commit e08464126c11c710a11d94e4cc6a8b06593465be
Author: Sandra Loosemore <sandra@codesourcery.com>
Date: Thu Jun 25 13:22:11 2020 -0700
Skip directory tests in gdb.base/info_sources.exp on remote host
When testing on a remote host, source files from build are copied to
an arbitrary location on host. Tests that try to pattern-match host
pathnames against directory prefixes on build don't generally work.
2020-06-25 Sandra Loosemore <sandra@codesourcery.com>
gdb/testsuite/
* gdb.base/info_sources.exp: Skip directory match tests on
remote hosts.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 8ad2448..3434aa1 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2020-06-25 Sandra Loosemore <sandra@codesourcery.com>
+
+ * gdb.base/info_sources.exp: Skip directory match tests on
+ remote hosts.
+
2020-06-25 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb.arch/riscv-tdesc-regs.exp: New test cases.
diff --git a/gdb/testsuite/gdb.base/info_sources.exp b/gdb/testsuite/gdb.base/info_sources.exp
index fa643c5..8bcedfa 100644
--- a/gdb/testsuite/gdb.base/info_sources.exp
+++ b/gdb/testsuite/gdb.base/info_sources.exp
@@ -71,7 +71,9 @@ test_info_sources "--" 1 1
# List both files with regexp matching anywhere in the filenames:
test_info_sources "info_sources" 1 1
-test_info_sources "gdb.base" 1 1
+if { ! [is_remote host] } {
+ test_info_sources "gdb.base" 1 1
+}
# List both files with regexp matching the filename basenames,
# using various parts of the -basename option:
@@ -88,8 +90,10 @@ test_info_sources "-b base" 0 1
# List the files with dirname matching regexp,
# using various part of the -dirname option:
-test_info_sources "-d base" 1 1
-test_info_sources "-dirname base" 1 1
+if { ! [is_remote host] } {
+ test_info_sources "-d base" 1 1
+ test_info_sources "-dirname base" 1 1
+}
# Test non matching regexp, with option terminator:
test_info_sources "-b -- -d" 0 0
next reply other threads:[~2020-06-25 20:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 20:41 Sandra Loosemore [this message]
2020-07-13 15:33 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e4e07f8-c673-ffa0-cac5-407ef4f129a3@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).