From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9775 invoked by alias); 21 Mar 2019 18:08:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9766 invoked by uid 89); 21 Mar 2019 18:08:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=85 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Mar 2019 18:08:37 +0000 Received: from [172.16.0.89] (192-222-157-41.qc.cable.ebox.net [192.222.157.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 022E51E4F4; Thu, 21 Mar 2019 14:08:34 -0400 (EDT) Subject: Re: [PATCH 00/16] Add styling to the gdb CLI and TUI To: Eli Zaretskii , Pedro Alves Cc: tom@tromey.com, gdb-patches@sourceware.org References: <20181128001435.12703-1-tom@tromey.com> <83k1kxfzwo.fsf@gnu.org> <8736rja4i8.fsf@tromey.com> <83r2brhw8k.fsf@gnu.org> <87h8cmh1wg.fsf@tromey.com> <83va12gz8j.fsf@gnu.org> <87mumeb935.fsf@tromey.com> <83d0n8eyzw.fsf@gnu.org> <87d0n6adk2.fsf@tromey.com> <83imwyee29.fsf@gnu.org> <87d0n67d29.fsf@tromey.com> <83imwwc7pj.fsf@gnu.org> <57558f60-8254-931f-846b-bdd6b60f5798@simark.ca> <838sx8uwbb.fsf@gnu.org> <834l7wushq.fsf@gnu.org> <0f1760b45f024d45ceece8f0fe5c2686@simark.ca> <83zhpotb38.fsf@gnu.org> From: Simon Marchi Message-ID: <0e500186-b830-75a3-b3f8-9e5688404c5a@simark.ca> Date: Thu, 21 Mar 2019 18:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <83zhpotb38.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00466.txt.bz2 On 2019-03-21 1:02 p.m., Eli Zaretskii wrote: >> Cc: tom@tromey.com, gdb-patches@sourceware.org >> From: Pedro Alves >> Date: Thu, 21 Mar 2019 16:12:26 +0000 >> >> Is there an advantage of a single variable that encodes the version, >> compared to separate major/minor variables? > > Just that it makes comparison simpler, and IME less error-prone. Not > a very important argument, admittedly. > Yeah, if you want to check if you are running 8.5 or more, you can do: if $_gdb_version >= 805 With separate components, you have to do something like if $_gdb_version_major >= 9 \ || ($_gdb_version_major >= 8 && $gdb_version_minor >= 5 If you need to check for a range, it's even more complicated. But then, if the version is provided as separate components, nothing prevents you to re-encode it however you want after that. You can do easily enough set $my_gdb_version = ($_gdb_version_major * 100) + $_gdb_version_minor if you want, and use the simple comparison. And everyone is free to choose their own encoding :). So, to me separate components sounds better. Simon