public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Carl Love <cel@us.ibm.com>, Pedro Alves <pedro@palves.net>,
	gdb-patches@sourceware.org
Cc: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
	Rogerio Alves <rogealve@br.ibm.com>
Subject: Re: [PATCH] PowerPC: bp-permanent.exp, kill-after-signal fix
Date: Mon, 9 May 2022 19:35:19 +0200	[thread overview]
Message-ID: <0e7c3026-3a42-5db7-8046-b0133718218e@suse.de> (raw)
In-Reply-To: <b6cfd9eee950c3a90a1620afe81ae888f8663680.camel@us.ibm.com>

On 5/3/22 22:10, Carl Love via Gdb-patches wrote:
> -gdb_test "stepi" "\r\nhandler .*"
> +
> +set test "handler"
> +gdb_test_multiple "stepi" $test {
> +    -re "\r\nhandler .*" {
> +	pass $test
> +    }

Hi Carl,

gdb_test expects a gdb prompt after "\r\nhandler .*", but 
gdb_test_multiple doesn't.

This causes:
...
(gdb) PASS: gdb.base/kill-after-signal.exp: continue
stepi^M
handler (signo=32767) at 
/home/vries/gdb_versions/devel/src/gdb/testsuite/gdb.base/kill-after\
-signal.c:25^M
25      {^M
PASS: gdb.base/kill-after-signal.exp: handler
kill^M
(gdb) FAIL: gdb.base/kill-after-signal.exp: kill
...

Triggered on x86_64-linux with taskset -c 0.

This fixes it for me:
...
-    -re "\r\nhandler .*" {
+    -re -wrap "\r\nhandler .*" {
...

Can you verify and commit?

Thanks,
- Tom

  parent reply	other threads:[~2022-05-09 17:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29  1:06 Carl Love
2022-05-02 14:09 ` Ulrich Weigand
2022-05-02 14:32 ` Pedro Alves
2022-05-02 14:55   ` will schmidt
2022-05-02 15:19     ` Carl Love
2022-05-02 15:24       ` Pedro Alves
2022-05-03 20:10   ` Carl Love
2022-05-06 16:16     ` Pedro Alves
2022-05-09 17:35     ` Tom de Vries [this message]
2022-05-09 19:22       ` Carl Love
2022-05-09 20:43       ` [PATCH Fixup] " Carl Love
2022-05-10  9:27         ` Tom de Vries
2022-05-10 15:13           ` Carl Love
2022-05-10 19:07             ` [PATCH Fixup V2] " Carl Love
2022-05-16 15:46               ` [PATCH PING " Carl Love
2022-05-18  7:33                 ` Tom de Vries
2022-05-02 15:04 ` [PATCH] " will schmidt
2022-05-02 15:10   ` Ulrich Weigand
2022-05-02 17:18     ` will schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e7c3026-3a42-5db7-8046-b0133718218e@suse.de \
    --to=tdevries@suse.de \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=cel@us.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    --cc=rogealve@br.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).