From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 731D33858D32 for ; Tue, 8 Nov 2022 17:52:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 731D33858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A5A892236D; Tue, 8 Nov 2022 17:52:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667929936; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9cwi4Z4ffUMuhVusTJKB7AsuCzsplYXWd/F6S/LGINs=; b=Ihc5X3VKoMd/NKQwUq/J3t/gIti5VbspmT4x1PGqDwtbjWleB6SHZlz1wiYXIpKwEE2bYs CRpYLSOwU1Pmrhq/qX+IZFx06ks78oNDAw2d9lvQl3MofmdCzlogNvS/ejKdEJs974TlrX mI7tZaHgaHEZ5tDoTVw9+O60LXWYm2s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667929936; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9cwi4Z4ffUMuhVusTJKB7AsuCzsplYXWd/F6S/LGINs=; b=vaoHho/DrDtB7JMqRwHHVCLq8jS4oCT5/Q/nMV6Px4VBMqWyM0SC2ZHW0BOGTe/OZT+iLJ XSZSwAeO+A2uRsBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 89E06139F1; Tue, 8 Nov 2022 17:52:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uVFKIFCXamNUKQAAMHmgww (envelope-from ); Tue, 08 Nov 2022 17:52:16 +0000 Message-ID: <0e9b1bd1-c99e-953a-48f7-4be9c94f15f0@suse.de> Date: Tue, 8 Nov 2022 18:52:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] [gdb/cli] Make quit really quit after remote connection closed Content-Language: en-US To: Tom Tromey , Tom de Vries via Gdb-patches References: <20221104175007.27221-1-tdevries@suse.de> <871qqd5pam.fsf@tromey.com> From: Tom de Vries In-Reply-To: <871qqd5pam.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/8/22 18:28, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries via Gdb-patches writes: > > Tom> But when doing monitor exit followed by quit with confirmation, we get the gdb > Tom> prompt back, requiring us to do quit once more: > > Thanks for doing this. > > Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=15746 > > I think mentioning "PR server/15746" in the commit message would cause > this to show up in bugzilla. > I've tried that, but that didn't seem to work. Maybe I need to wait longer, I'm not sure. > Other than that, this looks good to me. thanks for the review, committed. - Tom