* Re: [PATCH] gdb: use foreach_with_prefix in gdb.base/break-interp.exp
[not found] <20200306223218.20320-1-simon.marchi@efficios.com>
@ 2020-03-12 18:26 ` Tom Tromey
2020-03-12 18:34 ` Simon Marchi
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2020-03-12 18:26 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> Use foreach_with_prefix, instead of foreach and with_test_prefix
Simon> separately. Since allows removing some indentation levels, and formats
Simon> the test names a bit nicer, in my opinion (or at least, it's more
Simon> consistent with the rest of the testsuite):
This seems like a good idea to me. Thanks.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gdb: use foreach_with_prefix in gdb.base/break-interp.exp
2020-03-12 18:26 ` [PATCH] gdb: use foreach_with_prefix in gdb.base/break-interp.exp Tom Tromey
@ 2020-03-12 18:34 ` Simon Marchi
0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi @ 2020-03-12 18:34 UTC (permalink / raw)
To: Tom Tromey, Simon Marchi; +Cc: gdb-patches
On 2020-03-12 2:26 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> Use foreach_with_prefix, instead of foreach and with_test_prefix
> Simon> separately. Since allows removing some indentation levels, and formats
> Simon> the test names a bit nicer, in my opinion (or at least, it's more
> Simon> consistent with the rest of the testsuite):
>
> This seems like a good idea to me. Thanks.
>
> Tom
>
Thanks, I pushed it.
Simon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-12 18:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200306223218.20320-1-simon.marchi@efficios.com>
2020-03-12 18:26 ` [PATCH] gdb: use foreach_with_prefix in gdb.base/break-interp.exp Tom Tromey
2020-03-12 18:34 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).