From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68662 invoked by alias); 16 Aug 2018 17:00:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68435 invoked by uid 89); 16 Aug 2018 17:00:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ebb, EBB, Hx-languages-length:2094, franco X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Aug 2018 17:00:33 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0B319CB9D8; Thu, 16 Aug 2018 17:00:21 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 373212027047; Thu, 16 Aug 2018 17:00:20 +0000 (UTC) Subject: Re: [PATCH v4 00/12] GDB support for more powerpc registers on linux To: Pedro Franco de Carvalho , gdb-patches@sourceware.org References: <20180815000608.26840-1-pedromfc@linux.ibm.com> <87wosqntwa.fsf@linux.vnet.ibm.com> Cc: uweigand@de.ibm.com, edjunior@gmail.com From: Pedro Alves Message-ID: <0f08d344-7096-c9fc-6eed-0215d3f63001@redhat.com> Date: Thu, 16 Aug 2018 17:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87wosqntwa.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00404.txt.bz2 -- Thanks, Pedro Alves On 08/16/2018 05:44 PM, Pedro Franco de Carvalho wrote: > > Pedro Franco de Carvalho writes: > >> These are all the changes compared to V2, following the suggestions >> there, and following the changes to linux-tdep.c: >> >> * Adapted "Zero-initialize linux note sections" due to recent changes >> from commit a616bb9450. >> >> * Added a comment to "Zero-initialize linux note sections" >> >> * Adapted all the four main patches that enable the registers >> (PPR/DSCR, TAR, EBB/PMU and HTM) to account for the changes from >> commit a616bb9450. >> >> * De-duplicated testcase names. Changed a few of the test names so >> that they are environment-independent. Fixed a few other minor >> issues with the testcases. >> >> * Changed one of the testcases for the HTM registers so that it >> XFAILs. This testcase occasionally failed, possibly due to a kernel >> bug. >> >> * Fixed some of the formatting and const-correctness in "[PowerPC] Add >> support for HTM registers", in gdbserver/linux-ppc-low.c. >> >> * Added an item in the NEWS file on the last commit, indicating all >> the newly supported registers from this series. > > Considering Ulrich had already approved the V2 patches, do these changes > need to be re-approved, or can they be considered as obvious, and can I > commit them? > I was reading through the series as you sent this. I sent a couple comments to patches #12 and #14. The remarks in #12 is something that can always be addressed with this series already merged. Re. the comments for #14, it would be nice to go over the series and add missing intro comments to functions, etc. Otherwise, it all LGTM. I only really skimmed it for mechanics, since as you say Ulrich already reviewed it, and I'm far from a Power expert anyway. > I don't know if a NEWS item counts as obvious, but if not, I can submit > it in a separate patch. It's usually reviewed like other patches. gdb/NEWS falls under Eli's documentation maintainership. Thanks, Pedro Alves