From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130508 invoked by alias); 30 Oct 2017 11:47:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130498 invoked by uid 89); 30 Oct 2017 11:47:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Oct 2017 11:46:59 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AA61481DF3; Mon, 30 Oct 2017 11:46:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AA61481DF3 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F8B2CBC63; Mon, 30 Oct 2017 11:46:57 +0000 (UTC) Subject: Re: [PATCH] Merge/shared string_printf and string_vprintf unit tests To: John Baldwin , gdb-patches@sourceware.org References: <1508194677-19549-1-git-send-email-palves@redhat.com> <2358777.gznjGWP7tP@ralph.baldwin.cx> From: Pedro Alves Message-ID: <0f206b9b-76ee-21e2-1627-aff2ab7f3110@redhat.com> Date: Mon, 30 Oct 2017 11:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <2358777.gznjGWP7tP@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00880.txt.bz2 On 10/18/2017 06:40 PM, John Baldwin wrote: > On Monday, October 16, 2017 11:57:57 PM Pedro Alves wrote: >> Merge the string_printf and string_vprintf tests, running them all >> against both functions. >> >> gdb/ChangeLog: >> 2017-10-16 Pedro Alves >> >> * unittests/common-utils-selftests.c (format_func): New typedef. >> (string_printf_tests, string_vprintf_tests): Tests factored out >> and merged to ... >> (test_format_func): ... this new function. >> (string_printf_tests, string_vprintf_tests): Reimplement on top of >> test_format_func. > > Looks good to me. > Thanks much for the review John. I've pushed this in now, with a tweak to add ATTRIBUTE_PRINTF where appropriate: typedef std::string (format_func) (const char *fmt, ...) ATTRIBUTE_PRINTF (1, 2); static void ATTRIBUTE_PRINTF (2, 3) string_vappendf_wrapper (std::string &str, const char *fmt, ...) ... after noticing Simon's recent similar change to this file that meanwhile went in. Thanks, Pedro Alves