From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 458743857820
 for <gdb-patches@sourceware.org>; Mon,  5 Oct 2020 18:01:03 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 458743857820
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net
 [192.222.181.218])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id D4F951E58D;
 Mon,  5 Oct 2020 14:01:02 -0400 (EDT)
Subject: Re: [PATCH] sim: Fix autoreconf errors in sim/ directory
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
References: <20201005171336.1861212-1-andrew.burgess@embecosm.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <0f42df25-1886-dae0-7bad-5f45b8b74e7a@simark.ca>
Date: Mon, 5 Oct 2020 14:01:02 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201005171336.1861212-1-andrew.burgess@embecosm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Oct 2020 18:01:07 -0000

On 2020-10-05 1:13 p.m., Andrew Burgess wrote:
> Run autoreconf in sim/ directory and you'll see some errors.  The
> problem is that autoreconf (a perl script) does not evaluate the value
> passed as an argument to AC_CONFIG_AUX_DIR, so something like:
>
>   AC_CONFIG_AUX_DIR(`cd $srcdir;pwd`/../..)
>
> does not do the right thing inside autoreconf, my understanding is
> that changing to something like this is fine:
>
>   AC_CONFIG_AUX_DIR(../..)
>
> the generated configure seems to check the value passed, and the value
> passed relative to the source directory, so I think we get basically
> the same behaviour as before.
>
> sim/testsuite/ChangeLog:
>
> 	* configure: Regnerate.
> 	* configure.ac (AC_CONFIG_AUX_DIR): Update.
>
> sim/testsuite/d10v-elf/ChangeLog:
>
> 	* configure: Regnerate.
> 	* configure.ac (AC_CONFIG_AUX_DIR): Update.
>
> sim/testsuite/frv-elf/ChangeLog:
>
> 	* configure: Regnerate.
> 	* configure.ac (AC_CONFIG_AUX_DIR): Update.
>
> sim/testsuite/m32r-elf/ChangeLog:
>
> 	* configure: Regnerate.
> 	* configure.ac (AC_CONFIG_AUX_DIR): Update.
>
> sim/testsuite/mips64el-elf/ChangeLog:
>
> 	* configure: Regnerate.
> 	* configure.ac (AC_CONFIG_AUX_DIR): Update.

Looking at the generates configure files, I think that it's good.

Simon