From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=tAMB=5J=polymtl.ca=simon.marchi@sourceware.org>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
	by sourceware.org (Postfix) with ESMTPS id 17E1F3858C66
	for <gdb-patches@sourceware.org>; Thu, 12 Jan 2023 18:46:20 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17E1F3858C66
Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca
Received: from simark.ca (simark.ca [158.69.221.121])
	(authenticated bits=0)
	by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 30CIk9HA023529
	(version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
	Thu, 12 Jan 2023 13:46:13 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 30CIk9HA023529
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca;
	s=default; t=1673549174;
	bh=1OHFOtvRzwvfCybwZIoDPygIRUGxcWOodmuTx5HoE28=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=XrTiHYDxi90pOdISLUW4D7SfCLCjFzzv8MF3UiB16t8rmXJlAM6HB/3LHVbF3CR7E
	 xlLNIwAANNB8FbBcH2NpAg9N+PjXUHyZ4rl4CFbQhCButQvPguhMy1KuM5qqeky7cG
	 CvIaTXFLQiDBaePEoFXAFgA0saKvlWbrCK2rbU5M=
Received: from [10.0.0.11] (unknown [217.28.27.60])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPSA id 7A40F1E110;
	Thu, 12 Jan 2023 13:46:08 -0500 (EST)
Message-ID: <0f5e6a68-5927-8cfe-24b2-6b91c07578b2@polymtl.ca>
Date: Thu, 12 Jan 2023 13:46:07 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v8 3/6] GDB: Add references to erased args in cli-decode.c
Content-Language: en-US
To: "Maciej W. Rozycki" <macro@embecosm.com>, gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>, Tom Tromey <tom@tromey.com>,
        Simon Sobisch <simonsobisch@web.de>
References: <alpine.DEB.2.20.2211240256210.19931@tpp.orcam.me.uk>
 <alpine.DEB.2.20.2211240502050.19931@tpp.orcam.me.uk>
From: Simon Marchi <simon.marchi@polymtl.ca>
In-Reply-To: <alpine.DEB.2.20.2211240502050.19931@tpp.orcam.me.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 12 Jan 2023 18:46:09 +0000
X-Spam-Status: No, score=-3032.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>



On 11/24/22 06:22, Maciej W. Rozycki wrote:
> Complement commit 1d7fe7f01b93 ("gdb: Introduce setting construct within 
> cmd_list_element") and commit 702991711a91 ("gdb: Have setter and getter 
> callbacks for settings") and update inline documentation accordingly for 
> `add_set_or_show_cmd' and `add_setshow_cmd_full_erased', documenting the 
> `args' parameter and removing references to `var', `set_setting_func' 
> and `get_setting_func'.

If you want to change them so they cross-reference a single place where
these parameters are documented, it would be fine too.  But in any case:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon