From: Simon Marchi <simon.marchi@polymtl.ca>
To: Samuel Thibault <samuel.thibault@gnu.org>, gdb-patches@sourceware.org
Cc: Thomas Schwinge <thomas@codesourcery.com>, thomas@schwinge.name
Subject: Re: [PATCH] hurd: Fix RPC link names
Date: Mon, 31 Jan 2022 19:56:35 -0500 [thread overview]
Message-ID: <0f896293-65d3-28bf-ef43-d965a1114136@polymtl.ca> (raw)
In-Reply-To: <20220201000450.2lfmwt6hwyd2qcg5@begin>
On 2022-01-31 19:04, Samuel Thibault via Gdb-patches wrote:
> The RPC stub code expects to be calling a C function, not a C++
> function.
>
> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
> index 67ce00e9c30..030ccf01d68 100644
> --- a/gdb/gnu-nat.c
> +++ b/gdb/gnu-nat.c
> @@ -1766,11 +1766,13 @@ do_mach_notify_dead_name (mach_port_t notify, mach_port_t dead_port)
>
> \f
> #define ILL_RPC(fun, ...) \
> + extern "C" { \
> extern kern_return_t fun (__VA_ARGS__); \
I think this could be on a single line:
extern "C" kern_return_t fun..
LGTM in any case.
Simon
next prev parent reply other threads:[~2022-02-01 0:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 0:04 Samuel Thibault
2022-02-01 0:56 ` Simon Marchi [this message]
2022-02-01 1:05 ` Samuel Thibault
2022-02-01 1:05 ` Simon Marchi
2022-02-01 1:23 ` Samuel Thibault
2022-02-01 1:31 ` Simon Marchi
2022-02-01 2:08 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f896293-65d3-28bf-ef43-d965a1114136@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=samuel.thibault@gnu.org \
--cc=thomas@codesourcery.com \
--cc=thomas@schwinge.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).