Re: [PATCH 1/3] gdb: testsuite: leave can_spawn_for_attach alone

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2022-03-16 05:58, Tiezhu Yang wrote:
> As Pedro Alves said, caching procs should not issue pass/fail [1],
> this commit removes gdb_test_multiple in can_spawn_for_attach.
> 
> [1] https://sourceware.org/pipermail/gdb-patches/2022-March/186311.html
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>  gdb/testsuite/lib/gdb.exp | 48 +++++++----------------------------------------
>  1 file changed, 7 insertions(+), 41 deletions(-)
> 
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index a35d08a..8fafcc0 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -5081,7 +5081,7 @@ proc gdb_exit { } {
>  # Return true if we can spawn a program on the target and attach to
>  # it.
>  
> -gdb_caching_proc can_spawn_for_attach {
> +proc can_spawn_for_attach { } {
>      # We use exp_pid to get the inferior's pid, assuming that gives
>      # back the pid of the program.  On remote boards, that would give
>      # us instead the PID of e.g., the ssh client, etc.
> @@ -5098,46 +5098,6 @@ gdb_caching_proc can_spawn_for_attach {
>  	return 0
>      }

If we don't want can_spawn_for_attach to emit test results, we should
also remove the "unsupported" calls.  If you'd like to still get a trace
about why a test run doesn't support spawning for attach, you can
replace those with "verbose -log ...", instead of removing them.

Maybe change the subject to "remove attach test from
can_spawn_for_attach", that would be more precise than "leave
can_spawn_for_attach alone".

With those changed, this patch LGTM, it essentially reverts to the
original state.

Simon