From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by sourceware.org (Postfix) with ESMTPS id AFFCB385781A for ; Wed, 17 Mar 2021 12:53:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AFFCB385781A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f47.google.com with SMTP id 61so1690792wrm.12 for ; Wed, 17 Mar 2021 05:53:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JIzNb2SjXwIqPm4ZMUhCOtq6WjTLCyS/iz3u2MiGzJw=; b=JbcRwIUxnB/fxvHprEsG+QA1h3t9JvR+7BhXCDtGCz+JM0qivCPWh/XHaMLze6ANzt mYHHiPrRPHPVvRv7sbk5cggf9Py4u0WkjdcuG79VmrBKyF28sTx/OdcaccYrIY7aJyF+ MhOXNtkj4YZzwTJTFBuz0zP8QCBoa+QAbmABvxmy+yc+//M+b1hLZGTKzGn+VwtDt9Lo 9nxVNf1qqvqubAIauNeSoGcDTziMtoTLwHNsAv+s2x9hzgpP48xR/QVSWHdHhT4wmQ8g FP4UnvDDn2DrKAcpMhg8hM9cTIt/eL3lDHh1N1DBAXa2mh8CHdDhE9SBky58CjtKH5fN lHgQ== X-Gm-Message-State: AOAM533GOWcD5KM6e61Srb4BEx1bQezBijRX4G8PyjyUMHh4+IRc7ZwS dYso/9gL9h7UUfiskXyPVg49NLKqn2uYzg== X-Google-Smtp-Source: ABdhPJx53HRdlWUja77ZWh9lTmVPk8xt65k2OkTT9UONSXpYwd+EoVefX5gkMdzmb9Mk6/B3Eg8OFw== X-Received: by 2002:adf:fb0b:: with SMTP id c11mr4312745wrr.425.1615985581244; Wed, 17 Mar 2021 05:53:01 -0700 (PDT) Received: from ?IPv6:2001:8a0:f916:a600:9771:143b:d196:d07e? ([2001:8a0:f916:a600:9771:143b:d196:d07e]) by smtp.gmail.com with ESMTPSA id n4sm2319730wmq.40.2021.03.17.05.53.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Mar 2021 05:53:00 -0700 (PDT) Subject: Re: [PATCH v4 1/3] gdb/testsuite: add test for run/attach while program is running From: Pedro Alves To: Simon Marchi , gdb-patches@sourceware.org References: <20210125045730.1739754-1-simon.marchi@polymtl.ca> <20210125045730.1739754-2-simon.marchi@polymtl.ca> Message-ID: <0f9cbfe7-dc2d-0d69-974d-d49190e5d8ea@palves.net> Date: Wed, 17 Mar 2021 12:52:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 12:53:06 -0000 Hi! On 06/02/21 18:22, Pedro Alves wrote: > I was surprised to see the thread 0/1 cases separated instead of in a > foreach_with_prefix loop. I gave it a try, and it results in a net reduction > of lines of code. See below. > > Otherwise, LGTM. Thanks! FYI, I squashed in those changes and merged it to master. Pedro Alves