From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2056.outbound.protection.outlook.com [40.107.20.56]) by sourceware.org (Postfix) with ESMTPS id D2D473858D3C for ; Fri, 11 Mar 2022 09:47:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D2D473858D3C Received: from AM6PR10CA0003.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::16) by VE1PR08MB5790.eurprd08.prod.outlook.com (2603:10a6:800:1a9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Fri, 11 Mar 2022 09:47:51 +0000 Received: from AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::1f) by AM6PR10CA0003.outlook.office365.com (2603:10a6:209:89::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.23 via Frontend Transport; Fri, 11 Mar 2022 09:47:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT056.mail.protection.outlook.com (10.152.17.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22 via Frontend Transport; Fri, 11 Mar 2022 09:47:50 +0000 Received: ("Tessian outbound 1f399c739551:v113"); Fri, 11 Mar 2022 09:47:50 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 55dfcec2c1a518d4 X-CR-MTA-TID: 64aa7808 Received: from 1c78022c53d5.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C8A2A7B9-C25F-4A8A-8883-1130CF3888E6.1; Fri, 11 Mar 2022 09:47:39 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1c78022c53d5.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Mar 2022 09:47:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hAMDfiqh+Ym5yUIMX2ITvg7cDMJNmFx3yjvtRLZ8C72hI90rWgMYLpihvXD0InbI/8BKCff2rnb4NxcGaG7Ak+ZdRTbA/z2+ezFLr6csxeyF62m87GtfH/R/PJSla+r1arVRgGX8ZbitcGlEIyEhik8YKy9T3vNzMhXZwI4IoSUmk1Q847EEHREi4Ju3NGf76R662wg/6kq2rD9NryNlM+0hH7DLq8caNGPDvUg8AO+vMIkzNDObJvG+hX3X6wZRxgP6w8AWOvtse913exDIswIyUkKxEdz2bHBdEYU0XGGQ/uE2uyuMPu6fLf19Fz1txeYbkQiBc9j6cLsNIGEM7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EeqJ2Nmibg8xz3BcZWkWIM7dQhJP2N5NTMJs2bt2avc=; b=kWg4VO9Nbbc/kjvA23nv6kgn8k0/yl6aRVcsr9Vi88cCB+q+XYL561U7FgyFVi0ClKT2D2GSZX8FMomfKXUIFJuH9y/8g0GdJdB0UhzSivXjM8zUsA5366FKUbqUatcHEvRIxBoc0xLqNBVaTLLAn6Kn9fYAI9jSoXNfXiHlYt2K94TWOpnjtUMSBluvBiYBTDZNB8AxQAPyxzcY6bBWdhWdcl5C7zeGm/QCTd+3pGt1xkbMZSEJICf574W2E6B2q0Fh32JizVtUQG5Dx13J/gYetizDJyI240n+VswMQHzMRFUB9lfaLOp+gtPGSLxZUz5+RawAgKybxSwcYquqUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3694.eurprd08.prod.outlook.com (2603:10a6:803:b6::26) by AM8PR08MB5665.eurprd08.prod.outlook.com (2603:10a6:20b:1da::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.21; Fri, 11 Mar 2022 09:47:29 +0000 Received: from VI1PR08MB3694.eurprd08.prod.outlook.com ([fe80::bcd8:8251:cd46:f063]) by VI1PR08MB3694.eurprd08.prod.outlook.com ([fe80::bcd8:8251:cd46:f063%5]) with mapi id 15.20.5038.027; Fri, 11 Mar 2022 09:47:29 +0000 Message-ID: <0fae089e-412b-289f-38ae-48c083565896@arm.com> Date: Fri, 11 Mar 2022 10:47:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 0/5] arm: Add support for multiple stacks on Cortex-M Content-Language: en-US To: Yvan Roux Cc: Joel Brobecker , torbjorn.svensson@st.com, Maxim Kuvyrkov via Gdb-patches , Luis Machado References: <20220204084151.14480-1-christophe.lyon@gmail.com> <45235B67-731E-4EE7-81E1-62A720E963A4@linaro.org> <53361ca7-d2fe-79d7-7e34-cdf5e3656174@arm.com> <20220311094023.GA22664@gnbcxd0114.gnb.st.com> From: Christophe Lyon In-Reply-To: <20220311094023.GA22664@gnbcxd0114.gnb.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0239.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::35) To VI1PR08MB3694.eurprd08.prod.outlook.com (2603:10a6:803:b6::26) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 271ada4b-7529-4830-63b0-08da0344351f X-MS-TrafficTypeDiagnostic: AM8PR08MB5665:EE_|AM5EUR03FT056:EE_|VE1PR08MB5790:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +BSdUeOAiyYsCpGTCYzvDnVOntrzNiVxQCRXrB3yUbTb1zMfue4wjSr1jKiNcn/TlQQbA26JeFfE8YNS2DegCQ45DxfNeQK3C2mrJ3EeM7uCgLBas2po+nJ9O43r8iC37aN23LdKeKNc3Sh/RDKwnjVm0UtTV1vcGYiXbHVUaTEZLSGqiXQXHjA9c6yPYFcBdmd6jiHSJOkN76j6tt39ov+xpzp7Pp2H9XGqAMLFF51/7KfT8rK9KEhr7wge1Aok+cKzSNyKyrHPk//KQNROdWCDfNvyJVZ0aovNOIOfNIyoBMMqqCr8JJB93BUuqYbIbwDPhQtAxIPr3Z8jQC/fxMTE20hkM5dZpLJoH9vAFSZ66Wks9NSW0TkP4RK3Hb4l/2FV3kAsY6BO9R1Nim6TT9qCal3/xhJlc3sAnCM2pEndSQP+P5gGo0K2KX14DXf9cYRntdseGw0Gp3uXwFDw+CLfuIevLkbbn+v0KVyMLYCkVEQ4efm8TVu6a7TQISyokHk9dvrVhOCysVF0XD0TId7XiwQShB5+4epu4vwEVsL2qyBf6vbi4sVD/m973MDzqcNN5DMl0ybaI7Q0NfLW+LUETd8h1Dmdc+Kpr2Og8u+xWTe0X2ZnfKWqdyq2PzxpcxBJiSi0IEDC6Y4ULMUkZg2fkF7BgZvstnZmuLdqXc2JUOv5r1RmXSzBhoF1R5Q46/WCncyQJhKt3p88UeTJE6ueqb8F3Ei60Gpoo61K3Ds= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3694.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(4326008)(8676002)(36756003)(6512007)(6666004)(53546011)(6506007)(6486002)(508600001)(5660300002)(66476007)(66946007)(31686004)(66556008)(8936002)(86362001)(6916009)(38100700002)(44832011)(316002)(54906003)(2906002)(83380400001)(186003)(26005)(2616005)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5665 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fd9348be-65d8-41e8-4711-08da034427c5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z2sop+ZJDtTTsOCeJZS44F9w/cw26kMKO84VrDOV8bS1mzGQpfBTapiUwSYSB2Qo7KK7WWPjFb7c/GeIPmaNvR9gmJnUYppNoX+V4LJmEiQhwG+htwcgLr4aEgz3n67rjHMghkoZY/+JqwGat/p0Y1xC5uxmcNpKxE2ya301UkMaLmgdD/z13QSh+cUoJ+lbj0HAR+chPheakcfC1nLkmu/CTosDEXQX1ebIikm3Mz5cPBkreSAGMDlhlN5RH68s4ooG9M0AmY/6rjUHhi1AprtqB5CZEtltwzIiGPBwcerBN6QimZX28/j58K0hEqyRXVJFYP7uqUf8BDFMFTxcANg/S4dAplFOCF26JwuHwoy6+I6nO28jiCbo8f63aHYQnVx2kbBQuVep5jhQRu64eFOdqXeD8spiP+iirnOsGBQ3N8+YirxbEUsCTHC6HZqb9G4UvnFZP5GbLy19cQGLzBWzLYmBtP+tNiwT2HsF131txsDBsWYN7iay8TTDf0piGzDEYUlBm/NF2aORdsWA5I+pifuEiAD4nzCwW3XNVk7TtS/mf0ZMbOwalAsjL/+psooj0Qzj9OfBBuY2rb+ZaYnDl0p6y6JyVwWaYnswIIhMqb6bv03qvclga6yoqvPkC0c7KNAFJFtlp/Xf5NFKVOvPvIKuR+1mAVE6ELBUF97GfONFP5iiuzKI9UrvcnmBiHqBK17MN97XfYRjMfMX7w== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(356005)(40460700003)(53546011)(81166007)(6506007)(83380400001)(6512007)(44832011)(2906002)(186003)(8936002)(5660300002)(36756003)(2616005)(31686004)(70586007)(70206006)(6666004)(82310400004)(508600001)(47076005)(6486002)(336012)(26005)(54906003)(86362001)(8676002)(6862004)(4326008)(36860700001)(316002)(31696002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 09:47:50.9726 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 271ada4b-7529-4830-63b0-08da0344351f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5790 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 09:47:57 -0000 On 3/11/22 10:40, Yvan Roux wrote: > Hi, > > I'll let Christophe address the comments and update the patchset, but I was > able to test it on an arm linux plateform I don't see any regression in the > testsuite. Thanks, good news! > > Sorry I wasn't on the list when the patches were submitted, but I think there > is a small issue this one: > > [PATCH v3 1/5] gdb/arm: Fix prologue analysis to support vpush > > + /* Calculate offsets of saved registers. */ > + for (; number > 0; number--) > + { > + addr = pv_add_constant (addr, -8); > + stack.store (addr, 8, pv_register (ARM_D0_REGNUM + number, 0)); > + } > > Here the D registers to store are computed by adding number to D0 but the first > register should be the one encoded by D:Vd value which are bits 6 of insn and > 15..12 of inst2 > Indeed, thanks for noticing. I have a WIP patchset we plan to submit shortly. Thanks, Christophe > Cheers, > Yvan > > On Sun, Mar 06, 2022 at 10:19:52PM +0100, Christophe Lyon via Gdb-patches wrote: >> >> >> On 3/6/22 11:48, Joel Brobecker wrote: >>>>>> Will you be able to review this patch series from Christophe? >>>>> I see that the v3 series was posted on Feb 4th, while on Feb 6th >>>>> I reviewed v2 :-(. This is really unfortunate that we don't have >>>>> a better system for tracking whether a version of a series is >>>>> trully the latest version. >>>> >>>> No problem, there's not much difference between v2 and v3, >>>> so your comments still apply. I should have answered earlier. >>>> >>>>> >>>>> Can you take a look at the comments and question I asked in v2, >>>>> and publish a v4 which takes those into account? Please Cc: me >>>>> on the submission of the patches, this will help me remember >>>>> to prioritize those patches. >>>> >>>> >>>> Sure! >>>> >>>> Luis and I changed jobs at the same time, so there's a bit >>>> of lag :-) >>> >>> No problem! >>> >>> Just for the avoidance of doubt and you don't end up waiting on me, >>> my understanding is that the next step is for you to produce a v4 >>> with some of my comments addressed, and to post answers/questions >>> for my comments. Is that right? >>> >> >> Yes, that's what I meant :-) >> >> Thanks, >> >> Christophe >