From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 1D93A385C416 for ; Fri, 30 Sep 2022 15:50:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D93A385C416 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id CD79C300089; Fri, 30 Sep 2022 15:50:41 +0000 (UTC) Message-ID: <0fec0ecc-952f-006d-de51-cc8f3a357689@irq.a4lg.com> Date: Sat, 1 Oct 2022 00:50:41 +0900 Mime-Version: 1.0 Subject: Re: [PATCH] gdb: Remove unused extra_lines variable Content-Language: en-US To: Bruno Larsen Cc: gdb-patches@sourceware.org, Tom Tromey References: <3090ae2157c8eae596b1bf5989c1853b865fdacf.1664093762.git.research_trasio@irq.a4lg.com> From: Tsukasa OI In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2022 15:50:46 -0000 On 2022/09/26 18:00, Bruno Larsen wrote: > On 25/09/2022 10:17, Tsukasa OI via Gdb-patches wrote: >> Clang generates a warning if there is a variable that is set but not used >> otherwise ("-Wunused-but-set-variable").  On the default >> configuration, it >> causes a build failure (unless "--disable-werror" is specified). >> >> The only extra_lines use in arrange_linetable function is removed on the >> commit 558802e4d1c5dcbd0df7d2c6ef62a6deac247a2f >> ("gdb: change subfile::line_vector to an std::vector").  So, this >> variable >> should be removed to prevent a build failure. > > Hi Tsukasa! > > This patch looks pretty safe. The point at which extra_lines would be > used has the exact same check used to set it, instead of using the > variable, so I think there is no need for it after all. > > That said, I can't approve the patch for pushing, so I hope a maintainer > looks at this soon. > >> >> gdb/ChangeLog: >> >>     * xcoffread.c (arrange_linetable): Remove unused extra_lines. > side note, GDB doesn't require changelogs anymore, but there are no > rules against it, so you can leave it here if you'd like. Thanks for letting me know! A maintainer (Tom) approved the patch and I removed the ChangeLog in the commit message (as an obvious change) and then pushed. The original intent of ChangeLog was to keep formatting as common as Binutils but it required extra work (contrib/mklog.py does not work properly on GDB files) and I think I looked pretty old version of contribution guide or something when I decided to do so. Thanks, Tsukasa > > Cheers, > Bruno > >> --- >>   gdb/xcoffread.c | 8 -------- >>   1 file changed, 8 deletions(-) >> >> diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c >> index b7d65771115..aa88cbc724d 100644 >> --- a/gdb/xcoffread.c >> +++ b/gdb/xcoffread.c >> @@ -419,8 +419,6 @@ add_stab_to_list (char *stabname, struct >> pending_stabs **stabvector) >>   static void >>   arrange_linetable (std::vector &old_linetable) >>   { >> -  int extra_lines = 0; >> - >>     std::vector fentries; >>       for (int ii = 0; ii < old_linetable.size (); ++ii) >> @@ -436,12 +434,6 @@ arrange_linetable (std::vector >> &old_linetable) >>         e.line = ii; >>         e.is_stmt = 1; >>         e.pc = old_linetable[ii].pc; >> - >> -      /* If the function was compiled with XLC, we may have to add an >> -         extra line entry later.  Reserve space for that.  */ >> -      if (ii + 1 < old_linetable.size () >> -          && old_linetable[ii].pc != old_linetable[ii + 1].pc) >> -        extra_lines++; >>       } >>       } >>   >> base-commit: 58d69206b8173b9d027a6c65f56cdaf045ae6e64 >