Re: [PATCH,v2 testsuite] Fix some duplicate test names

[Pedro Alves <palves@redhat.com>]

Hi, spotted a couple more issues:

On 5/26/20 6:39 PM, Luis Machado wrote:
>      gdb_test_multiple "$test" "$test" {
>  	-re "Breakpoint (\[0-9\]*) at .*$where.*$gdb_prompt $" {
>  	    set bp $expect_out(1,string)
> -	    pass "$test"
> +	    pass "$test inserted as number $bp"

Same issue with FAIL vs PASS messages.  This needs to be:

 -     gdb_test_multiple "$test" "$test" {
 +     gdb_test_multiple "$test" "$test inserted as number $bp" {
  	-re "Breakpoint (\[0-9\]*) at .*$where.*$gdb_prompt $" {
  	    set bp $expect_out(1,string)
 -	    pass "$test"
 +	    pass $gdb_test_name


> -    gdb_test_multiple "break *test_str_pc" "break test_str_pc" {
> +    gdb_test_multiple "break *test_str_pc" "" {
>  	-re "Breakpoint.*at.* file .*$srcfile, line.*\r\n$gdb_prompt $" {
> -	    pass "break test_str_pc"
> +	    pass $gdb_test_name
>  	}
>  	-re "No symbol.*\r\n$gdb_prompt $" {
>  	    pass "break test_str_pc"

Please update the other "-re" cases too, so they all have the
same message.  Here the pass call in the last line shown has
a different message.

Thanks,
Pedro Alves