From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 330523851C0B for ; Sun, 24 May 2020 14:34:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 330523851C0B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A04DD1E5F9; Sun, 24 May 2020 10:34:33 -0400 (EDT) Subject: Re: [PATCH 1/2] [gdb/testsuite] optional flags for compile_and_download_n_jit_so To: Mihails Strasuns , gdb-patches@sourceware.org References: <20200512113308.9502-1-mihails.strasuns@intel.com> <20200512113308.9502-2-mihails.strasuns@intel.com> From: Simon Marchi Message-ID: <1023ec01-9a14-5389-4fda-3f0f15ff6437@simark.ca> Date: Sun, 24 May 2020 10:34:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200512113308.9502-2-mihails.strasuns@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 May 2020 14:34:35 -0000 On 2020-05-12 7:33 a.m., Mihails Strasuns via Gdb-patches wrote: > Allows to pass in optional extra compilation flags to > compile_and_download_n_jit_so function. > > gdb/testsuite/ChangeLog: > > 2020-05-13 Mihails Strasuns > > * lib/jit-elf-helpers.exp (compile_and_download_n_jit_so): new > optional argument for compiler flags > --- > gdb/testsuite/lib/jit-elf-helpers.exp | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/lib/jit-elf-helpers.exp b/gdb/testsuite/lib/jit-elf-helpers.exp > index ab647abe50..2f6aa73414 100644 > --- a/gdb/testsuite/lib/jit-elf-helpers.exp > +++ b/gdb/testsuite/lib/jit-elf-helpers.exp > @@ -72,9 +72,12 @@ proc compile_jit_elf_main_as_so {main_solib_srcfile main_solib_binfile options} > # Compile jit-elf-solib.c as a shared library in multiple copies and > # upload them to the target. > # > +# EXTRA_OPTIONS may be passed as an optional argument to be added to > +# the compilation options. > +# > # On success, return a list of target path to the shared libraries. > # On failure, return -1. > -proc compile_and_download_n_jit_so {jit_solib_basename jit_solib_srcfile count} { > +proc compile_and_download_n_jit_so {jit_solib_basename jit_solib_srcfile count {extra_options}} { > global jit_load_address jit_load_increment > set binfiles_target {} > > @@ -93,7 +96,8 @@ proc compile_and_download_n_jit_so {jit_solib_basename jit_solib_srcfile count} > set options [list \ > additional_flags=-DFUNCTION_NAME=[format "jit_function_%04d" $i] \ > additional_flags=-Xlinker \ > - additional_flags=-Ttext-segment=$addr] > + additional_flags=-Ttext-segment=$addr \ > + $extra_options] If extra_options is meant to be a list, I don't think that will work when it will contain multiple items: % set extra_options {debug something-else} debug something-else % set options [list hello $extra_options] hello {debug something-else} You can do it with concat: % set extra_options {debug something-else} debug something-else % set options [list hello] hello % set options [concat $options $extra_options] hello debug something-else Otherwise, this patch LGTM. Simon