From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by sourceware.org (Postfix) with ESMTPS id 1E1F03858D1E for ; Wed, 29 Mar 2023 17:21:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E1F03858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x82f.google.com with SMTP id bz27so15826281qtb.1 for ; Wed, 29 Mar 2023 10:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680110461; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=ldxyMVNtC4eoWFK5rDY/jOuMipvUYnMMKf0PuWjF3ck=; b=YAO5iYYDIK/asDFlmp84AcXXRH+AOUlOTua8fnjiZD/zp6l/nmHNlbY6LAplDyG1U6 Mvr7Ey7IgpolCb6Wqem2kzwlp6XHZZBEwZp8Dp6Ekl56P1vIbhKUq3ONquSWvAaxIcIm P4Wbfu6+do3OBqqrpdGq8gKFRrgOtGUyPMUv2qs8xDeberdFo+/NhVkGKW9LTG6ai0G+ 6In0zb4vyBV4kgfxN+3q7nwir3spJVzr04ceA1O2dAVeoMRb5Fq8aOmYjvbvD+pm1i37 85ca+RFMesIEjn7oM2m6UfHSbFXs7gBPUqNwsb4+yFVIHsOoJmHLtDkBBKBp1Lqg/vqm 8ttw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680110461; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ldxyMVNtC4eoWFK5rDY/jOuMipvUYnMMKf0PuWjF3ck=; b=Nd6mn8mL7Ial7CY7FdXztFoLadi7jrT2BDi3LLrlwFApoaB71yvGugqw5uh+H9cJof bY7aH4ibZDMdkAKm3y6zXUdQog9OyLBDxoDyRvujj3oeeVTQQHSgExO1FDX1I3FMRWBZ mkvKenY2iLttKwZwb6ttcrsiFkhM/33GeH9iwRkySe4DBM4abyABoeIFK4sw+u2xdaL9 +XREt45EJYyHB6RE1LcpUWVck8nnrh96NPGTohHzn+zx7ZFBLy2YZeT6Wzc2bdYUdtEb B06L3jXeTt9IoJYnpIX/WO9l2Y/Kili4dU8QMxCF21cuDc+s4m4jsaJjr6f27UWtrlx0 JW6g== X-Gm-Message-State: AAQBX9cWZCZyqF7lPtzll/+PrpSXQRtwp868qIU1d+BkiIEBQMyek/db Wk4KRLYCsIHUc6t50o82lvjWD9rq0ng= X-Google-Smtp-Source: AKy350bGAb/4AieiQD4AF9LbiPp5hO/nlkqQwmlSF2vYmp5jTI9rBlf0urWiUv+AwU6nn1FFddR9bg== X-Received: by 2002:a05:622a:494:b0:3e4:e5bf:a24c with SMTP id p20-20020a05622a049400b003e4e5bfa24cmr21213835qtx.62.1680110461421; Wed, 29 Mar 2023 10:21:01 -0700 (PDT) Received: from [192.168.1.128] (173-246-5-136.qc.cable.ebox.net. [173.246.5.136]) by smtp.gmail.com with ESMTPSA id j1-20020a378701000000b007456b51ee13sm18726425qkd.16.2023.03.29.10.21.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Mar 2023 10:21:00 -0700 (PDT) Subject: Re: [PATCH 1/2] gdb/doc: MPFR is now a necessary requirement To: Simon Marchi , gdb-patches@sourceware.org Cc: Andrew Pinski References: <20230306-doc-require-mpfr-fix-v1-0-8f207504dd3e@gmail.com> <20230306-doc-require-mpfr-fix-v1-1-8f207504dd3e@gmail.com> <3d16dc5d-d034-8589-785e-9d994c4f77a5@simark.ca> From: Philippe Blain Message-ID: <102abb23-a0cd-a5ed-11a0-6f2b3ff4314b@gmail.com> Date: Wed, 29 Mar 2023 13:21:00 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <3d16dc5d-d034-8589-785e-9d994c4f77a5@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Simon, Le 2023-03-27 à 17:13, Simon Marchi a écrit : > On 3/10/23 12:46, Philippe Blain via Gdb-patches wrote: >> Since 99118062785 (Use toplevel configure for GMP and MPFR for gdb, >> 2022-11-08), MPFR is mandatory for building GDB. That commit adjusted >> the "Requirements for Building GDB" section of the documentation so that >> the MPFR entry mentions "now uses" instead of "can use", but left the >> whole entry under the "Tools/Packages Optional for Building GDB" >> heading. >> >> Move the MPFR entry to the "Tools/Packages Necessary for Building GDB" >> heading. >> --- >> gdb/doc/gdb.texinfo | 30 +++++++++++++++--------------- >> 1 file changed, 15 insertions(+), 15 deletions(-) >> >> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >> index 2a2077c29d1..218c2da9c86 100644 >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -39781,6 +39781,21 @@ you can use the @option{--with-gmp} option or options >> @option{--with-gmp-include} and @option{--with-gmp-lib} to specify >> its location. >> >> +@item MPFR >> +@anchor{MPFR} >> +@value{GDBN} now uses the GNU MPFR multiple-precision floating-point > > Unlike in the NEWS file, where we describe the changes from one version > to another, the documentation is meant to describe the GDB version is > comes with. Therefore, I find it odd to use "now" in the documentation. > I would just say "GDB uses the GNU MPFR...". I know it's pre-existing > text and it's the same in the GMP paragraph, but it sounds weird there > too. Imagine reading the doc 20 years down the road, and it says "GDB > now uses the GNU GMP...", as if it's a new thing. Yes, I agree. I avoided changing that to keep the existing text as is, and indeed also because the GMP entry uses the same wording. I'll tweak both in v2. Thanks, Philippe.