From: Pedro Alves <palves@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>,
John Marshall <John.W.Marshall@glasgow.ac.uk>
Cc: Nick Clifton <nickc@redhat.com>, Alan Modra <amodra@gmail.com>,
Binutils <binutils@sourceware.org>,
GDB <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/3] Add DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION
Date: Mon, 04 Jun 2018 13:40:00 -0000 [thread overview]
Message-ID: <1032a2ef-e852-b30b-8d40-7ea64775e1a8@redhat.com> (raw)
In-Reply-To: <CAMe9rOox6mZ6MX=GyC7-XJ2GuDzc5cjrLDyc3Hei5gBR4fWw7w@mail.gmail.com>
On 06/04/2018 02:30 PM, H.J. Lu wrote:
> On Mon, Jun 4, 2018 at 5:46 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Mon, Jun 4, 2018 at 5:19 AM, Pedro Alves <palves@redhat.com> wrote:
>>> On 06/04/2018 01:13 PM, Nick Clifton wrote:
>>>> Hi H.J.
>>>>
>>>>> +# if __GNUC__ == 8 && __GNUC_MINOR__ < 2
>>>>> +# define DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION \
>>>>> + DIAGNOSTIC_IGNORE ("-Wstringop-truncation")
>>>>> +# endif
>>>>>
>>>>> OK for master?
>>>>
>>>> Approved - please apply.
>>>
>>> Please don't. This is again going against the intention of
>>> the header. The GCC version checks should be put in the
>>> places where the warning needs to be suppressed.
>>> The current patch makes all current and future uses of
>>> DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION only apply to
>>> GCC 8.1. That is incorrect. Consider what you will
>>> have to do to suppress some -Wstrinop-truncation warning
>>> with DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION on GCC 8.2 or
>>> GCC 9 or whatever.
>>
>> This is what my original patch intended to do. But diagnostics.h from
>> GDB doesn't support GCC version. Should I extend it to match glibc?
>>
>>> Also, you can use GCC_VERSION to make the version check
>>> a little simpler.
>
> My second patch is needed for Darwin. I will check it in as is
> and update it with a follow up patch to support GCC version.
For the record, I think it would have been better procedure
to split and push the DIAGNOSTIC_STRINGIFY bit only [1], while
giving people reasonable time to respond to the rest.
https://sourceware.org/ml/gdb-patches/2018-06/msg00062.html
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-06-04 13:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 12:16 [PATCH 1/3] Move gdb/common/diagnostics.h to include/diagnostics.h H.J. Lu
2018-05-21 13:10 ` [PATCH 2/3] Add DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION H.J. Lu
2018-06-01 7:57 ` Nick Clifton
2018-06-01 10:19 ` Alan Modra
2018-06-01 16:51 ` H.J. Lu
2018-06-04 12:13 ` Nick Clifton
2018-06-04 12:19 ` Pedro Alves
2018-06-04 12:46 ` H.J. Lu
2018-06-04 13:31 ` H.J. Lu
2018-06-04 13:40 ` Pedro Alves [this message]
2018-06-04 14:04 ` Pedro Alves
2018-05-21 13:12 ` [PATCH 3/3] Use DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION to silence GCC 8 H.J. Lu
2018-06-01 7:59 ` Nick Clifton
2018-06-04 16:58 ` H.J. Lu
2018-06-04 17:06 ` Pedro Alves
2018-07-02 16:25 ` Tulio Magno Quites Machado Filho
2018-05-21 14:12 ` [PATCH 1/3] Move gdb/common/diagnostics.h to include/diagnostics.h Simon Marchi
2018-06-01 7:49 ` Nick Clifton
2018-06-04 10:51 ` John Marshall
2018-06-04 13:12 ` H.J. Lu
2018-06-04 13:24 ` John Marshall
2018-06-04 13:35 ` Pedro Alves
2018-06-04 13:37 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1032a2ef-e852-b30b-8d40-7ea64775e1a8@redhat.com \
--to=palves@redhat.com \
--cc=John.W.Marshall@glasgow.ac.uk \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).