Re: [PATCH 2/4] Return true in TuiWindow.is_valid only if TUI is enabled

[Hannes Domani <ssbssa@yahoo.de>]

 Am Samstag, 23. Januar 2021, 18:55:56 MEZ hat Andrew Burgess <andrew.burgess@embecosm.com> Folgendes geschrieben:

> * Andrew Burgess <andrew.burgess@embecosm.com> [2021-01-23 17:54:42 +0000]:
>
> > * Hannes Domani <ssbssa@yahoo.de> [2021-01-17 13:19:41 +0000]:
> >
> > >  Am Sonntag, 17. Januar 2021, 12:31:05 MEZ hat Andrew Burgess <andrew.burgess@embecosm.com> Folgendes geschrieben:
> > >
> > > > After further though I think there's an even better solution for this
> > > > issue.  See the patch below.
> > >
> > > This version crashes for me when I disable and then re-enable TUI, because
> > > tui_windows and tui_win_list are empty, not filled again in tui_enable, and the
> > > tui_update_gdb_sizes call at the end of tui_enable dereferences TUI_CMD_WIN.
> > >
> > > Also, and I think your previous patch behaves the same, but I can no longer use
> > > the TuiWindows variables width/height/title inside my Window.close function,
> > > because at this point tui_active==false, so the assertion inside is_valid
> > > fails.
> > > This can be worked around by saving the values in some Window class members,
> > > but it is more inconvenient.
> >
> > Hannes,
> >
> > Would you be able to give the version below a try please and let me
> > know if you are still seeing any problems.
> >
> > This is much more like the first patch I posted.
> >
> > I honestly think the second approach is better, but it throws up so
> > many other issues that would need to be resolved around the whole
> > disable/enable transition, that I think going with the first approach
> > is just going to be simpler.
> >
> > Anyway, I think this covers all the situations you've described so
> > far, but let me know if you still see any issues.
> >
> > Thanks,
> > Andrew
>
> Might help if I included the patch :)

Yes, with this I have seen no problems so far.


Hannes