From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 0DFD83858C2C for ; Sun, 5 Dec 2021 02:31:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0DFD83858C2C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1B52VKEp009014 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 4 Dec 2021 21:31:24 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1B52VKEp009014 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C29071EDF0; Sat, 4 Dec 2021 21:31:19 -0500 (EST) Message-ID: <104bfab9-d713-1ec8-3a44-09a8403e2c3f@polymtl.ca> Date: Sat, 4 Dec 2021 21:31:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 3/3] Cache the result of find_file_and_directory Content-Language: en-US To: Tom Tromey , Joel Brobecker Cc: gdb-patches@sourceware.org References: <20211130013304.4135367-1-tom@tromey.com> <20211130013304.4135367-4-tom@tromey.com> <87tufotela.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87tufotela.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 5 Dec 2021 02:31:20 +0000 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Dec 2021 02:31:29 -0000 On 2021-12-04 13:22, Tom Tromey wrote: >>> This changes the DWARF reader to cache the result of >>> find_file_and_directory. This is not especially important now, but it >>> will help the new DWARF indexer. > > Joel> With the renaming of the class members moved to patch #2 (I made the > Joel> assumption that all the changes in file-and-dir.h are about that, at > Joel> least from what I could see), this patch looks good to me. > > Thanks, I'm going to check these in now. > > Tom > Hi Tom, I see these failures on Ubuntu 20.04, when building with AddressSanitizer, starting with this patch. gdb.dwarf2/imported-unit.exp - ptype main gdb.dwarf2/imported-unit-abstract-const-value.exp - p aaa gdb.dwarf2/imported-unit-bp-c.exp - break /tmp/imported-unit-bp-alt.c:19 gdb.dwarf2/inlined_subroutine-inheritance.exp - setting breakpoint at bytes_repeat (eof) Simon