From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by sourceware.org (Postfix) with ESMTPS id BB2CD3830885 for ; Fri, 20 May 2022 19:43:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB2CD3830885 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f49.google.com with SMTP id ay35so3454859wmb.5 for ; Fri, 20 May 2022 12:43:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Vnj6nhLG9xZldt5kxOKd0aKgGzdJ/dVOytJTCq5meS8=; b=RJ7m5ZuegVR/eIsZ91u/SeJiToDFNlVYY5e6gMsX6ZsuCpfg4AXiCrla/feh09INjw Ml3HYjuuFP3/8ZERM9YajHm95xKGxN++V7lnU2TpiTauPs9gVw+nSeOxSgxCZ3eUDMeT feF6JmhmPt0HxxCR/XqLlkx+xaUVVRd/GsXFqpGvwHyQ0DDfmOifzABMyND36K0NH6Ud tq8XjlnVKn0jcdT3FCLxf4WrggPp2jqkb+R3j63ezd5FTWPfOOEdyuhFf392yp25U14n +gcXnrctxA0+qHq2vIZ1xGRPghk55SSZsArOd1Dhk1xfwGlQALXiFlAqUCPMt78h+N6X wJSg== X-Gm-Message-State: AOAM533stpRu2yg73vART6tSHJezvA+ZWh4au1+4o24DFbjjFGxCw4Rb inKb6xhtgFQcdKH82fUBVLmzHWHkyxsbqQ== X-Google-Smtp-Source: ABdhPJxv52hkgo4oTQ7+RiwtDmndWZyP6blvCwFv8MXUpEwsJQj77iXwJRlat6TLpdQXi2SQWMQU3A== X-Received: by 2002:a7b:c4da:0:b0:397:3d76:49d8 with SMTP id g26-20020a7bc4da000000b003973d7649d8mr2258002wmk.57.1653075800707; Fri, 20 May 2022 12:43:20 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id z1-20020adfc001000000b0020e5b2afb3bsm3238659wre.23.2022.05.20.12.43.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 12:43:19 -0700 (PDT) Message-ID: <1088b580-e33f-acb9-4e84-adadf597c18e@palves.net> Date: Fri, 20 May 2022 20:43:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 00/23] More breakpoints cleanups Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20220516184030.665489-1-pedro@palves.net> <8735h4b34a.fsf@tromey.com> From: Pedro Alves In-Reply-To: <8735h4b34a.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 19:43:23 -0000 On 2022-05-20 17:06, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> The main goal of this series was to eliminate init_raw_breakpoint. > Pedro> It slowly tweaks a number of things to be able to do that. > > I looked through these again today, and sent one minor comment. > This all looks good to me, thank you for doing it. Thanks Tom. I've merged this after addressing comments and retesting.