From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3757 invoked by alias); 26 Jan 2016 05:39:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3741 invoked by uid 89); 26 Jan 2016 05:39:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=letter, H*M:JavaMail X-HELO: nm42-vm6.bullet.mail.ne1.yahoo.com Received: from nm42-vm6.bullet.mail.ne1.yahoo.com (HELO nm42-vm6.bullet.mail.ne1.yahoo.com) (98.138.121.62) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 26 Jan 2016 05:39:47 +0000 Received: from [127.0.0.1] by nm42.bullet.mail.ne1.yahoo.com with NNFMP; 26 Jan 2016 05:39:45 -0000 Received: from [98.138.101.129] by nm42.bullet.mail.ne1.yahoo.com with NNFMP; 26 Jan 2016 05:36:59 -0000 Received: from [98.138.89.245] by tm17.bullet.mail.ne1.yahoo.com with NNFMP; 26 Jan 2016 05:36:59 -0000 Received: from [127.0.0.1] by omp1059.mail.ne1.yahoo.com with NNFMP; 26 Jan 2016 05:36:59 -0000 Received: by 98.138.105.249; Tue, 26 Jan 2016 05:36:59 +0000 Date: Tue, 26 Jan 2016 05:39:00 -0000 From: Toshihito Kikuchi Reply-To: Toshihito Kikuchi To: "Paul_Koning@Dell.com" , "palves@redhat.com" Cc: "jhb@freebsd.org" , "gdb-patches@sourceware.org" Message-ID: <1095889805.138513.1453786618993.JavaMail.yahoo@mail.yahoo.com> In-Reply-To: References: Subject: Re: [PATCH] Add a new format letter to dump instructions backward MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00641.txt.bz2 Thank you for the great suggestion. I also agree that #3, adding the support for a negative number, looks reasonable. I'll get back to this thread when the code is ready. To answer the question from Paul, Pedro's guess is correct. I used symbol's line info to solve a correct frame. And yes, this feature does not work without debug information unfortunately. Since I'm not familiar with architectures other than x86, let me finish this work in the current approach first. If there are architectures where instruction length is fixed, I think I can add them later. > Adding some tests would be great. Also, the documentation > will need to be updated. > > If you haven't yet, please take a look at: > https://sourceware.org/gdb/wiki/ContributionChecklist Thank you for pointing to this. I looked at only gdb/CONTRIBUTE and didn't reach this. Tests and doc updates will be included in next patch. Thanks, Toshihito