From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90859 invoked by alias); 3 Oct 2016 17:40:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90772 invoked by uid 89); 3 Oct 2016 17:40:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=H*F:D*ericsson.com, HX-AuditID:sk:c1b4fb2, HX-HELO:sk:sesbmg2, H*RU:193.180.251.37 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Oct 2016 17:40:02 +0000 Received: from ESESSHC019.ericsson.se (Unknown_Domain [153.88.183.75]) by (Symantec Mail Security) with SMTP id 96.E6.31035.EE792F75; Mon, 3 Oct 2016 19:39:59 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 3 Oct 2016 19:39:57 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.110.144] (192.75.88.130) by DB4PR07MB396.eurprd07.prod.outlook.com (10.141.236.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.639.5; Mon, 3 Oct 2016 17:39:56 +0000 Subject: Re: [PATCH v3 1/2] Emit inferior, thread and frame selection events to all UIs To: Pedro Alves , Simon Marchi , References: <20160924201331.23605-1-simon.marchi@polymtl.ca> <906fc6d1-01f2-c81b-2ff9-ef11b787ec9e@redhat.com> CC: Antoine Tremblay From: Simon Marchi Message-ID: <10ca4c2c-29cf-8edb-c9e3-087d2e6461d2@ericsson.com> Date: Mon, 03 Oct 2016 17:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <906fc6d1-01f2-c81b-2ff9-ef11b787ec9e@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL2PR20CA0024.namprd20.prod.outlook.com (10.167.113.162) To DB4PR07MB396.eurprd07.prod.outlook.com (10.141.236.19) X-MS-Office365-Filtering-Correlation-Id: 47a5bf3e-c0a2-407c-bfc5-08d3ebb44b22 X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB396;2:/t//DSvinw3aXmCfDrGdIcrvSpDncdZfWWUjS5zuuT7IZOSgr7kdXyqD4JeHq055e7B3S8OLiccu8e5+AbMTUvFqspetzcmB/D5YK85l3HkJfFNW6AQqiba4oTLehNFTiVbqqhUxR7RNDiPagoBSPPNrC74gJgjusz4rYu/TzylgCLf962vKifGeFiIQqY9w;3:NN/D/CmFHsvTvtbXUGK7yjcVice2jQ94T+iZaEuPkHsRATzCclbctbAuzT1YbIHHM5uMMXF2UI7P+xg0HHD3emExrUlpex9UZic6grXpULAzdfwWx5KBKsJ37oiA0EXK;25:z2AfPuREwTX6K8sK4v06CpvMAJsfFPae6AlbaPL3k31yjnxu0P/nwJhtTrITtUn5Sb8A2AiHQbOj9FTwqJbxNcpI77prTIT1gKXjtbn2p2/OdMjJZ0C7l+7ZMx37Phfk6M63/ElCRK4VQYymvluOsnrWZe6CHF21XkDjOa6+ZZV/iSOPwhMtintyle6uS7YXKrBiMEuFCQlOsEVnP9qUQuODvbVuPtstxRvK6lOHptcDO/JQQhbtBMeiztFpwnlxs1wUSAQ1WjLgdmd1HC5CWiGO3v+zrqclyIGLsAveObBvXg5bze1NUdZhLJmspQoRz++EsxSzdkJKFjH/DRD0FkF257h/RiG9sDqBwgRJW0U3A3bMKNRNnjiDgaW6zciA7Nswl5ivMnXQPQuFJsK23tMpqEUAlsELWllBGB7bc+o= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB4PR07MB396; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB396;31:z5XDjACFlzkxvTdUb9TdENRJHpBo9hT6rlZ68lfs5XuuOEliSVXQ2MQqDitIC5y9zPDeH4f1h4muiCPz2N2jgh1Lh8U4mVqNPIXES0U0+pFHWYkz4UEBIi71On1SuvgsKfeIloxYwdzRFPSTKUBxFQausLKtAVRIgK2b37ajnbU4neT0BNlxkuXPC99TYkhWvNDhKGfC5lE+OP5fHt0Aj44jJ2mV2pJYVuVMJmtEShb5aEKtU9uYaz9wylZOeKHY;20:rJ+ZgIKS/JNy2CE60OfcoJC1ZAVEpCtNOeANbZkJP+1kkO5Lf8ylwdVFOBhUMrWAwIFx9784LmeNu26UyVRSkZKU3itS8Bw3SayJe3PJcX6D/1Blti/m0SzDk8RreoZ/ZHjEaPkrc+BwjDl9/TuGAbcqRRl7pgaCnGKRKUPIJ+WEpwsgbaRZP3CgeGcrkIbW+3zUOVunHs5TWTPUXkjWTZoGzgF0G2sstlXZFx6puRo55I89zGIUjVqn7FeGGyypD2XnFE83oLsbxvdXPTvdpHfryIVnd8r0l2QunKSTJV0BWcb6A4EZIJLYY0jn8mBiapYPpy/iw2a+HCPqnnSUcyik+BgWxkyqF4z6YV4vJ10Lbm6ThtmuMwDcy/g+3BXsrMOdRcMve7cVJMvnYPsXKdXH6aTuaUd9RhJPHICp4+0bSajKr46JaZ0r/INayGb7poQZkupyB7488pFBAEQekf/WBEWhqvnUt4jy56JZJE3zAX6c0sqQc04QByO+rtc/ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:DB4PR07MB396;BCL:0;PCL:0;RULEID:;SRVR:DB4PR07MB396; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB396;4:hPZJcoQaWjvLAPNq7cGOUmOjptSi9LwFy/YpNwAd5f6aT6ETjBbHNhgitTVtyWufU/TeyYVs39RQrMv3evmtgnOKVTbdQcOMErToGAePWpkQGkQdaWr/7H5y6MQZ4zxahonBLJnTXFzjZ3oYJ1DNy/3at/yb0XG5QicpuSEA6QfVTxgBDj7KPCcuI30ufFgwDRLDfZ2GXc4bgyPkPUzvYM8Vw4fyu1mpJiGKlyhBbuzr9ajYOtlAB//syOfiyBtYnLPmutsqulEGa1qKvq0r9WhE7XSy3NvVIRqpji2XLKkMb8bu8z6NfKiRPoWu28jz4cOldSKbiiormLwn0A4qCO31lRwBD6uqlMKOWXo9k/sBcRmm/c1gl5d7bJ/Y4pHERXixzW7HK1L7VHZEBkw1qA== X-Forefront-PRVS: 008421A8FF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(189002)(24454002)(199003)(377424004)(377454003)(76176999)(4001350100001)(54356999)(97736004)(86362001)(5001770100001)(107886002)(105586002)(106356001)(586003)(4001430100002)(64126003)(65806001)(2950100002)(101416001)(3846002)(42186005)(189998001)(50466002)(6116002)(36756003)(5660300001)(31686004)(23746002)(65956001)(66066001)(65826007)(81156014)(6666003)(230700001)(2906002)(68736007)(77096005)(50986999)(31696002)(8676002)(83506001)(92566002)(47776003)(33646002)(7736002)(7846002)(81166006)(4326007)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR07MB396;H:[142.133.110.144];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB4PR07MB396;23:wrKv6qSTB7cMgJJpYa8M6XZDYREMGkf5duYAOr?= =?Windows-1252?Q?Lk8jnMZerbBPwerFJ6VainENMOQAkn+z/cYuQq2uaKVw9/2pVG0tt0Dl?= =?Windows-1252?Q?OjyqSWls1+CM2hUGMOM0Nf+sDsNceiaTz6k+IAU58mstmevDjk9mhDLb?= =?Windows-1252?Q?CYElZ8v+z+RagQqTUFHjSXl4+s6Q2JXxfxkSX/hYdGdWwuM1orDpfIwz?= =?Windows-1252?Q?GsiILh7HCi6oFNqmh+lI3zi4q5YVpxr5prfYqIJ1sP/aJo2wC5+KssrM?= =?Windows-1252?Q?UXGzgxaSdvnZRLU0j3oTfYk0WKcrk8BW27HBUhoP/kLxQStKsrsxvy3I?= =?Windows-1252?Q?wdYu60FalRKe7WLyftKzygGWEVPr4kbwGN2gLjb38enKA8fxLQh/6PtN?= =?Windows-1252?Q?egzDH8nuivq0xLNz5CkBU7w5AdqTms8XKqPwd6O60eX3SbPHJUR6iMcR?= =?Windows-1252?Q?n89SRq/qo8LOY+gZNx6LEZQuomG0w57FQjjCclPom7LSFxxF4ZU5Vd2c?= =?Windows-1252?Q?rCr0MDHzA+povXYXGMBFz3+Oawx53JoKKqdbN3VSaV/0LQs7oW9eEC9L?= =?Windows-1252?Q?t0zKBtmJDGrZQTf9KrzSMJknP6t4oN0TJz6eV7wIXMqs2Yt0aLeIQos/?= =?Windows-1252?Q?2zfwf8Dkpa7y5cX6iick0BJ2AimLAHAIxx6RH/QWmJvgjLQqVTLbVzQb?= =?Windows-1252?Q?JYgped3+TkrfHibMl6MCE2vEu/2a6L/OSizGLn0U3Bfi8SQiBdBunOy0?= =?Windows-1252?Q?k16LU1UezoyEv0694jbMAWGlCiiFo8ED5C24ibSFtuAhHoQDcR5afnxZ?= =?Windows-1252?Q?ftfHvYOmJAShmUv+lICMHcxMwKPbCHYISRElbgCWAzXojntQHCDx9rRV?= =?Windows-1252?Q?kMON6kXY3brWaYQ/aEL7r0pF+0AoksqXUr/EevYrDwqpCvNYP8LGCf/3?= =?Windows-1252?Q?UsWcHeqKyo0O1clbzR6Bjvhc3CNs6R07Y/nHp86RsA02SGs+7WI5CoRH?= =?Windows-1252?Q?ApwZlfl+HU3y0LUCMummyrquPgNvepWiFgZ9E6bqA6lvKDmQjgzzWFKD?= =?Windows-1252?Q?/RD0aDLN7vBLsB9PSaX68Esgz7A+c+UoeKqmfypwgBy/0O19UBjdC/J8?= =?Windows-1252?Q?qLKFvjpjxd4lLovgqXhVEKjmDIBH3vZzJGPwV/4ftzaOMf3la99XXdzP?= =?Windows-1252?Q?UpPL7TOyYsWzgtv8cJjHhX++OeP1NNU9E9LD6HBuLIlUFHGYR7ZqJJjS?= =?Windows-1252?Q?+ARrq4cZNCUApoBPqGhMch6ddLi+XLThSDm7nSSriWvaS0vMNkREMdqQ?= =?Windows-1252?Q?C1LO3jL+iH3HW3IhEQDvOLqdOo5Dg8hIWNkbEtLo3DU8JXD/TPaFTP0x?= =?Windows-1252?Q?/vN4bRJ5RWRLj5okzvEgKwGhCBG8JJlFO4rLmMRyNZ/p+/UzEpYERg5P?= =?Windows-1252?Q?oWrybXHAaqoiRRvU6unYG0PtZn6qcC7DwLVAYEsg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB396;6:bMCM5X9x4cJqBpxbp+tUtZenhxEQ3lpwU/Jo4mGxCOtvk61b+WIi3iFs0x+vjIQDYr+eQG4VZEacxTQTt7QoiUrtjCVengjUFNZe+QRsXiA6lZXa6guRpjYRk1CyYDwIRQ9JkMp323nJYjvN+WvB5ofMlPEyCLMtSWmy9/Uk3PnARBqcifM/GKuJxJRYdOMzV1RzUF2z+90eTwYE2caCOqWDFpxWel1hkqaedcGd+0rSFODIe2BguM+EDkq5z8leSP9dkdUTZdg/tUGDP2zIyMYJSxhnQK++P5mJVEik3TM=;5:usUW+VQOKCiDluFlMVch+dboI3/oopPJw2cwhDNTZcKLmPMvin6Fhh2oAIDONvAi+G+zqeg0tS0098M5qR4UTdT2DJnXEyMKyfGsd+OYfZ1tZckQkMo2lVL3Ezikqa/Pb3Sbc9sGSSc22d87rSQrkQ==;24:oWJUmOLmRwgjxlUrDd6UwdSEyJRoc3TIn10DVtzR/Q27FWhBKZwlEmGACdEL2zRQ5zRn4VhWMtEi5lvZhdjx104zvPs6/K89IiRv23JL4YA=;7:BTN9f4EKiYBYb9DFqwsycGtrfT+KwbtilHQmqaAhrIEIbXovws1hB7fhWBzn0XkRdwn5St3R0yBe4lhimZnqi4SI1tTg8xG7wrIbvmOj6ekAT3yCY/BPl4/i2/R4ETek3MCEPnNsZfFRyWsRMEpX6sVWMvUy6xxz0PSVbz4MW/bSaEZR7QWn7U1d3Gm4u8z4KDp3zKHK+E7o7jO0HcZyJ56LU9pgAWdMHoSxvpV6eqyeo2cmPn2DbO3AHucOwY2KkA3B4PmmX9iDpF0vexnUgbFpVYw1K+g3BUcah51RkRafxyzsXUgC+XTLlt4lFpYb SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2016 17:39:56.9305 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB396 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00019.txt.bz2 On 16-10-03 12:47 PM, Pedro Alves wrote: > Hi Simon, > > This looks good to me now, module a couple minor issues pointed out > below. Fix these and you're good to go. > > On 09/24/2016 09:13 PM, Simon Marchi wrote: >> @@ -1885,7 +1901,19 @@ void >> cmd_func (struct cmd_list_element *cmd, char *args, int from_tty) >> { >> if (cmd_func_p (cmd)) >> - (*cmd->func) (cmd, args, from_tty); >> + { >> + struct cleanup *cleanups = make_cleanup (null_cleanup, NULL); >> + >> + if (cmd->suppress_notification != NULL) >> + { >> + cleanups = make_cleanup_restore_integer (cmd->suppress_notification); > > This will incorrectly leave the null_cleanup not run. > You should not overwrite "cleanups". Should be just: > > + make_cleanup_restore_integer (cmd->suppress_notification); Done, thanks. >> + *cmd->suppress_notification = 1; >> + } >> + >> + (*cmd->func) (cmd, args, from_tty); >> + >> + do_cleanups (cleanups); > > > >> + else /* MI_COMMAND */ >> + { >> + if (strcmp (command->command, "interpreter-exec") == 0 >> + && command->argc > 1) >> + > > This empty line here made me pause and think that the code > looks suspicious. Better would be to wrap the then/else blocks > in {}s, since they're multi-line. Right, it's clearer. >> +@item =thread-selected,id="@var{id}"[,frame="@var{frame}"] >> +Informs that the selected thread or frame were changed. This notification >> +is not emitted as result of the @code{-thread-select} or >> +@code{-stack-select-frame} commands, but is emitted whenever an MI command >> +that is not documented to change the selected thread and frame actually >> +changes them. In particular, invoking, directly or indirectly >> +(via user-defined command), the CLI @code{thread} or @code{frame} commands, >> +will generate this notification. Changing the thread of frame from another >> +user interface (see @ref{Interpreters}) will also generate this notification. >> + > > Typo: s/thread of frame/thread or frame/ Woops, thanks. I'll give it a last complete test run before pushing. Simon